react-native-macos/React
Valentin Shergin b642677a97 Fabric: Removing `ComponentDescriptorProviderRegistry::remove()`
Summary:
This diff removes `ComponentDescriptorProviderRegistry::remove()` and two derivative interfaces.
First, we don't use that and there is no concrete idea why we would need to use that. Those were originally built only for symmetry with limited knowledge about what exactly we need.
Second, those methods are actually dangerous and probably must not be supported by design. Removing a ComponentDescriptorProvider destroys already registered `ComponentDescriptor`s, and at the same time we might have ShadowNodes referring to that (which will cause a crash), and there is no reasonable way to check for the existence of those nodes.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D18285497

fbshipit-source-id: b461e38b923c217a256e1155689311397a994feb
2019-11-06 14:43:41 -08:00
..
Base Ensure RCTDisplayLink and RCTTurboModuleManager are cleaned up properly [3/N] 2019-11-06 14:20:56 -08:00
CoreModules Fix invariant violation on launch 2019-11-06 04:22:45 -08:00
CxxBridge Re-implement reload reason [7/n] 2019-10-30 12:23:25 -07:00
CxxModule Replace folly::make_unique with std::make_unique (#26730) 2019-10-22 12:21:41 -07:00
CxxUtils Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
DevSupport Make RCTDevMenu and RCTDevSettings TurboModule-compatible 2019-11-04 16:07:23 -08:00
Fabric Fabric: Removing `ComponentDescriptorProviderRegistry::remove()` 2019-11-06 14:43:41 -08:00
Inspector Tidy up license headers [3/n] 2019-10-16 10:06:34 -07:00
Modules Make RCTTVNavigationEventEmitter TurboModule-compatible 2019-11-04 16:07:24 -08:00
Profiler Make RCTPerfMonitor TurboModule-compatible 2019-11-01 12:06:21 -07:00
UIUtils Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
Views RN: Delete Apple TV Props 2019-11-01 08:49:26 -07:00
React-RCTFabric.podspec Move non-license comments out of license header 2019-10-15 20:12:12 -07:00
third-party.xcconfig Upgrade folly to v2018.10.22.00 for iOS (#21976) 2018-10-29 12:13:11 -07:00