react-native-macos/ReactCommon
Valentin Shergin b642677a97 Fabric: Removing `ComponentDescriptorProviderRegistry::remove()`
Summary:
This diff removes `ComponentDescriptorProviderRegistry::remove()` and two derivative interfaces.
First, we don't use that and there is no concrete idea why we would need to use that. Those were originally built only for symmetry with limited knowledge about what exactly we need.
Second, those methods are actually dangerous and probably must not be supported by design. Removing a ComponentDescriptorProvider destroys already registered `ComponentDescriptor`s, and at the same time we might have ShadowNodes referring to that (which will cause a crash), and there is no reasonable way to check for the existence of those nodes.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D18285497

fbshipit-source-id: b461e38b923c217a256e1155689311397a994feb
2019-11-06 14:43:41 -08:00
..
better Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
callinvoker Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
config Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
cxxreact Replace folly::make_unique with std::make_unique (#26730) 2019-10-22 12:21:41 -07:00
fabric Fabric: Removing `ComponentDescriptorProviderRegistry::remove()` 2019-11-06 14:43:41 -08:00
hermes/inspector Tidy up license headers [3/n] 2019-10-16 10:06:34 -07:00
jsi Remove compact parameter from heap snapshots 2019-10-31 14:48:01 -07:00
jsiexecutor Tidy up license headers [3/n] 2019-10-16 10:06:34 -07:00
jsinspector Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
microprofiler Tidy up license headers [1/n] 2019-10-16 10:06:33 -07:00
turbomodule Ensure RCTDisplayLink and RCTTurboModuleManager are cleaned up properly [3/N] 2019-11-06 14:20:56 -08:00
utils Fabric: Cross-platform implementation of `monotonicTimeInMilliseconds` 2019-11-04 18:21:12 -08:00
yoga Use double for YGRoundValueToPixelGrid calculations 2019-11-05 17:14:39 -08:00
React-Fabric.podspec Back out "Fixes Fabric related podspec" 2019-11-01 19:34:46 -07:00
ReactCommon.podspec Move non-license comments out of license header 2019-10-15 20:12:12 -07:00
common.mk More robust hermes-engine lookup logic in makefiles (#26820) 2019-10-14 19:21:43 -07:00