microsoft
/
react-native-macos
зеркало из https://github.com/microsoft/react-native-macos.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
react-native-macos/React/Views
История
Binh Nguyen e341489521 Fix spinner is not shown on beginRefreshingProgrammatically on IOS (#27397) 
Summary:
It closes https://github.com/facebook/react-native/issues/24855
In the endRefreshProgrammatically of RCTRefreshControl.m there is calculation for content offset when spinner is shown CGPoint offset = {scrollView.contentOffset.x, scrollView.contentOffset.y - self.frame.size.height};
However self.frame.size.height is always 0 and therefore spinner is not visible
This change should fix that

Since the owner of the following PR is quite busy and won't be able to resolve the merge conflict anytime soon, I created this PR here to get the fix merged soon.
Ref: https://github.com/facebook/react-native/pull/27236
Thanks to [IgnorancePulls](https://github.com/IgnorancePulls)

## Changelog

[iOS] [Fixed] - Fix spinner visibility on beginRefreshingProgrammatically
Pull Request resolved: https://github.com/facebook/react-native/pull/27397

Test Plan:
IOS tests passed
Check whether this issue is reproduced or not for the repro which is described inside the issue.
https://github.com/facebook/react-native/issues/24855

Reviewed By: sammy-SC

Differential Revision: D18801307

Pulled By: hramos

fbshipit-source-id: d12af236778441a136dbe6b03dfd3495a465ae0f
 		2019-12-06 12:06:44 -08:00
..
RefreshControl Fix spinner is not shown on beginRefreshingProgrammatically on IOS (#27397) 2019-12-06 12:06:44 -08:00
SafeAreaView Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
ScrollView Tidy up license headers 2019-11-11 17:59:06 -08:00
RCTActivityIndicatorView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTActivityIndicatorView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTActivityIndicatorViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTActivityIndicatorViewManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTAnimationType.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTAutoInsetsProtocol.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTBorderDrawing.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTBorderDrawing.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTBorderStyle.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTComponent.h iOS: attach rootTag to the native component instance for easy access 2019-11-16 00:13:48 -08:00
RCTComponentData.h iOS: attach rootTag to the native component instance for easy access 2019-11-16 00:13:48 -08:00
RCTComponentData.m iOS: attach rootTag to the native component instance for easy access 2019-11-16 00:13:48 -08:00
RCTConvert+CoreLocation.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTConvert+CoreLocation.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTConvert+Transform.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTConvert+Transform.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTDatePicker.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTDatePicker.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTDatePickerManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTDatePickerManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTFont.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTFont.mm Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTLayout.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTLayout.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTMaskedView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTMaskedView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTMaskedViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTMaskedViewManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostViewController.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostViewController.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTModalHostViewManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTPicker.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTPicker.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTPickerManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTPickerManager.m Fix missing nullability in PickerManager.setNativeSelectedIndex 2019-11-19 10:22:24 -08:00
RCTPointerEvents.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTProgressViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTProgressViewManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTRootShadowView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTRootShadowView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSegmentedControl.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSegmentedControl.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSegmentedControlManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSegmentedControlManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView+Internal.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView+Internal.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView+Layout.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView+Layout.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTShadowView.m iOS: attach rootTag to the native component instance for easy access 2019-11-16 00:13:48 -08:00
RCTSlider.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSlider.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSliderManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSliderManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSwitch.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSwitch.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSwitchManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSwitchManager.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTTVView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTTVView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTTextDecorationLineType.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTView.m Make views tappable with screen reader 2019-11-19 07:54:16 -08:00
RCTViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTViewManager.m RN: Delete Apple TV Props 2019-11-01 08:49:26 -07:00
RCTWrapperViewController.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTWrapperViewController.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
UIView+Private.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
UIView+React.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
UIView+React.m iOS: attach rootTag to the native component instance for easy access 2019-11-16 00:13:48 -08:00