react-native-macos/Libraries/Text
Valentin Shergin e271fa190d Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes`
Summary:
This diff changes how we apply default text attributes to backed text input.
The original change in https://github.com/facebook/react-native/pull/23585 that introduced the `reactTextAttributes` field in for RCTBackedTextInputViewProtocol was great! Thank you Wu zhongwuzw !
However, there is one detail that needs to be changed.
RCTBackedTextInputViewProtocol is designed to only abstract complexity of iOS text input components (UITextView and UITextField); it intentionally does not have any React-specific fields or types. Adding a field `RCTTextAttributes *reactTextAttributes;` violates this principle and make it hard to reuse this functionality in the new Fabric-powered TextInput.

This diff changes the type of this prop from `RCTTextAttributes` to `NSDictionary<NSAttributedStringKey,id> *`  (exact same type that UITextView and UITextField use).

Reviewed By: cpojer

Differential Revision: D17408501

fbshipit-source-id: 65f2bba119ccc30f22e87c28d0f8ea6f731cd365
2019-09-17 09:20:54 -07:00
..
BaseText CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RawText CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
Text Make RCTAccessibilityManger a TurboModule 2019-08-23 12:01:52 -07:00
TextInput Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
VirtualText CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTConvert+Text.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTConvert+Text.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTTextAttributes.h Keep placeholder paragraph style same with text input (#23763) 2019-03-04 23:09:55 -08:00
RCTTextAttributes.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTTextTransform.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
React-RCTText.podspec Remove 's.static_framework = true' requirement for podspec (#25816) 2019-07-25 11:46:43 -07:00
Text.js Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) 2019-05-08 08:48:59 -07:00
TextAncestor.js Deploy v0.106.0 to xplat/js 2019-08-23 08:06:44 -07:00
TextProps.js Remove deprecated accessibilityStates property. (#26168) 2019-09-02 11:25:31 -07:00