f89ed90a1e
Summary: The onChange event for slider isn't necessary. Instead, it uses onValueChanged. ## What motivated this change? After D33933403, the SliderNativeComponent starts generating an onChange: true entry in its static ViewConfig's validAttributes map. **The Problem:** Slider inherits the onChange event from RCTViewManager. And in RCTViewManager, onChange is defined as an event that doesn't generate a ViewConfig validAttribute: 1. onChange is exported from [RCTViewManager customBubblingEventTypes](https://www.internalfb.com/code/fbsource/[210a214c9da7a847dd8840cae9f8341ed39a2ff6]/xplat/js/react-native-github/React/Views/RCTViewManager.m?lines=99%2C105%2C118) 2. Events exported from customBubblingEventTypes [don't insert into validAttributes](https://www.internalfb.com/code/fbsource/[8237815744b8cf7e38d9cf107a55c015f7b1545b]/xplat/js/react-native-github/React/Views/RCTComponentData.m?lines=393-398). To summarize: - onChange isn't used by slider - onChange generates an onChange: true entry in SVCs - onChange **doesn't** generate an onChange: true entry in NVC Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D34052662 fbshipit-source-id: 76bfd75c1ecbaa40d33e2b097b1f4458bf200ac2 |
||
|---|---|---|
| .. | ||
| __snapshots__ | ||
| Button-test.js | ||
| Slider-test.js | ||