A framework for building native macOS apps with React.
Перейти к файлу
Joshua Gross dd9fd2acac Fix dispatchDraw crash
Summary:
For over a month I've been searching for a crash that occurs during Android's native `dispatchDraw` method on View. The stack traces didn't show anything useful - everything in the stack trace was native Android code,
not React Native code.

This also seems to only repro on certain vendors, and only on a very few React Native screens - I'm still not sure why either of those are the case, but from my repro, a *very* specific set of interactions needs to happen
to trigger this crash. See comments inline and an example stack trace.

Luckily, the fix is trivial. Since this code is used for animations, accessibility, and a number of other important interactions, I'm gating this change for now.

In general we must be careful to only mutate the View hierarchy only when we /know/ for certain it is safe to do so. Indirectly mutating the View hierarchy during measure, onMeasure, layout, dispatchDraw, etc, can all be
very dangerous. This is one of the last "escape hatches" that can cause view hierarchy modifications unexpectedly, so I think it's a very good idea to "secure" this further, and only update props synchronously here - and
ensure that other MountItems like `Delete` are definitely /not/ executed here.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D24639793

fbshipit-source-id: b6219ce882e8d2204b4d10bf99f6a1120a33cb5a
2020-10-30 20:40:24 -07:00
.circleci Update Node version to >= 12 (#30252) 2020-10-29 07:40:36 -07:00
.github label-actions: Add canned response for upgrade issues 2020-04-14 15:34:44 -07:00
IntegrationTests RN: Remove `fbjs/requestAnimationFrame` Dependency 2020-08-25 14:15:35 -07:00
Libraries Allow image loaders to enable/disable image telemetry 2020-10-29 21:59:59 -07:00
React Fabric: Removing `RCTExperimentSetSyncPerformanceFlag` 2020-10-30 15:45:21 -07:00
ReactAndroid Fix dispatchDraw crash 2020-10-30 20:40:24 -07:00
ReactCommon Add new ReactMarkers for bridgeless mode [1/n] 2020-10-30 14:05:11 -07:00
bots Migrating RNTester to Packages Directory (#29567) 2020-08-19 17:57:08 -07:00
docs Generate doc info for RN components 2019-09-19 18:36:25 -07:00
flow RN: Remove `fbjs` Dependency 2020-08-28 12:16:26 -07:00
flow-typed/npm Remove license header from third-party code 2020-10-02 18:04:21 -07:00
gradle/wrapper Bump Gradle Wrapper to 6.7 (#30200) 2020-10-27 23:35:51 -07:00
jest Remove `fbjs-scripts` in favor of `@jest/create-cache-key-function` 2020-10-06 18:22:58 -07:00
keystores Use fb_native_wrapper for all targets 2018-10-31 11:47:42 -07:00
local-cli Update references to the CLI (#23052) 2019-01-21 09:13:08 -08:00
packages Codegen Android: update Docker configuration to support codegen (#30268) 2020-10-28 21:48:20 -07:00
repo-config Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00
scripts Update Node version to >= 12 (#30252) 2020-10-29 07:40:36 -07:00
template Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00
third-party-podspecs remove most of tvOS remnants from the code (#29407) 2020-09-28 21:26:41 -07:00
tools/build_defs Codegen BUCK: define codegen entrypoint under react-native-github/Libraries/ for core modules 2020-10-26 22:02:05 -07:00
.buckconfig Fix RNTester Path (#29786) 2020-09-01 18:47:08 -07:00
.buckjavaargs limiting BUCK's memory for CI 2016-02-01 10:49:33 -08:00
.clang-format Moving ObjC specific clang-format rules to the common config 2019-02-11 13:07:09 -08:00
.editorconfig https link to EditorConfig.org (#25267) 2019-06-18 01:58:07 -07:00
.eslintignore Lint: fix few "no-unused-var" warnings for imports (#30157) 2020-10-26 17:19:14 -07:00
.eslintrc Open source react-native-modules ESLint rule 2020-09-22 11:32:37 -07:00
.flowconfig Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00
.flowconfig.android Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00
.gitignore iOS: Generate FBReactNativeSpec ObjC++ files at build time 2020-10-21 20:47:09 -07:00
.nvmrc Add .nvmrc + fix node version for eslint 5 compat (#20109) 2018-07-31 02:34:16 -07:00
.prettierrc Update various Xplat Prettier configs to specify arrowParens: avoid 2020-09-14 18:36:20 -07:00
CODE_OF_CONDUCT.md Adopt Contributor Covenant 2019-08-29 23:21:10 -07:00
CONTRIBUTING.md Fix RNTester Path (#29786) 2020-09-01 18:47:08 -07:00
ECOSYSTEM.md docs: fix url for chainreactconf (#30199) 2020-10-19 07:35:37 -07:00
LICENSE Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
LICENSE-docs More licenses 2015-03-24 19:59:10 -07:00
README.md feat: migrate appveyor to circleci (#28245) 2020-03-30 07:24:57 -07:00
React-Core.podspec remove most of tvOS remnants from the code (#29407) 2020-09-28 21:26:41 -07:00
React.podspec remove most of tvOS remnants from the code (#29407) 2020-09-28 21:26:41 -07:00
Releases.md Fix typo in Releases.md (#20487) 2018-08-01 07:16:56 -07:00
build.gradle.kts bump Android Gradle Plugin to 4.1.0 (#30201) 2020-10-27 23:35:51 -07:00
cli.js Show full price instead of monthly price within the lead form 2019-03-28 16:07:19 -07:00
gradle.properties Android Gradle: remove configureondemand property 2020-09-03 19:13:00 -07:00
gradlew Update Gradle Wrapper to 6.6 (#29613) 2020-08-26 16:37:20 -07:00
gradlew.bat Update Gradle Wrapper to 6.6 (#29613) 2020-08-26 16:37:20 -07:00
index.js Sort index.js by alphabetical order and add category comments. (#30217) 2020-10-22 19:58:11 -07:00
interface.js Move `react-native-implementation.js` to `index.js` 2019-09-12 03:29:51 -07:00
jest-preset.js Create `@react-native/polyfills` package. 2020-07-22 03:02:45 -07:00
jest.config.js RN: Remove `fbjs` Dependency 2020-08-28 12:16:26 -07:00
metro.config.js Codegen Android: update Docker configuration to support codegen (#30268) 2020-10-28 21:48:20 -07:00
package.json Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00
react-native.config.js Migrating RNTester to Packages Directory (#29567) 2020-08-19 17:57:08 -07:00
react.gradle Fix App Bundle/Release build missing index.android.bundle with gradle plugin 4.1.0+/gradle 6.5 (#30177) 2020-10-26 16:06:33 -07:00
rn-get-polyfills.js Create `@react-native/polyfills` package. 2020-07-22 03:02:45 -07:00
runXcodeTests.sh Migrating RNTester to Packages Directory (#29567) 2020-08-19 17:57:08 -07:00
settings.gradle.kts Codegen Android: build react-native-codegen via yarn when building from source 2020-10-26 23:47:54 -07:00
template.config.js imp: Add titlePlaceholder in template.config.js (#26218) 2020-05-12 09:09:23 -07:00
yarn.lock Deploy Flow v0.137.0 2020-10-29 23:36:00 -07:00

README.md

React Native

Learn once, write anywhere:
Build mobile apps with React.

React Native is released under the MIT license. Current CircleCI build status. Current npm package version. PRs welcome! Follow @reactnative

Getting Started · Learn the Basics · Showcase · Contribute · Community · Support

React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.

  • Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
  • Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
  • Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
  • Portability. Reuse code across iOS, Android, and other platforms.

React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.

Contents

📋 Requirements

React Native apps may target iOS 10.0 and Android 4.1 (API 16) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.

🎉 Building your first React Native app

Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:

📖 Documentation

The full documentation for React Native can be found on our website.

The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.

The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.

🚀 Upgrading

Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.

React Native releases are discussed in the React Native Community, @react-native-community/react-native-releases.

👏 How to Contribute

The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.

Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.

Contributing Guide

Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.

Open Source Roadmap

You can learn more about our vision for React Native in the Roadmap.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Discussions

Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.

📄 License

React Native is MIT licensed, as found in the LICENSE file.

React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.