react-native-macos/local-cli
Shayne Sweeney ab61a1fbac Sanitize lineNumber in launchEditor
Summary:Shelling out on win32 does not properly escape the command due to c3bb4b1aa5/lib/child_

This patch ensures a proper lineNumber before continuing, similar to how we check that the fileName passed exists.

**Test plan**

On platform `win32` or given appropriate testing changes to `launchEditor.js`...

With the following `request-bad` file:
```
GET /open-stack-frame HTTP/1.1
Host: 127.0.0.1:8081
Proxy-Connection: keep-alive
Cache-Control: max-age=0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36
Accept-Encoding: gzip, deflate, sdch
Accept-Language: en-US,en;q=0.8
Content-Length: 64

{"file":"C:\\Windows\\system.ini","lineNumber":"123\" && calc"}
```

`$ nc localhost 8081 < request-bad`

Observe that before this patch `calc` would launch and afte
Closes https://github.com/facebook/react-native/pull/6299

Differential Revision: D3012074

Pulled By: davidaurelio

fb-gh-sync-id: cbc7b6e5c60529a289c0989a95593a322333ba5d
shipit-source-id: cbc7b6e5c60529a289c0989a95593a322333ba5d
2016-03-04 12:07:02 -08:00
..
__mocks__ Fix more tests 2015-09-16 13:05:30 -07:00
__tests__ Temporarily disable cli tests 2015-11-12 07:05:01 -08:00
bundle Add ability to load “unbundles” to android 2016-01-21 14:13:50 -08:00
dependencies Use same options on dependencies and bundle commands 2016-01-11 15:31:33 -08:00
generate Revert "Add folders to attempt to unblock sync" 2015-10-26 22:48:10 +00:00
generator Move `react` to peerDependencies 2016-02-09 15:38:37 -08:00
generator-android fix resources build variable name 2016-02-25 17:21:30 -08:00
generator-ios Create offline package if not running in "Debug" config 2016-02-24 03:11:38 -08:00
library Introduce react-native link 2015-10-27 11:22:28 -07:00
runAndroid Added a `root` option to the `run-android` command 2016-02-21 16:53:32 -08:00
runIOS Added `react-native run-ios` 2016-01-05 17:18:49 -08:00
server Sanitize lineNumber in launchEditor 2016-03-04 12:07:02 -08:00
upgrade Move `react` to peerDependencies 2016-02-09 15:38:37 -08:00
util Revert "Add folders to attempt to unblock sync" 2015-10-26 22:48:10 +00:00
cli.js chore: remove extra require 2016-01-17 18:17:39 -08:00
default.config.js More descriptive comment in default.config.js 2015-11-12 07:43:25 -08:00
generate-android.js Add license headers to local-cli 2015-10-20 09:55:21 -07:00
generator-utils.js Add license headers to local-cli 2015-10-20 09:55:21 -07:00
setup_env.bat Fix comments on .bat file 2015-10-28 21:36:07 -04:00
setup_env.sh Change ulimit to 2048 for non root Mac users 2016-02-06 11:45:37 -08:00
wrong-react-native.js Return non-zero exit code from wrong-react-native 2016-01-05 15:22:59 -08:00