Merge pull request #218 from AgneLukoseviciute/codeql

Codeql fix

package/CHANGELOG.json

@@ -1,6 +1,21 @@
 {
   "name": "react-native-xaml",
   "entries": [
+    {
+      "date": "Tue, 30 Aug 2022 00:15:16 GMT",
+      "tag": "react-native-xaml_v0.0.65",
+      "version": "0.0.65",
+      "comments": {
+        "patch": [
+          {
+            "author": "agnel@microsoft.com",
+            "package": "react-native-xaml",
+            "comment": "codeql_fix",
+            "commit": "be434b0a965f3ee881f159fe2c5fbdec6fc53108"
+          }
+        ]
+      }
+    },
     {
       "date": "Tue, 21 Jun 2022 18:27:36 GMT",
       "tag": "react-native-xaml_v0.0.64",

package/CHANGELOG.md

@@ -1,9 +1,17 @@
 # Change Log - react-native-xaml
 
-This log was last generated on Tue, 21 Jun 2022 18:27:36 GMT and should not be manually modified.
+This log was last generated on Tue, 30 Aug 2022 00:15:16 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 0.0.65
+
+Tue, 30 Aug 2022 00:15:16 GMT
+
+### Patches
+
+- codeql_fix (agnel@microsoft.com)
+
 ## 0.0.64
 
 Tue, 21 Jun 2022 18:27:36 GMT

package/Codegen/TypeCreator.cs

@@ -18,7 +18,7 @@ namespace Codegen
     /// Class to produce the template output
     /// </summary>
     
-    #line 1 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+    #line 1 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
     [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.TextTemplating", "16.0.0.0")]
     public partial class TypeCreator : TypeCreatorBase
     {
@@ -31,21 +31,21 @@ namespace Codegen
             this.Write("#include \"pch.h\"\r\n#include \"XamlMetadata.h\"\r\n#include \"Crc32Str.h\"\r\n#include <win" +
                     "string.h>\r\n\r\n");
             
-            #line 11 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 11 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
  foreach (var ns in Types.Select(x => x.GetNamespace()).Distinct()) { 
             
             #line default
             #line hidden
             this.Write("#include \"winrt/");
             
-            #line 12 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 12 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
             this.Write(this.ToStringHelper.ToStringWithCulture(ns));
             
             #line default
             #line hidden
             this.Write(".h\"\r\n");
             
-            #line 13 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 13 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
  } 
             
             #line default
@@ -57,7 +57,7 @@ THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT MODIFY MANUALLY
 
 winrt::Windows::Foundation::IInspectable XamlMetadata::Create(const std::string_view& typeName) const {
   wchar_t buf[128]{};
-  for (auto i = 0u; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
+  for (size_t i = 0; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
     buf[i] = static_cast<wchar_t>(typeName[i]);
   }
 
@@ -77,28 +77,28 @@ winrt::Windows::Foundation::IInspectable XamlMetadata::Create(const std::string_
     switch (key) {
 ");
             
-            #line 39 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 39 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
  foreach (var t in Types.Where(t => Util.GetComposableFactoryType(t) != null)) { 
             
             #line default
             #line hidden
             this.Write("        case COMPILE_TIME_CRC32_STR(\"");
             
-            #line 40 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 40 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
             this.Write(this.ToStringHelper.ToStringWithCulture(t.GetFullName()));
             
             #line default
             #line hidden
             this.Write("\"): { return ");
             
-            #line 40 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 40 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
             this.Write(this.ToStringHelper.ToStringWithCulture(Util.GetCppWinRTType(t)));
             
             #line default
             #line hidden
             this.Write("(); }\r\n");
             
-            #line 41 "F:\react-native-xaml\package\Codegen\TypeCreator.tt"
+            #line 41 "C:\repos\a-rnx\package\Codegen\TypeCreator.tt"
  } 
             
             #line default

package/Codegen/TypeCreator.tt

@@ -18,7 +18,7 @@ THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT MODIFY MANUALLY
 
 winrt::Windows::Foundation::IInspectable XamlMetadata::Create(const std::string_view& typeName) const {
   wchar_t buf[128]{};
-  for (auto i = 0u; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
+  for (size_t i = 0; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
     buf[i] = static_cast<wchar_t>(typeName[i]);
   }
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "react-native-xaml",
   "title": "React Native Xaml",
-  "version": "0.0.64",
+  "version": "0.0.65",
   "description": "Allows using XAML directly, inside of a React Native Windows app",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

package/windows/ReactNativeXaml/Codegen/TypeCreator.g.cpp

@@ -18,7 +18,7 @@ THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT MODIFY MANUALLY
 
 winrt::Windows::Foundation::IInspectable XamlMetadata::Create(const std::string_view& typeName) const {
   wchar_t buf[128]{};
-  for (auto i = 0u; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
+  for (size_t i = 0; i < typeName.size() && i < ARRAYSIZE(buf) - 1; i++) {
     buf[i] = static_cast<wchar_t>(typeName[i]);
   }
 

package/windows/ReactNativeXaml/Codegen/Version.g.h

@@ -7,4 +7,4 @@ THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT MODIFY MANUALLY
 #define VERSION_MAJOR               0
 #define VERSION_MINOR               0
 #define VERSION_REVISION            0
-#define VERSION_BUILD               64
+#define VERSION_BUILD               65