Fixes from PR feedback (#811)

* Move typescript to a dev dependency.

* Use regex test method instead of match.

* Change files

* Change files

change/@rnx-kit-golang-013af1d7-42b8-463b-8ec8-af32446b0e02.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Move typescript to a dev dependency.",
+  "packageName": "@rnx-kit/golang",
+  "email": "afoxman@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@rnx-kit-typescript-react-native-resolver-a858a87c-3709-410a-89a4-2828be62122a.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Use regex test method instead of match.",
+  "packageName": "@rnx-kit/typescript-react-native-resolver",
+  "email": "afoxman@microsoft.com",
+  "dependentChangeType": "patch"
+}

packages/golang/package.json

@@ -26,14 +26,14 @@
     "find-up": "^5.0.0",
     "got": "^11.8.2",
     "hasha": "^5.2.2",
-    "typescript": "^4.0.0",
     "workspace-tools": "^0.16.2"
   },
   "devDependencies": {
     "@rnx-kit/eslint-config": "^0.0.1",
     "@types/node": "^14.15.0",
     "eslint": "^8.0.0",
-    "prettier": "^2.0.0"
+    "prettier": "^2.0.0",
+    "typescript": "^4.0.0"
   },
   "eslintConfig": {
     "extends": "@rnx-kit/eslint-config"

packages/typescript-react-native-resolver/src/host.ts

@@ -130,8 +130,8 @@ export function resolveModuleName(
     module = resolveFileModule(context, moduleRef, searchDir, extensions);
   }
   if (module) {
-    module.isExternalLibraryImport = !!module.resolvedFileName.match(
-      /[/\\]node_modules[/\\]/
+    module.isExternalLibraryImport = /[/\\]node_modules[/\\]/.test(
+      module.resolvedFileName
     );
 
     const { host, options } = context;