fix(lazy-index): update error messages (#2638)

.changeset/funny-snakes-visit.md

@@ -0,0 +1,5 @@
+---
+"@rnx-kit/react-native-lazy-index": patch
+---
+
+Update error messages to reflect the latest changes

packages/react-native-lazy-index/src/experiences.js

@@ -34,12 +34,8 @@ function getFlightedModule(moduleId) {
  * @returns {Record<string, Component>}
  */
 function parseExperiences(experiences) {
-  if (!experiences) {
+  if (!experiences || typeof experiences !== "object") {
-    throw new Error("Missing `experiences` section in `package.json`");
+    throw new Error(`Invalid experiences map; got '${typeof experiences}'`);
-  }
-
-  if (typeof experiences !== "object") {
-    throw new Error("Invalid `experiences` section in `package.json`");
   }
 
   const flights = process.env["RN_LAZY_INDEX_FLIGHTS"]?.split(",");

packages/react-native-lazy-index/src/index.js

@@ -64,6 +64,14 @@ function readExperiencesFromManifest() {
   const manifest = fs.readFileSync(manifestPath, { encoding: "utf-8" });
   const { experiences } = JSON.parse(manifest);
 
+  if (!experiences) {
+    throw new Error("Missing `experiences` section in `package.json`");
+  }
+
+  if (typeof experiences !== "object") {
+    throw new Error("Invalid `experiences` section in `package.json`");
+  }
+
   return experiences;
 }
 

packages/react-native-lazy-index/test/experiences.test.ts

@@ -1,6 +1,4 @@
-import fs from "fs";
 import { getFlightedModule, parseExperiences } from "../src/experiences";
-import { resolveModule } from "../src/module";
 
 describe("parseExperiences()", () => {
   afterEach(() => {
@@ -8,24 +6,15 @@ describe("parseExperiences()", () => {
   });
 
   test("missing experiences section", () => {
-    const packageManifest = resolveModule("./package.json");
+    const result = () => parseExperiences(undefined);
-    const { experiences } = JSON.parse(
-      fs.readFileSync(packageManifest, "utf-8")
-    );
-    const result = () => {
-      parseExperiences(experiences);
-    };
     expect(result).toThrow(Error);
-    expect(result).toThrow("Missing `experiences` section in `package.json`");
+    expect(result).toThrow("Invalid experiences map; got 'undefined'");
   });
 
   test("invalid experiences section", () => {
-    const experiences = "MyAwesomeApp";
+    const result = () => parseExperiences("MyAwesomeApp");
-    const result = () => {
-      parseExperiences(experiences);
-    };
     expect(result).toThrow(Error);
-    expect(result).toThrow("Invalid `experiences` section in `package.json`");
+    expect(result).toThrow("Invalid experiences map; got 'string'");
   });
 
   test("object experiences section", () => {