chore: replace `@ts-ignore` with `@ts-expect-error` (#1711)

With `@ts-expect-error`, TypeScript will let you know if the comment is
no longer necessary.

See also
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-9.html#-ts-expect-error-comments

.changeset/grumpy-guests-compete.md

@@ -0,0 +1,2 @@
+---
+---

docsite/plugins/remark-include.js

@@ -95,8 +95,7 @@ function plugin() {
       }
     }
 
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore -- The visit() overloads are bound to UnistNode, but we use the expanded MdAstNode
+    // @ts-expect-error -- The visit() overloads are bound to UnistNode, but we use the expanded MdAstNode
     visit(root, isInclude, processIncludeDirective);
 
     // Replace all include comments with the included file's AST. Do this in

packages/babel-preset-metro-react-native/package.json

@@ -46,10 +46,7 @@
     ]
   },
   "eslintConfig": {
-    "extends": "@rnx-kit/eslint-config",
-    "rules": {
-      "@typescript-eslint/ban-ts-comment": "off"
-    }
+    "extends": "@rnx-kit/eslint-config"
   },
   "jest": {
     "roots": [

packages/cli/src/start.ts

@@ -159,8 +159,7 @@ export async function rnxStart(
 
   // merge the Metro config middleware with our middleware
   const enhanceMiddleware = metroConfig.server.enhanceMiddleware;
-  // eslint-disable-next-line
-  // @ts-ignore
+  // @ts-expect-error We want to assign to read-only `enhanceMiddleware`
   metroConfig.server.enhanceMiddleware = (
     metroMiddleware: Middleware,
     metroServer: Server

packages/jest-preset/package.json

@@ -52,10 +52,7 @@
     ]
   },
   "eslintConfig": {
-    "extends": "@rnx-kit/eslint-config",
-    "rules": {
-      "@typescript-eslint/ban-ts-comment": "off"
-    }
+    "extends": "@rnx-kit/eslint-config"
   },
   "jest": {
     "preset": "@rnx-kit/scripts"

packages/jest-preset/src/index.js

@@ -79,9 +79,9 @@ function getTargetPlatform(defaultPlatform) {
 
   /** @type {() => CLIConfig} */
   const loadConfig =
-    // @ts-ignore could not find a declaration file
+    // @ts-expect-error could not find a declaration file
     require("@react-native-community/cli").loadConfig ||
-    // @ts-ignore could not find a declaration file
+    // @ts-expect-error could not find a declaration file
     require("@react-native-community/cli/build/tools/config").default;
 
   const { platforms } = loadConfig();

packages/metro-config/src/index.js

@@ -153,13 +153,11 @@ function exclusionList(additionalExclusions = [], projectRoot = process.cwd()) {
   /** @type {(additionalExclusions: (string | RegExp)[]) => RegExp} */
   const exclusionList = (() => {
     try {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore There are no type definition files for `metro-config`
+      // @ts-expect-error There are no type definition files for `metro-config`
       return require("metro-config/src/defaults/exclusionList");
     } catch (_) {
       // `blacklist` was renamed to `exclusionList` in 0.60
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore There are no type definition files for `metro-config`
+      // @ts-expect-error There are no type definition files for `metro-config`
       return require("metro-config/src/defaults/blacklist");
     }
   })();
@@ -195,8 +193,7 @@ module.exports = {
    * @returns {MetroConfig}
    */
   makeMetroConfig: (customConfig = {}) => {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore There are no type definition files for `metro-config`
+    // @ts-expect-error There are no type definition files for `metro-config`
     const { mergeConfig } = require("metro-config");
     const { enhanceMiddleware } = require("./assetPluginForMonorepos");
 

packages/metro-service/src/config.ts

@@ -180,8 +180,7 @@ export function loadMetroConfig(
     defaultConfig.reporter = overrides.reporter;
   }
   if (overrides.assetPlugins) {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
+    // @ts-expect-error We want to assign to read-only `assetPlugins`
     defaultConfig.transformer.assetPlugins = assetPlugins;
   }
 

packages/typescript-service/src/project.ts

@@ -195,8 +195,7 @@ export class Project {
   dispose(): void {
     this.languageService.dispose();
 
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore `languageService` cannot be used after calling dispose
+    // @ts-expect-error `languageService` cannot be used after calling dispose
     this.languageService = null;
   }
 }

scripts/src/commands/updateApiReadme.js

@@ -171,8 +171,7 @@ function updateReadme(exportedTypes, exportedFunctions) {
   };
 
   /** @type {(table: string[][], options?: {}) => string} */
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-  // @ts-ignore
+  // @ts-expect-error
   const markdownTable = require("markdown-table");
 
   const types =