From b8a02ad37e32243008347a15da8004c3f425216a Mon Sep 17 00:00:00 2001
From: Oleksii Oleksenko <alexo_o@ukr.net>
Date: Sun, 4 Apr 2021 11:04:48 +0200
Subject: [PATCH] src/coverage: incremental pattern coverage

---
 .gitignore      |  2 +-
 src/coverage.py | 32 +++++++++++++++++++++++---------
 src/helpers.py  |  2 ++
 3 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index 1f8af87..d5a70d2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,5 +6,5 @@ venv/
 CMakeLists.txt
 src/instruction_sets/x86/base.xml
 tmp.pdf
-evaluation/resuts/
+evaluation/results/
 evaluation/bugs/
\ No newline at end of file
diff --git a/src/coverage.py b/src/coverage.py
index 088219c..cc11f80 100644
--- a/src/coverage.py
+++ b/src/coverage.py
@@ -7,7 +7,7 @@ SPDX-License-Identifier: MIT
 import re
 from enum import IntEnum
 from abc import ABC, abstractmethod
-from itertools import combinations
+from collections import defaultdict
 from math import factorial
 
 from generator import TestCaseDAG, Instruction, X86Registers, OT, InstructionSet
@@ -75,7 +75,7 @@ class Coverage(ABC):
 
 
 class PatternCoverage(Coverage):
-    coverage: Set[Tuple[int]]
+    coverage: Dict[int, Set[Tuple[int]]]
     current_patterns: List[PatternInstance]
     coverage_traces: List[List[Tuple[bool, int]]]
     positions_to_names: Dict[int, str]
@@ -83,14 +83,16 @@ class PatternCoverage(Coverage):
     combination_length: int = 1
     num_patterns: int = 8
     max_combinations_of_current_length: int = 8
+    rounds_without_change: int = 0
+    previous_target_coverage: int = 0
 
     def __init__(self):
         self.current_patterns = []
-        self.coverage = set()
+        self.coverage = defaultdict(set)
         self.positions_to_names = {}
 
     def get(self) -> int:
-        return len(self.coverage)
+        return sum([len(c) for c in self.coverage.values()])
 
     def generator_hook(self, DAG: TestCaseDAG, instruction_set: InstructionSet):
         # collect instruction positions
@@ -167,7 +169,7 @@ class PatternCoverage(Coverage):
     def load_test_case(self, asm_file: str):
         assemble(asm_file, 'tmp.o')
         output = run('objdump -D tmp.o -b binary --no-show-raw-insn -m i386:x86-64', shell=True,
-                     check=True,
+                     check=False,
                      capture_output=True)
         lines = output.stdout.decode().split("\n")
         addresses = {}
@@ -201,7 +203,8 @@ class PatternCoverage(Coverage):
         self.coverage_traces = effective_traces
 
     def update(self):
-        if not self.coverage_traces:
+        if not self.coverage_traces or not self.coverage_traces[0]:
+            self.rounds_without_change += 1
             self.current_patterns = []
             return
 
@@ -241,6 +244,7 @@ class PatternCoverage(Coverage):
                 if access_trace[i][1] == access_trace[i + 1][1]:
                     covered_with_matching_memory.add(access_trace[i][0])
 
+        # which of the patterns got covered
         for pattern in self.current_patterns:
             if pattern.dependency_type in [DT.CONTROL_COND, DT.CONTROL_DIRECT]:
                 pattern.covered = pattern.addresses[0] in covered_instr_addresses \
@@ -252,14 +256,24 @@ class PatternCoverage(Coverage):
             if pattern.dependency_type in [DT.MEM_LL, DT.MEM_SL, DT.MEM_LS, DT.MEM_SS]:
                 pattern.covered = pattern.addresses[0] in covered_with_matching_memory
 
+        # collect covered combinations
         covered_patterns = [int(p.dependency_type) for p in self.current_patterns if p.covered]
         covered_patterns = sorted(covered_patterns)
-        for c in combinations(covered_patterns, self.combination_length):
-            self.coverage.add(tuple(c))
-        STAT.coverage = len(self.coverage)
+        self.coverage[len(covered_patterns)].add(tuple(covered_patterns))
+
+        # save the result
+        new_target_coverage = len(self.coverage[self.combination_length])
+        if new_target_coverage == self.previous_target_coverage:
+            self.rounds_without_change += 1
+        else:
+            self.rounds_without_change = 0
+        self.previous_target_coverage = new_target_coverage
+        STAT.coverage = sum([len(c) for c in self.coverage.values()])
 
         # increase the combination length?
         if len(self.coverage) == self.max_combinations_of_current_length:
+            STAT.fully_covered = self.combination_length
+            print(f"\nCOV: Fully covered length {self.combination_length}")
             self.combination_length += 1
             n = self.num_patterns
             r = self.combination_length
diff --git a/src/helpers.py b/src/helpers.py
index b6ebf5c..64ea76b 100644
--- a/src/helpers.py
+++ b/src/helpers.py
@@ -91,6 +91,7 @@ class StatisticsCls:
     broken_measurements = 0
     violations = 0
     coverage = 0
+    fully_covered: int = 0
 
     def __str__(self):
         total_clss = self.effective_eq_classes + self.single_entry_eq_classes
@@ -100,6 +101,7 @@ class StatisticsCls:
         s += f"Inputs per test case: {self.num_inputs}\n"
         s += f"Coverage:\n"
         s += f"  Patterns: {self.coverage}\n"
+        s += f"  Fully covered: {self.fully_covered}\n"
         s += f"  Effectiveness: {self.effective_eq_classes / total_clss:.1f}\n"
         s += f"Effectiveness: \n"
         s += f"  Total Cls: {total_clss / self.test_cases:.1f}\n"