Add the recommended StyleCop component as a Roslyn analyzer.
This version of StyleCop has a couple of benefits over the msbuild
version:
- In addition to compile time checks, it will check for issues as you
type.
- This version is supported in .NET Core and Standard projects
- This version is being maintanied
This change attempted to preserve the existing rules for this project,
but there are some differences in behavior between the new and legacy
versions of StyleCop. I added the StyleCop Analyzer with the default
configuration and went through the list of violations. For rules that we
never followed, I added exceptions to GVFS.ruleset. For violations of
rules that looked like they should have been flagged, I went and made
code changes to fix the violation.
The custom ruleset (GVFS.ruleset) does not include any of the basic
rules for static code analysis. Statis code analysis had to be performed
manually, and does not apply to .NET Core or Standard projects. As these
rules appeared to not be widely used previously (we did not manually run
static code analysis), and does not apply to the newer version of the
framework, I decided to not keep them.
- We have improved how GVFS handles enlistments in junctions and mapped to a drive letter.
- We have started porting parts of the product to .NET Standard.
- Updated Git for a security issue.
- Better errors around ProjFS installation issues.
- Fix backoff on cache server size endpoint 404.
- GVFS has a better icon.
- Improved reliability of how the installer upgrades from non-inboxed to inboxed ProjFS.
- Better recovery from a process that terminates without releasing the GVFS lock.
- Gracefully handle a missing shared object cache pack directory.
Performance improvements:
- We have moved MIDX computation to a post-fetch thread. This should save blocking time per prefetch that downloads a packfile from the cache server.
- We have enabled the generation of the serialized commit graph in the post-fetch thread. This should provide across-the-board perf wins in any command that walks many commits.
- Improved the memory usage during MIDX computation.
- Further optimizations to GVFS's index parsing, saving time on commands that need to reproject (like checkout).
- Use commit graph generation numbers during force push, saving time on force pushes.
* Switched over to use the Windows Projected File System (ProjFS) optional feature on RS4 and later. ProjFS is the new name for the GvFlt driver and its associated user mode library.
* The local file size cache was migrated from ESENT to SQLite
* Git commands are now allowed to delete an empty directory
* Many other reliability improvements in interactions between GVFS and the file system, and between GVFS and git
Perf improvements:
* Better memory management in git, creating a savings of up to half a second on commands that parse the index
* Added a new mutli-pack index file to git, allowing it to become much more efficient at finding an object when there are a large number of local packfiles
* Added a git config setting to disable the calculations for detecting force pushes during 'git fetch' and 'git pull'. That calculation can take 10's of seconds on a large graph, and users can now opt out of it.
* Due to the transition to SQLite, the file sizes cache can now live in the volume-wide .gvfsCache folder and be shared by multiple repos, causing fewer round trips to the server while enumerating files
* The post-command step to update placeholder files now batches its size requests to the server, resulting in significant speedups in situations where many placeholder files needed to be updated
* The client will now also query the /gvfs/sizes endpoint on a cache server that implements that endpoint, reducing the latency on those requests even further
* Sped up GVFS's parsing of the git index, shaving off 2-3 seconds for a large index file
- Added a new volume-wide cache for downloaded git objects that is shared amongst multiple repos. Only newly created repos will use the new cache location. Existing clones will continue to use their own private cache.
- The installer now unmounts and remounts existing repos automatically
- GVFS no longer forces an antivirus exclusion. This was a relic from long ago when the gvflt driver and the Defender driver used to interfere with each other, but antivirus is no longer GVFS's concern.
- Added better diagnostic info in the GVFS logs when there are network errors
- `git status` now supports an option to avoid doing its ahead/behind calculations. This allows the user to decide if they want to skip that overhead if all they care about is the status of the working directory.
Bug fixes:
- Lots of bug fixes to make GVFS's file writes (e.g. to its database files) more reliable, even in the face of power loss
- GVFS can now recover from corrupted git object files (e.g. caused by a torn write), by re-downloading them whenever git asks for an object. The assumption is that git would not be asking GVFS for it if the object was valid.
- Fixed an annoying bug where a Ctrl+C'd git process could leak a GVFS lock
- Improved handling of IO timeouts
- Made it easier to discover and configure cache servers
- Improved reliability of GVFS.Service
- More repair options
- Many other perf and bug fixes
- Added a Windows service that performs automount after a reboot
- No more 'git.exe cat-file' background processes
- Downloaded Git objects are now written to a cache in the .gvfs folder
- Bug fixes and perf improvements
Jameson Miller
Nick Graczyk
Kevin Willford
Saeed Noursalehi