Code review changes.

src/snmalloc/backend_helpers/smallbuddyrange.h

@@ -155,12 +155,15 @@ namespace snmalloc
      */
     static void clear(Contents p)
     {
-#ifdef SNMALLOC_CLEAN_POINTERS
-      p->left = nullptr;
-      p->right = nullptr;
-#else
-      UNUSED(p);
-#endif
+      if constexpr (CLEAN_POINTERS)
+      {
+        p->left = nullptr;
+        p->right = nullptr;
+      }
+      else
+      {
+        UNUSED(p);
+      }
     }
   };
 

src/snmalloc/ds_core/defines.h

@@ -225,6 +225,12 @@ namespace snmalloc
 #else
   static constexpr bool CHECK_CLIENT = false;
 #endif
+
+#ifdef SNMALLOC_CLEAN_POINTERS
+  static constexpr bool CLEAN_POINTERS = true;
+#else
+  static constexpr bool CLEAN_POINTERS = false;
+#endif
 } // namespace snmalloc
 
 #ifdef SNMALLOC_CHECK_CLIENT

src/snmalloc/mem/freelist.h

@@ -192,12 +192,14 @@ namespace snmalloc
          */
         void cleanup()
         {
-#ifdef SNMALLOC_CLEAN_POINTERS
-          this->next_object = nullptr;
-#  ifdef SNMALLOC_CHECK_CLIENT
-          this->prev_encoded = 0;
-#  endif
-#endif
+          if constexpr (CLEAN_POINTERS)
+          {
+            this->next_object = nullptr;
+            if constexpr (CHECK_CLIENT)
+            {
+              this->prev_encoded = 0;
+            }
+          }
         }
       };