Make StackTraceDeminifier factory methods static.

This commit is contained in:
Christian Gonzalez 2016-11-15 17:57:55 -08:00
Родитель 64538ebc58
Коммит 75d74189d7
3 изменённых файлов: 5 добавлений и 7 удалений

Просмотреть файл

@ -5,7 +5,7 @@ namespace SourcemapToolkit.CallstackDeminifier
{
public class StackTraceDeminfierFactory
{
private void ValidateArguments(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
private static void ValidateArguments(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
{
if (sourceMapProvider == null)
{
@ -23,7 +23,7 @@ namespace SourcemapToolkit.CallstackDeminifier
/// </summary>
/// <param name="sourceMapProvider">Consumers of the API should implement this interface, which provides the source map for a given JavaScript file. Throws ArgumentNullException if the parameter is set to null.</param>
/// <param name="generatedCodeProvider">Consumers of the API should implement this interface, which provides the contents of a JavaScript file. Throws ArgumentNullException if the parameter is set to null.</param>
public StackTraceDeminifier GetStackTraceDeminfier(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
public static StackTraceDeminifier GetStackTraceDeminfier(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
{
ValidateArguments(sourceMapProvider, generatedCodeProvider);
@ -41,7 +41,7 @@ namespace SourcemapToolkit.CallstackDeminifier
/// </summary>
/// <param name="sourceMapProvider">Consumers of the API should implement this interface, which provides the source map for a given JavaScript file. Throws ArgumentNullException if the parameter is set to null.</param>
/// <param name="generatedCodeProvider">Consumers of the API should implement this interface, which provides the contents of a JavaScript file. Throws ArgumentNullException if the parameter is set to null.</param>
public StackTraceDeminifier GetMethodNameOnlyStackTraceDeminfier(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
public static StackTraceDeminifier GetMethodNameOnlyStackTraceDeminfier(ISourceMapProvider sourceMapProvider, ISourceCodeProvider generatedCodeProvider)
{
ValidateArguments(sourceMapProvider, generatedCodeProvider);

Просмотреть файл

@ -20,8 +20,7 @@ namespace SourcemapToolkit.CallstackDeminifier.UnitTests
ISourceCodeProvider sourceCodeProvider = MockRepository.GenerateStrictMock<ISourceCodeProvider>();
sourceCodeProvider.Stub(x => x.GetSourceCode("http://localhost:11323/crashcauser.js")).Return(UnitTestUtils.StreamReaderFromString(GeneratedCodeString));
StackTraceDeminfierFactory stackTraceDeminfierFactory = new StackTraceDeminfierFactory();
return stackTraceDeminfierFactory.GetStackTraceDeminfier(sourceMapProvider, sourceCodeProvider);
return StackTraceDeminfierFactory.GetStackTraceDeminfier(sourceMapProvider, sourceCodeProvider);
}
private void ValidateDeminifyStackTraceResults(DeminifyStackTraceResult results)

Просмотреть файл

@ -18,8 +18,7 @@ namespace SourcemapToolkit.CallstackDeminifier.UnitTests
ISourceCodeProvider sourceCodeProvider = MockRepository.GenerateStrictMock<ISourceCodeProvider>();
sourceCodeProvider.Stub(x => x.GetSourceCode("http://localhost:11323/crashcauser.min.js")).Return(UnitTestUtils.StreamReaderFromString(GeneratedCodeString));
StackTraceDeminfierFactory stackTraceDeminfierFactory = new StackTraceDeminfierFactory();
return stackTraceDeminfierFactory.GetStackTraceDeminfier(sourceMapProvider, sourceCodeProvider);
return StackTraceDeminfierFactory.GetStackTraceDeminfier(sourceMapProvider, sourceCodeProvider);
}
private static void ValidateDeminifyStackTraceResults(DeminifyStackTraceResult results)