Convert line and col numbers to one-indexed in ToString() (#77)

* Convert line and col numbers to one-indexed in ToString()

* Update unit tests
This commit is contained in:
Ian Craig 2019-08-21 14:02:23 -07:00 коммит произвёл Christian Gonzalez
Родитель 3fb57e94f5
Коммит bc6a883ce0
3 изменённых файлов: 9 добавлений и 9 удалений

Просмотреть файл

@ -30,7 +30,7 @@ namespace SourcemapToolkit.CallstackDeminifier
output += $" in {FilePath}";
if (SourcePosition != null)
{
output += $":{SourcePosition.ZeroBasedLineNumber}:{SourcePosition.ZeroBasedColumnNumber}";
output += $":{SourcePosition.ZeroBasedLineNumber + 1}:{SourcePosition.ZeroBasedColumnNumber + 1}";
}
}
return output;

Просмотреть файл

@ -127,12 +127,12 @@ window.onload/<@http://localhost:11323/crashcauser.min.js:1:445";
at Anonymous function (http://localhost:11323/crashcauser.min.js:1:445)";
DeminifyStackTraceResult results = stackTraceDeminifier.DeminifyStackTrace(ieStackTrace);
string exectedResult = @"TypeError: Unable to get property 'length' of undefined or null reference
at level3 in crashcauser.js:16:12
at level3 in crashcauser.js:14:9
at level2 in crashcauser.js:10:8
at level1 in crashcauser.js:5:8
at causeCrash in crashcauser.js:27:4
at window.onload in crashcauser.js:32:8";
at level3 in crashcauser.js:17:13
at level3 in crashcauser.js:15:10
at level2 in crashcauser.js:11:9
at level1 in crashcauser.js:6:9
at causeCrash in crashcauser.js:28:5
at window.onload in crashcauser.js:33:9";
// Act
string formatted = results.ToString();

Просмотреть файл

@ -47,8 +47,8 @@ namespace SourcemapToolkit.CallstackDeminifier.UnitTests
at t.onButtonClick (http://localhost:3000/js/bundle.ffe51781aee314a37903.min.js:1:3573)
at Object.sh (https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.8.6/umd/react-dom.production.min.js:164:410)";
string deminifiedStackTrace = @"TypeError: Cannot read property 'nonExistantmember' of undefined
at _this.onButtonClick in webpack:///./components/App.tsx:10:45
at Object.sh in https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.8.6/umd/react-dom.production.min.js:163:409";
at _this.onButtonClick in webpack:///./components/App.tsx:11:46
at Object.sh in https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.8.6/umd/react-dom.production.min.js:164:410";
// Act
DeminifyStackTraceResult results = stackTraceDeminifier.DeminifyStackTrace(chromeStackTrace);