Removing resolved TODO comments

subseasonal_toolkit/models/ecmwfpp/ecmwfpp.ipynb

@@ -228,7 +228,6 @@
     "    log_params(params_names, params_values)\n",
     "    \n",
     "# Select estimator based on loss\n",
-    "# TODO: do we want to do this? Or always use arithmatic mean? \n",
     "if loss == \"rmse\":\n",
     "    estimator = geometric_median \n",
     "elif loss == \"ssm\":\n",
@@ -260,7 +259,6 @@
     "    else:\n",
     "        raise ValueError(f\"Unknown gt_id {gt_id}\")\n",
     "    \n",
-    "    # TODO: should remove sync=False flags when we upload the data to azure \n",
     "    \"\"\"Load forecast and reforecast data.\"\"\"     \n",
     "    cols = [\"iri_ecmwf_\"+gt_id.split(\"_\")[1]+\"-{}.5d_shift{}\".format(col, base_shift) \n",
     "            for col in range(first_lead, last_lead+1)]  \n",
@@ -275,8 +273,6 @@
     "            sync=False)  \n",
     "        \n",
     "        # Undo-shifting of model_issuance_date so that it matches the start date\n",
-    "        # TODO: this is otherwise very hard to do via the shift_df funtion, but it \n",
-    "        # would be nice to have a better way of doing this\\\n",
     "        if \"reforecast\" in l:\n",
     "            try:\n",
     "                load_data[l]['model_issuance_date'] = load_data[l][f'model_issuance_date_shift{base_shift}'] \\\n",
@@ -397,7 +393,6 @@
     "\n",
     "# 3. LAST_REFORECAST_ISSUANCE_DATE := the issuance date associated with FIRST_EVALUATION_TARGET_DATE. \n",
     "# [Translation: this is FIRST_EVALUATION_TARGET_DATE minus the offset depending on the horizon]\n",
-    "### TODO: check that this is the correct delta\n",
     "LAST_REFORECAST_ISSUANCE_DATE = FIRST_EVALUATION_TARGET_DATE - base_shift_delta\n",
     "\n",
     "# print(f\"FIRST_FORECAST_TARGET_DATE is: {FIRST_FORECAST_TARGET_DATE}\")\n",
@@ -460,8 +455,6 @@
    "outputs": [],
    "source": [
     "# Compute debiasing correction\n",
-    "# TODO: need to deal with leap years\n",
-    "# TODO: don't need to compute debiasing for the entire dataframe;\n",
     "# should only compute bias for the dates in target dates\n",
     "printf('Compute debiasing correction (ground-truth - base prediction) by month-day combination')\n",
     "\n",