PR feedback

AnnotationsAndModifiers.md

@@ -1,8 +1,15 @@
 # Annotations and Modifiers
 
+## Convention
+
+Method/variable annotations and modifiers should go on the _same_ line as the rest of the definition. i.e.
+
+## Rationale
+
+Consistency makes PRs easier to read as well as removing any potential disagreements. 
+
 ## Annotations
 
-Method/variable annotations should go on the _same_ line as the rest of the definition. i.e.
 
 ```swift
 // good: On the same line
@@ -22,12 +29,23 @@ enum Thing: Int {
 }
 ```
 
-Regarding ordering, the rules defined by SwiftLint should be followed.
+The ordering for the annotations follows [that of SwiftLint](https://realm.github.io/SwiftLint/modifier_order.html). i.e. `@objc`, `@nonobjc`, `@objcMembers`, `@IBAction`, `@IBOutlet`, `@IBDesignable`, `IBInspectable`, `@NSManaged`, `@NSCopying`
+
 
 ## Modifiers
 
 Similarly, modifiers should go on the same line and follow SwiftLint conventions for order. e.g.
 
-```swift
-override open class func whatever() { }
-```
+Regarding the ordering of the annotations, we again follow SwiftLint. i.e. The order should be:
+
+* `override` - Specify if this is an override or not
+* Access level (e.g. `private`, `public`, `open`, etc.)
+* Setter access level
+* `dynamic` - Specify if dynamic dispatch should be used
+* Mutators - `mutating` or `nonmutating`
+* `lazy` - Specify if this declaration is lazy or not
+* `final` - Specify if this declaration is final
+* `required` - Specify if an initializer is required or not
+* `convenience` - Specify if a declaration as convenient or not
+* `static` - Specify if this is static or not <!-- Swiftlint refers to these as "type methods" but I can't think of any alternatives to static that would be left? -->
+* `weak` - Specify if the ownership is weak or not