From b21987e11f1d74129d02351bc983098706c8a554 Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Wed, 21 Feb 2024 15:48:10 -0700 Subject: [PATCH 1/5] fix typo --- .vscode/settings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index efbe74f..4546732 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -18,6 +18,6 @@ // Needs to be explicitly configured: https://github.com/Microsoft/azure-pipelines-vscode#document-formatting "[azure-pipelines]": { "editor.defaultFormatter": "esbenp.prettier-vscode", - "editor.formatOnSave": false // enable this when the conform + "editor.formatOnSave": false // enable this when they conform }, } From aa44aabb455656e0adf9d0e640fb6979e6277a2e Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Tue, 27 Feb 2024 18:02:25 -0700 Subject: [PATCH 2/5] Preserve more apiscan logs --- azure-pipelines/apiscan.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/azure-pipelines/apiscan.yml b/azure-pipelines/apiscan.yml index 554df0e..c3141d0 100644 --- a/azure-pipelines/apiscan.yml +++ b/azure-pipelines/apiscan.yml @@ -39,6 +39,7 @@ jobs: softwareVersionNum: $(NBGV_MajorMinorVersion) isLargeApp: false toolVersion: Latest + preserveLogsFolder: true env: AzureServicesAuthConnectionString: runAs=App;AppId=$(ApiScanClientId);TenantId=$(ApiScanTenant);AppKey=$(ApiScanSecret) From 36a27d828388373b91d424b196ebda381f9ef2cf Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Mon, 4 Mar 2024 14:15:17 -0700 Subject: [PATCH 3/5] Stop filtering out win-arm64 binaries from APIScan --- azure-pipelines/artifacts/APIScanInputs.ps1 | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/azure-pipelines/artifacts/APIScanInputs.ps1 b/azure-pipelines/artifacts/APIScanInputs.ps1 index 1555641..b1550bf 100644 --- a/azure-pipelines/artifacts/APIScanInputs.ps1 +++ b/azure-pipelines/artifacts/APIScanInputs.ps1 @@ -2,12 +2,10 @@ $inputs = & "$PSScriptRoot/symbols.ps1" if (!$inputs) { return } -# Filter out specific files that APIScan does not support. -# Specifically, APIScan doesn't support Windows ARM64 binaries, nor linux/OSX binaries. +# Filter out specific files that target OS's that are not subject to APIScan. +# Files that are subject but are not supported must be scanned and an SEL exception filed. $outputs = @{} $forbiddenSubPaths = @( - , 'arm64' - , 'win-arm64' , 'linux-*' , 'osx*' ) From 2a27d267d990d2a0a7078da1593de322bd051263 Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Mon, 4 Mar 2024 14:54:06 -0700 Subject: [PATCH 4/5] Document use case for nuspec file --- azure-pipelines/InsertionMetadataPackage.nuspec | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/azure-pipelines/InsertionMetadataPackage.nuspec b/azure-pipelines/InsertionMetadataPackage.nuspec index f7aa3e3..aae33f5 100644 --- a/azure-pipelines/InsertionMetadataPackage.nuspec +++ b/azure-pipelines/InsertionMetadataPackage.nuspec @@ -1,5 +1,6 @@ - + + LibraryName.VSInsertionMetadata $version$ From 7220c37ffe0189b2e831bdb9fc7b99dd1f28b13d Mon Sep 17 00:00:00 2001 From: Andrew Arnott Date: Fri, 15 Mar 2024 11:56:27 -0600 Subject: [PATCH 5/5] Fix validation pipeline --- azure-pipelines/vs-validation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/vs-validation.yml b/azure-pipelines/vs-validation.yml index 4d38579..ca2a7a6 100644 --- a/azure-pipelines/vs-validation.yml +++ b/azure-pipelines/vs-validation.yml @@ -41,7 +41,7 @@ extends: - template: /azure-pipelines/prepare-insertion-stages.yml@self parameters: ArchiveSymbols: false - RealSign: ${{ parameters.RealSign }} + RealSign: true - stage: insertion displayName: VS insertion