Don't await nps survey (#709)

src/extension.ts

@@ -71,7 +71,7 @@ export async function activateInternal(context: ExtensionContext, perfStats: { l
 			}
 		}));
 
-		await survey(context);
+		survey(context);
 	});
 
 	return Object.assign(ext.loginHelper.legacyApi, createApiProvider([ext.loginHelper.api]));

src/nps.ts

@@ -19,8 +19,8 @@ const LAST_SESSION_DATE_KEY = 'nps/lastSessionDate';
 const SKIP_VERSION_KEY = 'nps/skipVersion';
 const IS_CANDIDATE_KEY = 'nps/isCandidate';
 
-export async function survey({ globalState }: ExtensionContext): Promise<void> {
-	await callWithTelemetryAndErrorHandling('azure-account.nps.survey', async (context: IActionContext) => {
+export function survey({ globalState }: ExtensionContext): void {
+	void callWithTelemetryAndErrorHandling('azure-account.nps.survey', async (context: IActionContext) => {
 		if (env.language !== 'en' && !env.language.startsWith('en-')) {
 			return;
 		}