From 8a1278bde08d14a637b2128ff076712ce0491a56 Mon Sep 17 00:00:00 2001 From: Eric Jizba Date: Wed, 28 Nov 2018 14:54:55 -0800 Subject: [PATCH] Remove Python feature flag (#829) Also I'm not sure why Java didn't have "(Preview)" in it's description. It should since that's still in preview in Azure. --- README.md | 1 - package.json | 5 ----- package.nls.json | 1 - src/commands/createNewProject/createNewProject.ts | 10 ++++------ 4 files changed, 4 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 34a56ac4..80c0b3d3 100644 --- a/README.md +++ b/README.md @@ -130,7 +130,6 @@ See [here](https://github.com/Azure/azure-functions-core-tools/blob/master/READM ### Python * [Python 3.6.x](https://www.python.org/downloads/) -* To enable project creation and debugging, set `azureFunctions.enablePython` to true. **IMPORTANT**: Python support in Azure is still in private preview. ## Managing Azure Subscriptions diff --git a/package.json b/package.json index c30e07e7..c73a9149 100644 --- a/package.json +++ b/package.json @@ -673,11 +673,6 @@ "type": "string", "description": "%azFunc.preDeployTaskDescription%" }, - "azureFunctions.enablePython": { - "type": "boolean", - "description": "%azFunc.enablePythonDescription%", - "default": false - }, "azureFunctions.pythonVenv": { "scope": "resource", "type": "string", diff --git a/package.nls.json b/package.nls.json index 60ffec3f..65f5f5fd 100644 --- a/package.nls.json +++ b/package.nls.json @@ -52,7 +52,6 @@ "azFunc.projectRuntime.v2Description": "Azure Functions v2 (.NET Standard)", "azFunc.projectRuntime.betaDescription": "DEPRECATED Use \"~2\" instead.", "azFunc.projectLanguage.previewDescription": "(Preview)", - "azFunc.enablePythonDescription": "Enable Python support when creating new projects. Local support is in preview and deploying to Azure is in private preview.", "azFunc.pythonVenvDescription": "The name of the Python virtual environment used for your project. A virtual environment is required to debug and deploy Python functions.", "azFunc.enableSlotsDescription": "Enable preview support for slots." } diff --git a/src/commands/createNewProject/createNewProject.ts b/src/commands/createNewProject/createNewProject.ts index a47e8b68..c0b37948 100644 --- a/src/commands/createNewProject/createNewProject.ts +++ b/src/commands/createNewProject/createNewProject.ts @@ -11,7 +11,7 @@ import { ext } from '../../extensionVariables'; import { addLocalFuncTelemetry } from '../../funcCoreTools/getLocalFuncCoreToolsVersion'; import { validateFuncCoreToolsInstalled } from '../../funcCoreTools/validateFuncCoreToolsInstalled'; import { localize } from '../../localize'; -import { convertStringToRuntime, getFuncExtensionSetting, getGlobalFuncExtensionSetting } from '../../ProjectSettings'; +import { convertStringToRuntime, getGlobalFuncExtensionSetting } from '../../ProjectSettings'; import { gitUtils } from '../../utils/gitUtils'; import * as workspaceUtil from '../../utils/workspace'; import { createFunction } from '../createFunction/createFunction'; @@ -44,17 +44,15 @@ export async function createNewProject( language = getGlobalFuncExtensionSetting(projectLanguageSetting); if (!language) { + const previewDescription: string = localize('previewDescription', '(Preview)'); // Only display 'supported' languages that can be debugged in VS Code const languagePicks: QuickPickItem[] = [ { label: ProjectLanguage.JavaScript, description: '' }, { label: ProjectLanguage.CSharp, description: '' }, - { label: ProjectLanguage.Java, description: '' } + { label: ProjectLanguage.Python, description: previewDescription }, + { label: ProjectLanguage.Java, description: previewDescription } ]; - if (getFuncExtensionSetting('enablePython')) { - languagePicks.push({ label: ProjectLanguage.Python, description: '(Preview)' }); - } - const options: QuickPickOptions = { placeHolder: localize('azFunc.selectFuncTemplate', 'Select a language for your function project') }; language = (await ext.ui.showQuickPick(languagePicks, options)).label; }