From b1192af41498c298c2bf92ff11bbc162b70b543a Mon Sep 17 00:00:00 2001
From: Chris Wells <cwells@microsoft.com>
Date: Mon, 19 Mar 2018 10:19:27 -0700
Subject: [PATCH] Changes to the msbuild signing project to remove unwanted
 files (#622)

* Adding initial version of msbuild signing files

* Fixing msbuild syntax error

* Adding signing exclusion list

* Fixing errors in the signing exclusion list

* Hopefully last fix to signing exclusion list

* Including i18n loc folder into signing microbuild project

* MSBuild signing project changes to remove unwanted files
---
 msbuild/ChromeDebugAdapter.csproj | 32 +++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/msbuild/ChromeDebugAdapter.csproj b/msbuild/ChromeDebugAdapter.csproj
index ab4df1d..0a47093 100644
--- a/msbuild/ChromeDebugAdapter.csproj
+++ b/msbuild/ChromeDebugAdapter.csproj
@@ -12,7 +12,7 @@
     <RootFilesToCopy Include="..\.gitignore;..\.travis.yml;..\appveyor.yml;..\ISSUE_TEMPLATE.md;..\CHANGELOG.md;..\CONTRIBUTING.md;..\LICENSE.txt;..\package.json;..\package.nls.de.json;..\package.nls.es.json;..\package.nls.fr.json;..\package.nls.it.json;..\package.nls.ja.json;..\package.nls.json;..\package.nls.ko.json;..\package.nls.ru.json;..\package.nls.zh-cn.json;..\package.nls.zh-tw.json;..\README.md;..\ThirdPartyNotices.txt" />
   </ItemGroup>
 
-  <Target Name="CopyFilesToSign" BeforeTargets="GetFilesToSign">
+  <Target Name="CopyFilesToSign" BeforeTargets="DeleteUnwantedFiles">
     <Copy SourceFiles="@(LocFilesToCopy)"
           DestinationFiles="@(LocFilesToCopy->'$(OutDir)\i18n\%(RecursiveDir)%(Filename)%(Extension)')" />
     <Copy SourceFiles="@(ImagesToCopy)"
@@ -25,18 +25,26 @@
           DestinationFolder="$(OutDir)" />
   </Target>
 
-  <Target Name="GetFilesToSign" DependsOnTargets="CopyFilesToSign" BeforeTargets="SignFiles">
+  <Target Name="DeleteUnwantedFiles" DependsOnTargets="CopyFilesToSign" BeforeTargets="GetFilesToSign">
+    <Delete Files="$(OutDir)ChromeDebugAdapter.dll;
+                   $(OutDir)ChromeDebugAdapter.pdb;
+                   $(OutDir)ChromeDebugAdapter.deps.json;
+                   $(OutDir)node_modules\gulp-vinyl-zip\test\assets\archive.zip;
+                   $(OutDir)node_modules\globule\test\fixtures\expand\js\foo.js;
+                   $(OutDir)node_modules\globule\test\fixtures\expand\js\bar.js;
+                   $(OutDir)node_modules\resolve\test\resolver\mug.js;
+                   $(OutDir)node_modules\resolve\test\pathfilter\deep_ref\main.js;
+                   $(OutDir)node_modules\resolve\test\resolver\baz\doom.js;
+                   $(OutDir)node_modules\vsce\node_modules\tmp\test\symlinkme\file.js;
+                   $(OutDir)node_modules\resolve\test\resolver\other_path\lib\other-lib.js;
+                   $(OutDir)node_modules\resolve\test\resolver\other_path\root.js;
+                   $(OutDir)node_modules\union\test\fixtures\index.js;
+                   $(OutDir)node_modules\union\test\helpers\index.js;"/>
+  </Target>
+
+  <Target Name="GetFilesToSign" DependsOnTargets="DeleteUnwantedFiles" BeforeTargets="SignFiles">
     <ItemGroup>
-      <FilesToSign Include="$(OutDir)\**\*.js" Exclude="$(OutDir)\node_modules\globule\test\fixtures\expand\js\foo.js;
-                                                        $(OutDir)\node_modules\globule\test\fixtures\expand\js\bar.js;
-                                                        $(OutDir)\node_modules\resolve\test\resolver\mug.js;
-                                                        $(OutDir)\node_modules\resolve\test\pathfilter\deep_ref\main.js;
-                                                        $(OutDir)\node_modules\resolve\test\resolver\baz\doom.js;
-                                                        $(OutDir)\node_modules\vsce\node_modules\tmp\test\symlinkme\file.js;
-                                                        $(OutDir)\node_modules\resolve\test\resolver\other_path\lib\other-lib.js;
-                                                        $(OutDir)\node_modules\resolve\test\resolver\other_path\root.js;
-                                                        $(OutDir)\node_modules\union\test\fixtures\index.js;
-                                                        $(OutDir)\node_modules\union\test\helpers\index.js;">
+      <FilesToSign Include="$(OutDir)\**\*.js">
         <Authenticode>Microsoft400</Authenticode>
       </FilesToSign>
     </ItemGroup>