* fix
* analyze user presets first because it's the base if it exists
* more updates to fix include files and telemetry, still needs work and testing
* ensure telemetry and other uses of 'all..Presets' is right
* more fixes
* ensure we don't duplicate cmakepresets in userpresets includes
* remove unnecessary return
* unionWith consistency
* add test
Fixes#3854. Support for watching multiple paths (cmakepresets.json/cmakeuserpresets.json/include files) was broken due to a Chokidar bug. Created a wrapper class to handle this scenario.
* try to convert release pipeline to yaml
* ensure trigger
* fix variable expansion
* specify name specifically
* add release and fix powershell setup
* fix name
* uncomment vsce task
* only do release pipeline on release branch
* only allow rel branch for release
* enable trigger always, we can rely on manual verification
* Making configure precondition handler return a boolean helps to differentiate the successful recovery cases
* Fix pre-condition handler prototype errors in tests
* Experiment with prototypes to fix linter errors
* Add setting for building whole build dir when clean configure
* Remove anything related to deleteBuildDirOnCleanConfigure since it's in a different PR. Keep proper promise<bool> prototype for pre-configure handler return and fix appropriately compilation and lint errors in tests.
* Forgot one file to remove deleteBuildDirOnCleanConfigure from
* Remove forgotten comment
* Add changelog entry
* remove changes not needed
* removing more bad changes
* add logic to regenerate the driver after selecting cmakelists
* remove unused imports
* keep sanity check in _beforeConfigureOrBuild
* only ensure we set the variable so that on retry, it works
* switch return
* erroneous update
* fix
---------
Co-authored-by: Garrett Campbell <gcampbell@microsoft.com>
Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
* Fix GitHub 1401, diagnostics relative to workspace folder
- relative diagnostics files are searched in build_dir and src_dir,
first existing file is returned
- defaults to old behavior : `path.resolve(build_dir, file)`
- `resolveDiagnostics` has been made async to not slow down IDE when
testing files
* update ChangeLog for #1401
* fix relative file resolution diagnostics test
- diagnostics paths always use POSIX separators (see `normalizePath` in
[src/util.ts](src/util.ts))
---------
Co-authored-by: Sylvain Fargier <sylvain.fargier@cern.ch>
Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
This change changes the way we do preset file expansion. Expansion now occurs upfront on file open or save, and if there are no errors, the expanded presets will be cached so repeated expansion is not necessary every time getAll{type of preset}Presets() is called.
The only time expansion will happen again is on set preset, which will then also apply the VS developer environment as needed. This is avoided on the initial expansion for performance.
If there are errors in expansion, the errors are shown in the problems panel per file. The presets file will also be set to undefined, which will invalidate that file and not allow any presets in that file to be recognized/selected as valid presets. This is in line with the CMake command line experience.
Some notes:
- The ${generator} macro should not work for packagePresets, but should now expand correctly for all other presets and evaluate conditions correctly
- Tertiary preset cache was added (really its just the original presets cache but used in a new way) to account for included json files that wouldnt be in the original presets files
[kit] Found Kit (trusted): Clang 17.0.3 (MSVC CLI) for MSVC 17.10.35004.147 (Visual Studio Community 2022 Release - x86)
[kit] Found Kit (trusted): Clang 17.0.3 (GNU CLI) for MSVC 17.10.35004.147 (Visual Studio Community 2022 Release - x86)
[kit] Found Kit (trusted): Clang 17.0.3 (MSVC CLI) for MSVC 17.10.35004.147 (Visual Studio Community 2022 Release - amd64)
[kit] Found Kit (trusted): Clang 17.0.3 (GNU CLI) for MSVC 17.10.35004.147 (Visual Studio Community 2022 Release - amd64)
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
* committing state, no progress, just thinking through
* fix how we apply and override devenv to ensure we don't accidentally delete preset environment modifications from user
* check if ninja exists and it's the generator, use that to determine if we should add vs devenv as well
* currently broken, but saving state for adding a setting
* this works well, but I need to add back code that prohibits repeated devenv searching with where.exe
* finalize implementation of the setting for useVsDeveloperEnvironment
* minimize branches
* fix import
* update comments
* fix comment
* remove unnecessary comment
* fallback to better architecture/toolset
* update devenv vars and tests
* fix test for mac
* fix tests
* update changelog
* fix test expand and where.exe env
* update test to explicitly test architecture unit test
---------
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
* if installDir is a relative path, I calculate it relative to the source dir
* updated location of checking and updating installDir
* combined with expansion check
Garrett Campbell
Sinem Akinci
CSIGS@microsoft.com
Garrett Campbell
Sean McManus
Fatima Qarni
moyo1997
Andreea Isac
fargies
Jonathan Phippen
Andrew Shark
stepeos
Yonggang Luo
snehara99