Improve pwa-chrome configuration settings for cordova-android (#924)

* Support cordova webview asset loader

* Update
This commit is contained in:
Ezio Li 2023-11-22 10:10:59 +08:00 коммит произвёл GitHub
Родитель 2308ee867a
Коммит a00eb70230
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
6 изменённых файлов: 166 добавлений и 19 удалений

97
package-lock.json сгенерированный
Просмотреть файл

@ -25,7 +25,8 @@
"vscode-js-debug-browsers": "^1.0.4",
"vscode-nls": "^4.1.2",
"winreg": "0.0.13",
"xcode": "^3.0.1"
"xcode": "^3.0.1",
"xml2js": "^0.6.2"
},
"devDependencies": {
"@types/elementtree": "^0.1.0",
@ -1956,6 +1957,28 @@
"node": ">=4"
}
},
"node_modules/@vscode/vsce/node_modules/xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"dependencies": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
},
"engines": {
"node": ">=4.0.0"
}
},
"node_modules/@vscode/vsce/node_modules/xmlbuilder": {
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true,
"engines": {
"node": ">=4.0"
}
},
"node_modules/@webassemblyjs/ast": {
"version": "1.11.1",
"resolved": "https://registry.npmjs.org/@webassemblyjs/ast/-/ast-1.11.1.tgz",
@ -15620,6 +15643,28 @@
"url": "https://github.com/chalk/wrap-ansi?sponsor=1"
}
},
"node_modules/vscode-nls-dev/node_modules/xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"dependencies": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
},
"engines": {
"node": ">=4.0.0"
}
},
"node_modules/vscode-nls-dev/node_modules/xmlbuilder": {
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true,
"engines": {
"node": ">=4.0"
}
},
"node_modules/vscode-nls-dev/node_modules/y18n": {
"version": "5.0.8",
"resolved": "https://registry.npmjs.org/y18n/-/y18n-5.0.8.tgz",
@ -16029,10 +16074,9 @@
"dev": true
},
"node_modules/xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"version": "0.6.2",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.6.2.tgz",
"integrity": "sha512-T4rieHaC1EXcES0Kxxj4JWgaUQHDk+qwHcYOCFHfiwKz7tOVPLq7Hjq9dM1WCMhylqMEfP7hMcOIChvotiZegA==",
"dependencies": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
@ -16045,7 +16089,6 @@
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true,
"engines": {
"node": ">=4.0"
}
@ -17632,6 +17675,22 @@
"requires": {
"has-flag": "^3.0.0"
}
},
"xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"requires": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
}
},
"xmlbuilder": {
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true
}
}
},
@ -28383,6 +28442,22 @@
"strip-ansi": "^6.0.0"
}
},
"xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"requires": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
}
},
"xmlbuilder": {
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true
},
"y18n": {
"version": "5.0.8",
"resolved": "https://registry.npmjs.org/y18n/-/y18n-5.0.8.tgz",
@ -28684,10 +28759,9 @@
"dev": true
},
"xml2js": {
"version": "0.5.0",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.5.0.tgz",
"integrity": "sha512-drPFnkQJik/O+uPKpqSgr22mpuFHqKdbS835iAQrUC73L2F5WkboIRd63ai/2Yg6I1jzifPFKH2NTK+cfglkIA==",
"dev": true,
"version": "0.6.2",
"resolved": "https://registry.npmjs.org/xml2js/-/xml2js-0.6.2.tgz",
"integrity": "sha512-T4rieHaC1EXcES0Kxxj4JWgaUQHDk+qwHcYOCFHfiwKz7tOVPLq7Hjq9dM1WCMhylqMEfP7hMcOIChvotiZegA==",
"requires": {
"sax": ">=0.6.0",
"xmlbuilder": "~11.0.0"
@ -28696,8 +28770,7 @@
"xmlbuilder": {
"version": "11.0.1",
"resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-11.0.1.tgz",
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA==",
"dev": true
"integrity": "sha512-fDlsI/kFEx7gLvbecc0/ohLG50fugQp8ryHzMTuW9vSa1GJ0XYWKnhsUx7oie3G98+r56aTQIUB4kht42R3JvA=="
}
}
},

Просмотреть файл

@ -680,7 +680,8 @@
"vscode-js-debug-browsers": "^1.0.4",
"vscode-nls": "^4.1.2",
"winreg": "0.0.13",
"xcode": "^3.0.1"
"xcode": "^3.0.1",
"xml2js": "^0.6.2"
},
"devDependencies": {
"@types/elementtree": "^0.1.0",

Просмотреть файл

@ -2485,3 +2485,29 @@ For more information, please refer to <http://unlicense.org/>
---------------------------------------------------------
---------------------------------------------------------
node-xml2js 0.6.2 - MIT
https://github.com/Leonidas-from-XIV/node-xml2js
Copyright 2010, 2011, 2012, 2013. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal in the Software without restriction, including without limitation the
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.
---------------------------------------------------------

Просмотреть файл

@ -0,0 +1,22 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for details.
import { ConfigurationReader } from "./configurationReader";
export class ConfigurationHelper {
public static getAndroidInsecureFileModeStatus(xmlContent: any): boolean {
const jsonContent = ConfigurationReader.parseXmlToJson(xmlContent);
const preferenceList = jsonContent.widget.preference ? jsonContent.widget.preference : null;
if (preferenceList) {
for (let i = 0; i < preferenceList.length; i++) {
const preference = JSON.stringify(preferenceList[i]);
if (preference.includes("AndroidInsecureFileModeEnabled")) {
return !!preference.includes("false");
}
return true;
}
}
return true;
}
}

Просмотреть файл

@ -4,6 +4,8 @@
import { InternalErrorCode } from "./error/internalErrorCode";
import { ErrorHelper } from "./error/errorHelper";
const parseString = require("xml2js").parseString;
export class ConfigurationReader {
public static readArray(value: any): Array<any> {
if (this.isArray(value)) {
@ -15,4 +17,13 @@ export class ConfigurationReader {
private static isArray(value: any): boolean {
return Array.isArray(value);
}
public static parseXmlToJson(value: any): any {
let jsonContent;
parseString(value, function (err, result) {
jsonContent = result;
});
return jsonContent;
}
}

Просмотреть файл

@ -1,9 +1,12 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for details.
import { logger } from "@vscode/debugadapter";
import * as fs from "fs";
import * as path from "path";
import * as nls from "vscode-nls";
import { logger } from "@vscode/debugadapter";
import { CordovaProjectHelper } from "../utils/cordovaProjectHelper";
import { ConfigurationHelper } from "../common/configurationHelper";
import { ICordovaAttachRequestArgs } from "./requestArgs";
nls.config({
@ -42,11 +45,22 @@ export class JsDebugConfigAdapter {
): any {
const extraArgs: any = {};
if (!attachArgs.simulatePort) {
extraArgs.pathMapping = {
"/android_asset/www": `${attachArgs.cwd}/www`,
};
extraArgs.url = "file:///";
extraArgs.urlFilter = "*";
const xmlContent = fs.readFileSync(path.join(attachArgs.cwd, "config.xml"), "utf-8");
const isWebviewLoader =
ConfigurationHelper.getAndroidInsecureFileModeStatus(xmlContent);
if (isWebviewLoader) {
extraArgs.pathMapping = {
"localhost/**": `${attachArgs.cwd}/**`,
};
extraArgs.url = "https://";
extraArgs.urlFilter = "*";
} else {
extraArgs.pathMapping = {
"android_asset/www": `${attachArgs.cwd}/www`,
};
extraArgs.url = "file:///";
extraArgs.urlFilter = "*";
}
}
return Object.assign({}, this.getExistingExtraArgs(attachArgs), extraArgs, {