.npmignore

2019-04-10 15:07:51 -07:00 · 2019-04-10 15:07:51 -07:00 · d6074236d6
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -104,8 +104,8 @@ If you want to create a new definition:
          📄 devcontainer.json
          📄 Dockerfile (optional)
          📄 docker-compose.yml (optional)
-          📄 ignore
       📁 test-project (optional)
+       📄 .npmignore
       📄 README.md
    ```

@ -113,7 +113,7 @@ If you want to create a new definition:
    
    Note that any additional assets can be included as needed, but keep in mind that these will overlay on top of an existing project. Keeping these files in the `.devcontainer` should reduce the chances of something conflicting but note that any command that are run are relative to the root of the project, so you'll need to include `.devcontainer` in any path references.
    
-    Anything you don't want added to a project should be referenced in [glob](https://facelessuser.github.io/wcmatch/glob/) form in `.devcontainer/ignore` with paths relative to the root of the folder. Create a `README.md` in the folder with a brief description of the purpose of the container definition and any manual steps required to use it.
+    Anything you don't want added to a project should be referenced in [glob](https://facelessuser.github.io/wcmatch/glob/) form in `.npmignore` with paths relative to the root of the folder. Create a `README.md` in the folder with a brief description of the purpose of the container definition and any manual steps required to use it.

 4. Commit your changes and submit a PR - we'll take a look at it, provide any needed feedback, and then merge it in! We appreciate any and all feedback!!

--- a/container-templates/docker-compose/.devcontainer/devcontainer.json
+++ b/container-templates/docker-compose/.devcontainer/devcontainer.json
@ -1,8 +1,8 @@
 {
 	"name": "Dev Container Definition Template - Docker Compose",
-    "dockerComposeFile": "../.devcontainer/docker-compose.yml",
+    "dockerComposeFile": ".devcontainer/docker-compose.yml",
    "service": "your-service-name-here",
-    "volume": "app",
+    "workspaceFolder": "/workspace",
 	"extensions": [
 		"mutantdino.resourcemonitor"
    ]
--- a/container-templates/docker-compose/.devcontainer/docker-compose.yml
+++ b/container-templates/docker-compose/.devcontainer/docker-compose.yml
@ -14,7 +14,7 @@ services:
     - "3000:3000"  # Application port to forward
     
     volumes:
-      - .:/app  # This is where VS Code should expect to find your project's source code, value of "volume" in .vscode/devContainer.json
+      - ..:/workspace  # This is where VS Code should expect to find your project's source code, value of "volume" in .vscode/devContainer.json

    command: sleep infinity  # This prevents the container from shutting down if you stop your application

--- a/container-templates/docker-compose/.npmignore
+++ b/container-templates/docker-compose/.npmignore
@ -1,3 +1,4 @@
 README.md
 test-project
 .vscode
+.npmignore
--- a/container-templates/docker-compose/README.md
+++ b/container-templates/docker-compose/README.md
@ -26,5 +26,5 @@

 Copyright (c) Microsoft Corporation. All rights reserved.

-Licensed under the MIT License. See [LICENSE](../../LICENSE). 
+Licensed under the MIT License. See [LICENSE](../../LICENSE).

--- a/container-templates/dockerfile/.devcontainer/devcontainer.json
+++ b/container-templates/dockerfile/.devcontainer/devcontainer.json
@ -1,6 +1,6 @@
 {
 	"name": "Dev Container Definition Template - Dockerfile",
-	"dockerFile": "../.devcontainer/Dockerfile",
+	"dockerFile": ".devcontainer/Dockerfile",
 	"appPort": 3000,
 	"extensions": [
 		"mutantdino.resourcemonitor"
--- a/container-templates/dockerfile/.devcontainer/ignore
+++ b/container-templates/dockerfile/.devcontainer/ignore
@ -1,6 +0,0 @@
-README.md
-test-project
-.vscode/launch.json
-.vscode/launch.test.json
-.vscode/settings.json
-.vscode/tasks.json
--- a/containers/azure-functions-node-8/.devcontainer/ignore
+++ b/containers/azure-functions-node-8/.devcontainer/ignore
@ -1,3 +1,4 @@
 README.md
 test-project
 .vscode
+.npmignore
--- a/container-templates/image/.devcontainer/devcontainer.json
+++ b/container-templates/image/.devcontainer/devcontainer.json
--- a/container-templates/image/.devcontainer/ignore
+++ b/container-templates/image/.devcontainer/ignore
@ -1,6 +0,0 @@
-../README.md
-../test-project
-../.vscode/launch.json
-../.vscode/launch.test.json
-../.vscode/settings.json
-../.vscode/tasks.json
--- a/container-templates/docker-compose/.devcontainer/ignore
+++ b/container-templates/docker-compose/.devcontainer/ignore
--- a/containers/.npmignore
+++ b/containers/.npmignore
@ -1,5 +1,2 @@
 .npmignore
-.vscode
-test-project
-ignore
 README.md
--- a/containers/azure-hdinsight-python-3/.devcontainer/ignore
+++ b/containers/azure-hdinsight-python-3/.devcontainer/ignore
@ -1,3 +1,4 @@
 README.md
 test-project
 .vscode
+.npmignore
--- a/containers/azure-machine-learning-python-3/.devcontainer/ignore
+++ b/containers/azure-machine-learning-python-3/.devcontainer/ignore
@ -1,3 +1,4 @@
 README.md
 test-project
 .vscode
+.npmignore
--- a/containers/azure-hdinsight-python-3/.npmignore
+++ b/containers/azure-hdinsight-python-3/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/azure-machine-learning-python-3/.npmignore
+++ b/containers/azure-machine-learning-python-3/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/azure-terraform/.devcontainer/ignore
+++ b/containers/azure-terraform/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/azure-terraform/.npmignore
+++ b/containers/azure-terraform/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/cpp/.devcontainer/ignore
+++ b/containers/cpp/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/cpp/.npmignore
+++ b/containers/cpp/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/dart-web/.devcontainer/ignore
+++ b/containers/dart-web/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/dart-web/.npmignore
+++ b/containers/dart-web/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/docker-existing-docker-compose/.devcontainer/ignore
+++ b/containers/docker-existing-docker-compose/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/docker-existing-docker-compose/.npmignore
+++ b/containers/docker-existing-docker-compose/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/docker-existing-dockerfile/.devcontainer/ignore
+++ b/containers/docker-existing-dockerfile/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/docker-existing-dockerfile/.npmignore
+++ b/containers/docker-existing-dockerfile/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/docker-in-docker-compose/.devcontainer/ignore
+++ b/containers/docker-in-docker-compose/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/docker-in-docker-compose/.npmignore
+++ b/containers/docker-in-docker-compose/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/docker-in-docker/.devcontainer/ignore
+++ b/containers/docker-in-docker/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/docker-in-docker/.npmignore
+++ b/containers/docker-in-docker/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/dotnetcore-2.2-fsharp/.devcontainer/ignore
+++ b/containers/dotnetcore-2.2-fsharp/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/dotnetcore-2.2-fsharp/.npmignore
+++ b/containers/dotnetcore-2.2-fsharp/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/dotnetcore-2.2/.devcontainer/ignore
+++ b/containers/dotnetcore-2.2/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/dotnetcore-2.2/.npmignore
+++ b/containers/dotnetcore-2.2/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/go/.devcontainer/ignore
+++ b/containers/go/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/go/.npmignore
+++ b/containers/go/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/java-8-maven/.devcontainer/ignore
+++ b/containers/java-8-maven/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/java-8-maven/.npmignore
+++ b/containers/java-8-maven/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/javascript-node-8-mongo/.devcontainer/ignore
+++ b/containers/javascript-node-8-mongo/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/javascript-node-8-mongo/.npmignore
+++ b/containers/javascript-node-8-mongo/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/javascript-node-8/.devcontainer/ignore
+++ b/containers/javascript-node-8/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/javascript-node-8/.npmignore
+++ b/containers/javascript-node-8/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/kubernetes-helm/.devcontainer/ignore
+++ b/containers/kubernetes-helm/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/kubernetes-helm/.npmignore
+++ b/containers/kubernetes-helm/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/markdown/.devcontainer/ignore
+++ b/containers/markdown/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/markdown/.npmignore
+++ b/containers/markdown/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/php-7/.devcontainer/ignore
+++ b/containers/php-7/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/php-7/.npmignore
+++ b/containers/php-7/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/plantuml/.devcontainer/ignore
+++ b/containers/plantuml/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/plantuml/.npmignore
+++ b/containers/plantuml/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/powershell/.devcontainer/ignore
+++ b/containers/powershell/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/powershell/.npmignore
+++ b/containers/powershell/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/python-2/.devcontainer/ignore
+++ b/containers/python-2/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/python-2/.npmignore
+++ b/containers/python-2/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/python-3-django/.devcontainer/ignore
+++ b/containers/python-3-django/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/python-3-django/.npmignore
+++ b/containers/python-3-django/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/python-3-flask-redis/.devcontainer/ignore
+++ b/containers/python-3-flask-redis/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/python-3-flask-redis/.npmignore
+++ b/containers/python-3-flask-redis/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/python-3-jupyter-pyspark/.devcontainer/ignore
+++ b/containers/python-3-jupyter-pyspark/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/python-3-jupyter-pyspark/.npmignore
+++ b/containers/python-3-jupyter-pyspark/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/python-3/.devcontainer/ignore
+++ b/containers/python-3/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/python-3/.npmignore
+++ b/containers/python-3/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/ruby-2/.devcontainer/ignore
+++ b/containers/ruby-2/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/ruby-2/.npmignore
+++ b/containers/ruby-2/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/rust/.devcontainer/ignore
+++ b/containers/rust/.devcontainer/ignore
@ -1,6 +0,0 @@
-README.md
-test-project
-.vscode
-src
-Cargo.lock
-Cargo.toml
--- a/containers/swift-4/.devcontainer/ignore
+++ b/containers/swift-4/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/swift-4/.npmignore
+++ b/containers/swift-4/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore
--- a/containers/typescript-node-8/.devcontainer/ignore
+++ b/containers/typescript-node-8/.devcontainer/ignore
@ -1,3 +0,0 @@
-README.md
-test-project
-.vscode
--- a/containers/typescript-node-8/.npmignore
+++ b/containers/typescript-node-8/.npmignore
@ -0,0 +1,4 @@
+README.md
+test-project
+.vscode
+.npmignore