* Change run commands to use imageId instead of name
* changes proposed by bwateratmsft
* Update src/commands/images/runImage.ts
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
* Update src/commands/selectCommandTemplate.ts
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
---------
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
* fix genericV2 root not showing up when adding registry
* throw good error when no registries are connected
* use hasTrackedRegistries function
* use npm dot com
* sort registry items by alphabetical order
* show not available message when there no registries provider available
* add prompt for registry provider selection
* make sort more robust
* use package from npm com
* Registries V2 (#4021)
* saving progress
* added context values for copy full tag
* added back copy remote image digest
* comment out commands that are not implemented yet
* added disconnext registry function back
* small fixes to adjust to new changes
* Made Some ACR Commands Work (#4027)
* adjusted scheduleRunReuqest to work with new registries tree
* delete azure repository command implementation
* actually added back delete azure repository
* added back delete Azure Registry command
* changed registry tree util file name to be more general
* added openInAzurePortalCommand
* Added Back `createAzureRegistry` command (#4029)
* adjusted scheduleRunReuqest to work with new registries tree
* delete azure repository command implementation
* actually added back delete azure repository
* added back delete Azure Registry command
* changed registry tree util file name to be more general
* added openInAzurePortalCommand
* added back create azure registry command
* move createAzureClient to azureUtils
* Added More Commands Back (#4031)
* adjusted scheduleRunReuqest to work with new registries tree
* delete azure repository command implementation
* actually added back delete azure repository
* added back delete Azure Registry command
* changed registry tree util file name to be more general
* added openInAzurePortalCommand
* added back create azure registry command
* move createAzureClient to azureUtils
* added viewAzureProperties command back (partially)
* small tweak to make build image in azure work
* added untag azure image commad
* added logout of docker cli command
* add case sensitivity operator to be consistent
* Update src/tree/registries/Azure/AzureRegistryDataProvider.ts
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* added void
* removed symbol as it already exists
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* Added Back Open Docker Hub Item in Browser (#4033)
* added view docker hub item in browser command
* updated npm package
* Added More Commands Back (#4031)
* adjusted scheduleRunReuqest to work with new registries tree
* delete azure repository command implementation
* actually added back delete azure repository
* added back delete Azure Registry command
* changed registry tree util file name to be more general
* added openInAzurePortalCommand
* added back create azure registry command
* move createAzureClient to azureUtils
* added viewAzureProperties command back (partially)
* small tweak to make build image in azure work
* added untag azure image commad
* added logout of docker cli command
* add case sensitivity operator to be consistent
* Update src/tree/registries/Azure/AzureRegistryDataProvider.ts
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* added void
* removed symbol as it already exists
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* minor tweak to avoid index out of bounds
* use built in methods to determine the type of item
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* Added Back `pushImage()` (#4034)
* make pushImage work
* added getAllRegistries command
* added getLoginInformation()
* account for cases where registry in undefined
* added filtering to make get all registries more optima
* added logic to filter github repositories
* Added Back Azure Deploy to ACA & Azure Deploy to AAS (#4038)
* added back basic implementation of deploy ACA
* saving progress
* added step for selecting subscriptions
* small tweaks
* progress on deploy image to azure app service
* improved azure subscription selection experience
* actually made deploy image to AAS work
* remove accidetal change to settings.json
* fix small mistake
* fixed more mistakes
* fix more mistakes
* fixed even more mistakes...
* Implemented Delete Remote Image for GenericV2 (#4039)
* added logic for copy remote imgage digest
* added back delete image
* refined logic for delete image
* fixed pushImage
* reverted changes to registryExperience
* tag logic for GitHub
* be able to debug github image
* added back skipIfOne flag
* Added Untag Image Command for Azure RDP (#4041)
* adjusted context values
* added untag Image
* remove github option for delete tag
* commtag -> v2tag
* slighty changed context values
* Improve UX for Connecting & Disconnecting Generic V2 Registries (#4043)
* added remove tracked registry command
* added command to add generic v2 registry
* Update package.nls.json
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* Update package.nls.json
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* added logic for reconnect (#4045)
* Cleanup Registries Implementation (#4046)
* fixed genericV2 pull image bug
* improved utils to use outside methods
* enable copyImageDigest for all v2 registries
* removed run task & did TODOs
* did TODOs
* use baseUrl
* polished up contextValues
* fixed push image error for dockerhub
* removed azure account listener
* actually removed AzureAccountExtensionListener
* made minor adjustments based in brandon's comments
* use azutils for open in azure portal
* Fix subscription icon
* Small fix
* minor changes to imports
* Remove GitHub package transitive dependency
* Version was wrong
* allow delete image command show up on commontag
* fix miake in deleteImage
* simplified logic in pushImage (#4062)
* simplify logic in deploy to Azure app service (#4063)
* handle contextValueExperience edge case
* changed isWrappedItem function name to be more specific
* Added fire soon function to AzureRDP (#4066)
* added fire soon
* clear time out
* Change fireSoon to take callback function (#4071)
* change firesoon to take callback function
* use RDP label when determining type of registry
* use new RegistryV2RequestOptions for azure requests
* Improve Registry Experience & Simplify Context Values (#4076)
* added implementation
* added comments
* use RegistryQuickPickStep for everything
* fix regex
* fix viewproperties context value package json
* remove unnecessary method
* added back necessary logic
* Commit current progress
* Commit current progress
* adjust package.json
* fix azure typo
* preserve existing additional context value
* make regex more robust
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* remove unnecessary comment
* uploaded & changed azext package version
* Asynchronously fetch createdAt info (#4074)
* Add registry extensibility capability (#4061)
* remove generic v2 root if it's the last one
* get registries package from npm
* Trigger Build
* actually get npm from npm org
* update azext util package to use npm org
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
This update adds support for a few new flags that have been added to
Dockerfile so that they no longer get flagged as errors. The other big
change is the introduction of a comment that can be inserted into the
Dockerfile to instruct the linter to not flag something as an error.
While most errors can be ignored this way, clearly fatal errors that
suggest the Dockerfile is completely broken cannot be ignored.
Signed-off-by: Remy Suen <remy.suen@gmail.com>
* Support multiple .dockerignore files for language id discovery
Update package.json with a 'filenamePatterns' of "*.dockerignore"
since that is the convention to use when using multiple .dockerignore
files when having multiple Dockerfiles.
* Remove accidental additions of .dockerignore files
* use image name property supported by preview 5 instead of 6
* no more static variables
* Get container & image name from msbuild
* actually get image name from target file
* minor changes to clean up PR
* small tweak
* simplified error handling
* simplified logic for getting app project
* actually make ifer project file logic simpler
* convert project properties into interface for future expandibility
* updated nls
* minor changes to naming inside package.json
* changed caching to stack variable
* remove ContainerImageName arg since we're relying on msbuild
* removed inferProjPath as it's unnecessary
* removed docker install logic
* added newest aka.ms links
* added tree item in help tree view
* added support for multi projects
* Disable PR trigger in pipeline (#3979)
* removed docker install logic
* added newest aka.ms links
* added tree item in help tree view
* removed pre-launch task and added buildWithSdk flag
* infer csproj from scaffolded appProjects
* cleaned up changes
* call optional method only if it exists
* added support for .fsproj and .vbproj
* got rid of memento, used static variables instead
* only expose ports if project is a webapp
* use new image namem flag in dotnet publish
* added json schema for run task
* split DockerPlatformHelper into 2
* simplified logic to determine net sdk app
* added comments to explain msbuild properties
* added polymorphism to remove sdk logic from netCore
* removed vbproj for now as it requires further investigation
* added better error handling
* update error message
* revised folder passing implementation
* added override keywords for readability
* removed unnecessary provide task logic
* added logic to normalize app Project based on Docker OS
* added check for no csharp extension installed
* added check to handle undefined additionalProperties
* utilize pathNormalize
* uses current docker os in debugging
* actually uses current docker os in debugging
* updated comment
---------
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Co-authored-by: alexyaang <>
* Experimental Base Structure
* register new task provider
* added build options for DotnetSdk
* removed redundent fields in NetCoreSdkBuildOptions
* added json schema
* basci working implementation of task provider
* reversed unnecessary commits
* added dotnet specific util methods
* fixed dotnet CLI flags
* made code more organized
* organiized files into new folder
* added helper class
* combined build & run into one task
* adddded working version of run command
* added mounts to run arg
* added ambient launch task
* working version of ambient launch task
* added prompt for docker debugger on csharp languag
* stored user image build choices
* added auto .csproj selection & refactored code
* added debug helper
* small tweaks to handle null cases
* add appOutput override to fix dotnet project name bug
* fixed image not running if foldername has special chars
* changed task name and altered schema
* determine helper from prelaunchtask instead of `platform`
* move helper methods to taskhelper
* cleaned up unused comments & method
* made NetTaskHelper more readable
* changed momento name to more detailed
* changed targets to find SDK Container path
* added method to check for sdk container builds
* set git ignore case to false
* Delete netContainerBuild.ts
* added error checking
* added error checking
* Changed const to pascal case & use pre-defined options
* removed redundent duplication method
* removed util class that is unnecessary
* added expose field inside RunContainerCommandOptions
* converted netSdkHelper class into methods only
* minor change to make debugger mount more flexible
* simplified logic for mounting debugger
* changed naming of expose ports
* updated if condition for checking for empty debug config
* renamed helper methods in sdk task utils
* Update Dockerfile language server to 0.10.0
This update adds heredoc support for COPY so that it does not try to
format it or lint it for Dockerfile-specific errors. The update also
includes a fix caused by quotes in comments that can cause the semantic
highlighter to get into an infinite loop.
Signed-off-by: Remy Suen <remy.suen@gmail.com>
* Update the language server to 0.10.1
The new version includes a fix for parsing files with a UTF-8 BOM
header.
Signed-off-by: Remy Suen <remy.suen@gmail.com>
* Update the language server to 0.10.2
This newer version includes various fixes related to multiline
instructions with string content and CRLF newline delimiters.
Signed-off-by: Remy Suen <remy.suen@gmail.com>
---------
Signed-off-by: Remy Suen <remy.suen@gmail.com>
* Add support for editing files in Process Isolated Windows Containers
* Add container isolation mode to inspect containers info
* move check container isolation logic out of DockerClientBase
Alex Yang [MSFT]
João Norberto de Souza Junior
Brandon Waterloo [MSFT]
Remy Suen
Tobias Hernstig
dependabot[bot]
Ian King'ori
Stackie Jia