Fix results pane screen reader accessibility bug (#17935)
* test * changed color to be more contrasting with background * fixed results + messages shortcut not being read --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com>
This commit is contained in:
Родитель
f1a93a3577
Коммит
539edeba4f
|
@ -40,13 +40,14 @@ export interface IGridDataSet {
|
|||
}
|
||||
|
||||
// tslint:disable:max-line-length
|
||||
|
||||
const template = `
|
||||
<div class="fullsize vertBox">
|
||||
<div #resultsheader *ngIf="dataSets.length > 0" role="button" id="resultspane" tabIndex="0" class="boxRow header collapsible"
|
||||
[class.collapsed]="!resultActive"
|
||||
(click)="toggleResultsPane()"
|
||||
(keydown)="handleResultsKeydown($event)"
|
||||
[attr.aria-label]="Constants.resultPaneLabel"
|
||||
[attr.aria-label]="Constants.resultPaneLabel + '. ' + Constants.accessShortcut + ': ' + resultShortcut"
|
||||
[attr.aria-expanded]="resultActive">
|
||||
<span> {{Constants.resultPaneLabel}} </span>
|
||||
<span class="shortCut"> {{resultShortcut}} </span>
|
||||
|
@ -90,7 +91,7 @@ const template = `
|
|||
<msg-context-menu #messagescontextmenu (clickEvent)="handleMessagesContextClick($event)"></msg-context-menu>
|
||||
<div #messagesheader id="messagepane" role="button" tabIndex="0" class="boxRow header collapsible"
|
||||
[class.collapsed]="!messageActive"
|
||||
[attr.aria-label]="Constants.messagePaneLabel"
|
||||
[attr.aria-label]="Constants.messagePaneLabel + '. ' + Constants.accessShortcut + ': ' + messageShortcut"
|
||||
[attr.aria-expanded]="messageActive"
|
||||
(click)="toggleMessagesPane()"
|
||||
(keydown)="handleMessagesKeydown($event)"
|
||||
|
@ -136,6 +137,7 @@ const template = `
|
|||
<div id="resizeHandle" [class.hidden]="!resizing" [style.top.px]="resizeHandleTop"></div>
|
||||
</div>
|
||||
`;
|
||||
|
||||
// tslint:enable:max-line-length
|
||||
|
||||
/**
|
||||
|
|
|
@ -20,6 +20,7 @@ export let elapsedTimeLabel = 'Total execution time: {0}';
|
|||
|
||||
/** Warning message for save icons */
|
||||
export let msgCannotSaveMultipleSelections = 'Save results command cannot be used with multiple selections.';
|
||||
export let accessShortcut = 'Access through shortcut'
|
||||
|
||||
export function loadLocalizedConstant(key: string, value: string): void {
|
||||
// Update the value of the property with the name equal to key in this file
|
||||
|
|
Загрузка…
Ссылка в новой задаче