From 81d15c7aebc2b8f715eeff61dd9eeb8ee6c1a5d9 Mon Sep 17 00:00:00 2001 From: laurennat Date: Sun, 21 Jul 2024 11:14:55 -0700 Subject: [PATCH] fixed screen reader bug in query history (#17937) Co-authored-by: Lauren Nathan --- localization/xliff/enu/constants/localizedConstants.enu.xlf | 6 ++++++ src/queryHistory/queryHistoryNode.ts | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/localization/xliff/enu/constants/localizedConstants.enu.xlf b/localization/xliff/enu/constants/localizedConstants.enu.xlf index 834858cb..caee8d3a 100644 --- a/localization/xliff/enu/constants/localizedConstants.enu.xlf +++ b/localization/xliff/enu/constants/localizedConstants.enu.xlf @@ -671,6 +671,12 @@ Dismiss + + Query succeeded + + + Query failed + diff --git a/src/queryHistory/queryHistoryNode.ts b/src/queryHistory/queryHistoryNode.ts index 4c0a5874..8ed8a181 100644 --- a/src/queryHistory/queryHistoryNode.ts +++ b/src/queryHistory/queryHistoryNode.ts @@ -5,6 +5,7 @@ import * as vscode from 'vscode'; import * as path from 'path'; +import * as os from 'os'; import * as LocalizedConstants from '../constants/localizedConstants'; /** @@ -51,7 +52,8 @@ export class QueryHistoryNode extends vscode.TreeItem { this._isSuccess = isSuccess; this._connectionLabel = connectionLabel; this.iconPath = this._isSuccess ? this.successIcon : this.failureIcon; - this.tooltip = tooltip; + const queryStatusLabel = this._isSuccess ? LocalizedConstants.querySuccess : LocalizedConstants.queryFailed; + this.tooltip = `${tooltip}${os.EOL}${os.EOL}${queryStatusLabel}`; this.contextValue = QueryHistoryNode.contextValue; }