mono
/
corefx
зеркало из https://github.com/mono/corefx.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
corefx/referenceFromRuntime.targets

60 строки
3.5 KiB
Plaintext
Исходник Постоянная ссылка Обычный вид История

Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Target Name="AddReferenceFromRuntimeForTests"
AfterTargets="ResolveAssemblyReferences"
Condition="'$(IsTestProject)'=='true' AND '@(ReferenceFromRuntime)' != ''">
<ItemGroup>
<!-- tests can use anything from the RuntimePath -->
<ReferencePath Include="@(ReferenceFromRuntime->'$(RuntimePath)%(Identity).dll')" />
Allow copy-local ReferenceFromRuntime Tests may want to copy a ReferenceFromRuntime to the test output directory. To do this, a test can set Private=true (same as you would for a Reference). By default we don't do this, because anything in the runtime folder will be part of the shared framework that the test runs on. In the case of Microsoft.XmlSerializer.Generator it's reference is an application and the project expects this to be next to the test assembly.
2017-09-08 20:47:47 +03:00
<ReferenceCopyLocalPaths Condition="'%(ReferenceFromRuntime.Private)' == 'true'" Include="@(ReferenceFromRuntime->'$(RuntimePath)%(Identity).dll')" />
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
</ItemGroup>
</Target>
Update Reference and ProjectReference ordering in our targets. Switch the to using a common DefaultReference notion between targets and eliminated targetingpack.props. Moved the default references for tests into tests.targets. Fixed where we added Private to References because in some cases it wasn't happing because the target that set Private=true was run before all the references were added. This is why we are now setting Reference Private=false in a different target from ProjectReference Private=false because they sometimes need to happen at different times in the target execution. Set _FindDependencies=false to block RAR from trying to automatically add the closure of the primary references as it added automatic references that folks could accidently start depending on and we want to be explicit about our dependencies. This was really noticable once we started auto referencing the netstandard facade which caused everything to get pulled into the reference set. To fix the various build scenarios where we add ProjectReferences automatically we needed a common target to hook on which we now have AddProjectReferencesDynamically target that correctly hooks into the various dependency chains. See comment in targets file for more details.
2017-02-07 22:26:01 +03:00
<Target Name="AddRuntimeProjectReference"
BeforeTargets="AddProjectReferencesDynamically"
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
Condition="'$(IsTestProject)'!='true' AND '@(ReferenceFromRuntime)' != ''">
Add converter from IEnumerable to TheoryData (#21671) * Add converter from IEnumerable to TheoryData Manipulating test input data in IEnumerable format is desirable, but a bit awkward to get into IEnumerable<object[]> format that [Theory] expects. Add test project to new test project. :) Change a test in System.IO.FileSystem to theory with new extension. * Fix performance test project * Run the UpdateConfigurations target * Add netfx reference
2017-06-29 07:15:33 +03:00
<Error Condition="('$(IsReferenceAssembly)' != 'true' OR '$(AllowReferenceFromRuntime)' == 'true') AND '$(RuntimeProjectFile)' == ''" Text="RuntimeProjectFile must be specified when using ReferenceFromRuntime from source projects." />
<Error Condition="'$(IsReferenceAssembly)' == 'true' AND '$(AllowReferenceFromRuntime)' != 'true'" Text="ReferenceFromRuntime may not be used from reference assemblies." />
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
<ItemGroup>
<ProjectReference Include="$(RuntimeProjectFile)">
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
<OutputItemType>_referencePathFromRuntime</OutputItemType>
</ProjectReference>
</ItemGroup>
</Target>
Update Reference and ProjectReference ordering in our targets. Switch the to using a common DefaultReference notion between targets and eliminated targetingpack.props. Moved the default references for tests into tests.targets. Fixed where we added Private to References because in some cases it wasn't happing because the target that set Private=true was run before all the references were added. This is why we are now setting Reference Private=false in a different target from ProjectReference Private=false because they sometimes need to happen at different times in the target execution. Set _FindDependencies=false to block RAR from trying to automatically add the closure of the primary references as it added automatic references that folks could accidently start depending on and we want to be explicit about our dependencies. This was really noticable once we started auto referencing the netstandard facade which caused everything to get pulled into the reference set. To fix the various build scenarios where we add ProjectReferences automatically we needed a common target to hook on which we now have AddProjectReferencesDynamically target that correctly hooks into the various dependency chains. See comment in targets file for more details.
2017-02-07 22:26:01 +03:00
<Target Name="FilterReferenceFromRuntime"
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
AfterTargets="ResolveProjectReferences"
Condition="'$(IsTestProject)'!='true' AND '@(ReferenceFromRuntime)' != ''">
<ItemGroup>
<!-- transform to filename in order to intersect -->
Should only look at .dll files for ReferenceFromRuntime resolution When we added the override folks would sometimes also get pdbs and when they did the ReferenceFromRuntime logic was broken. To fix this we make sure we only look at .dll files for the ReferenceFromRuntime resolution logic.
2017-03-02 21:00:54 +03:00
<_referencePathFromRuntimeByFileName Include="@(_referencePathFromRuntime->'%(FileName)')" Condition="'%(_referencePathFromRuntime.Extension)' == '.dll'" >
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
<ReferencePath>%(Identity)</ReferencePath>
</_referencePathFromRuntimeByFileName>
<!-- intersect with ReferenceFromRuntime -->
<_filteredReferencePathFromRuntimeByFileName Include="@(_referencePathFromRuntimeByFileName)"
Condition="'@(_referencePathFromRuntimeByFileName)' == '@(ReferenceFromRuntime)' AND '%(Identity)' != ''" />
Allow native images to resolve for ReferenceFromRuntime references We will likely be removing the System.Private.CoreLib.dll and only having System.Private.CoreLib.ni.dll so we need our ReferenceFromRuntime infrastructure to support falling back to the ni if that is the only thing present.
2017-03-01 23:53:25 +03:00
<_remainingReferenceFromRuntime Include="@(ReferenceFromRuntime)" Exclude="@(_filteredReferencePathFromRuntimeByFileName)" />
<!-- Fallback and check for native images for the references as well -->
<_remainingReferenceFromRuntimeWithNI Include="@(_remainingReferenceFromRuntime->'%(Identity).ni')">
<OriginalReferenceFromRuntime>%(Identity)</OriginalReferenceFromRuntime>
</_remainingReferenceFromRuntimeWithNI>
<_filteredReferencePathFromRuntimeByFileName Include="@(_referencePathFromRuntimeByFileName)"
Condition="'@(_referencePathFromRuntimeByFileName)' == '@(_remainingReferenceFromRuntimeWithNI)' AND '%(Identity)' != ''" />
<_missingReferenceFromRuntime Include="@(_remainingReferenceFromRuntimeWithNI)" Exclude="@(_filteredReferencePathFromRuntimeByFileName)" />
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
<!-- transform back to path -->
<ReferencePath Include="@(_filteredReferencePathFromRuntimeByFileName->'%(ReferencePath)')" />
</ItemGroup>
<Error Condition="'@(_missingReferenceFromRuntime)' != ''"
Allow native images to resolve for ReferenceFromRuntime references We will likely be removing the System.Private.CoreLib.dll and only having System.Private.CoreLib.ni.dll so we need our ReferenceFromRuntime infrastructure to support falling back to the ni if that is the only thing present.
2017-03-01 23:53:25 +03:00
Text="Could not resolve ReferenceFromRuntime item(s) '%(_missingReferenceFromRuntime.OriginalReferenceFromRuntime)' from '$(RuntimeProjectFile)'." />
Make ReferenceFromRuntime use project reference ReferenceFromRuntime for src projects isn't safe. It allows any source project to reference the output of another source project without properly sequencing the build. This fixes that by changing ReferenceFromRuntime to instead use a ProjectReference to the runtime project for the building configuration and filter that to just the files requested. I also completely block the use of ReferenceFromRuntime in test projects
2017-02-02 02:58:41 +03:00
</Target>
</Project>