Revert "Scale back [Serializable] CoreFX types (#19742)"

This reverts commit 6dd451f514.

CodeAnalysis.ruleset

@@ -19,7 +19,7 @@
     <Rule Id="CA2229" Action="Error" /> <!-- Serializable type doesn't have a serialization constructor -->
     <Rule Id="CA2235" Action="None" /> <!-- Serializable type has non serializable field -->
     <Rule Id="CA2231" Action="None" /> <!-- Overload operator equals when overriding ValueType.Equals -->
-    <Rule Id="CA2237" Action="None" /> <!-- Add [Serializable] to types that implement ISerializable -->
+    <Rule Id="CA2237" Action="Error" /> <!-- Add [Serializable] to types that implement ISerializable -->
 
     <Rule Id="CA2200" Action="None"/> <!-- Rethrowing caught exception changes stack information -->
 

src/Common/src/System/CodeDom/CodeObject.cs

@@ -11,6 +11,7 @@ namespace System.CodeDom
 namespace System.Runtime.Serialization
 #endif
 {
+    [Serializable]
 #if !FEATURE_SERIALIZATION
     public class CodeObject
 #else

src/Common/src/System/CodeDom/CodeTypeReference.cs

@@ -23,6 +23,7 @@ namespace System.Runtime.Serialization
         GenericTypeParameter = 0x00000002
     }
 
+    [Serializable]
 #if !FEATURE_SERIALIZATION
     public class CodeTypeReference : CodeObject
 #else

src/Common/src/System/CodeDom/CodeTypeReferenceCollection.cs

@@ -10,6 +10,7 @@ namespace System.CodeDom
 namespace System.Runtime.Serialization
 #endif
 {
+    [Serializable]
 #if !FEATURE_SERIALIZATION
     public class CodeTypeReferenceCollection : CollectionBase
 #else

src/Common/src/System/Collections/CompatibleComparer.cs

@@ -6,6 +6,7 @@
 
 namespace System.Collections
 {
+    [Serializable]
     internal sealed class CompatibleComparer : IEqualityComparer
     {
         private readonly IHashCodeProvider _hcp;

src/Common/src/System/Data/Common/NameValuePair.cs

@@ -7,6 +7,7 @@ using System.Runtime.Serialization;
 
 namespace System.Data.Common
 {
+    [Serializable]
     internal sealed class NameValuePair
     {
         readonly private string _name;

src/Common/src/System/Net/NetworkInformation/NetworkInformationException.cs

@@ -14,6 +14,7 @@ namespace System.Net.NetworkInformation
     ///       Provides NetworkInformation exceptions to the application.
     ///    </para>
     /// </devdoc>
+    [Serializable]
     public class NetworkInformationException : Win32Exception
     {
         /// <devdoc>

src/Common/src/System/Text/DBCSDecoder.cs

@@ -8,6 +8,7 @@ using System.Diagnostics;
 
 namespace System.Text
 {
+    [Serializable]
     internal sealed class DecoderDBCS : Decoder
     {
         private readonly Encoding _encoding;

src/Common/src/System/Text/OSEncoder.cs

@@ -8,6 +8,7 @@ using System.Diagnostics;
 
 namespace System.Text
 {
+    [Serializable]
     internal sealed class OSEncoder : Encoder
     {
         private char _charLeftOver;

src/Common/src/System/Text/OSEncoding.Windows.cs

@@ -9,6 +9,7 @@ using System.Diagnostics.Contracts;
 
 namespace System.Text
 {
+    [Serializable]
     internal sealed class OSEncoding : Encoding
     {
         private readonly int _codePage;

src/Common/tests/System/Collections/IEnumerable.Generic.Serialization.Tests.cs

@@ -15,13 +15,6 @@ namespace System.Collections.Tests
         public void IGenericSharedAPI_SerializeDeserialize(int count)
         {
             IEnumerable<T> expected = GenericIEnumerableFactory(count);
-
-            // Not all IEnumerables are intended to be Serializable
-            if (!expected.GetType().IsSerializable)
-            {
-                return;
-            }
-
             IEnumerable<T> actual = BinaryFormatterHelpers.Clone(expected);
 
             if (Order == EnumerableOrder.Sequential)

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderException.cs

@@ -12,6 +12,7 @@ namespace Microsoft.CSharp.RuntimeBinder
     /// <see cref="RuntimeBinderException"/> represents a failure to bind in the sense of a usual compiler error, whereas <see cref="RuntimeBinderInternalCompilerException"/>
     /// represents a malfunctioning of the runtime binder itself.
     /// </summary>
+    [Serializable]
     public class RuntimeBinderException : Exception
     {
         /// <summary>

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderInternalCompilerException.cs

@@ -12,6 +12,7 @@ namespace Microsoft.CSharp.RuntimeBinder
     /// <see cref="RuntimeBinderException"/> represents a failure to bind in the sense of a usual compiler error, whereas <see cref="RuntimeBinderInternalCompilerException"/>
     /// represents a malfunctioning of the runtime binder itself.
     /// </summary>
+    [Serializable]
     public class RuntimeBinderInternalCompilerException : Exception
     {
         /// <summary>

src/Microsoft.CSharp/tests/RuntimeBinderExceptionTests.cs

@@ -20,6 +20,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Assert.Empty(rbe.Data);
             Assert.True((rbe.HResult & 0xFFFF0000) == 0x80130000); // Error from .NET
             Assert.Contains(rbe.GetType().FullName, rbe.Message); // Localized, but should contain type name.
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
 
         [Fact]
@@ -33,6 +34,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Assert.Same(message, rbe.Message);
             rbe = new RuntimeBinderException(null);
             Assert.Equal(new RuntimeBinderException().Message, rbe.Message);
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
 
 
@@ -43,6 +45,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Exception inner = new Exception("This is a test exception");
             RuntimeBinderException rbe = new RuntimeBinderException(message, inner);
             Assert.Same(inner, rbe.InnerException);
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
     }
 }

src/Microsoft.CSharp/tests/RuntimeBinderInternalCompilerExceptionTests.cs

@@ -18,6 +18,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Assert.Empty(rbe.Data);
             Assert.True((rbe.HResult & 0xFFFF0000) == 0x80130000); // Error from .NET
             Assert.Contains(rbe.GetType().FullName, rbe.Message); // Localized, but should contain type name.
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
 
         [Fact]
@@ -31,6 +32,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Assert.Same(message, rbe.Message);
             rbe = new RuntimeBinderInternalCompilerException(null);
             Assert.Equal(new RuntimeBinderInternalCompilerException().Message, rbe.Message);
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
 
 
@@ -41,6 +43,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
             Exception inner = new Exception("This is a test exception");
             RuntimeBinderInternalCompilerException rbe = new RuntimeBinderInternalCompilerException(message, inner);
             Assert.Same(inner, rbe.InnerException);
+            BinaryFormatterHelpers.AssertRoundtrips(rbe);
         }
     }
 }

src/Microsoft.Win32.Primitives/src/System/ComponentModel/Win32Exception.cs

@@ -10,6 +10,7 @@ namespace System.ComponentModel
     /// <devdoc>
     ///    <para>The exception that is thrown for a Win32 error code.</para>
     /// </devdoc>
+    [Serializable]
     public partial class Win32Exception : ExternalException, ISerializable
     {
         /// <devdoc>

src/System.CodeDom/src/System/CodeDom/CodeArgumentReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeArgumentReferenceExpression : CodeExpression
     {
         private string _parameterName;

src/System.CodeDom/src/System/CodeDom/CodeArrayCreateExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeArrayCreateExpression : CodeExpression
     {
         private readonly CodeExpressionCollection _initializers = new CodeExpressionCollection();

src/System.CodeDom/src/System/CodeDom/CodeArrayIndexerExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeArrayIndexerExpression : CodeExpression
     {
         private CodeExpressionCollection _indices;

src/System.CodeDom/src/System/CodeDom/CodeAssignStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAssignStatement : CodeStatement
     {
         public CodeAssignStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeAttachEventStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAttachEventStatement : CodeStatement
     {
         private CodeEventReferenceExpression _eventRef;

src/System.CodeDom/src/System/CodeDom/CodeAttributeArgument.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAttributeArgument
     {
         private string _name;

src/System.CodeDom/src/System/CodeDom/CodeAttributeArgumentCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAttributeArgumentCollection : CollectionBase
     {
         public CodeAttributeArgumentCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeAttributeDeclaration.cs

@@ -5,6 +5,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAttributeDeclaration
     {
         private string _name;

src/System.CodeDom/src/System/CodeDom/CodeAttributeDeclarationCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeAttributeDeclarationCollection : CollectionBase
     {
         public CodeAttributeDeclarationCollection()

src/System.CodeDom/src/System/CodeDom/CodeBaseReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeBaseReferenceExpression : CodeExpression
     {
     }

src/System.CodeDom/src/System/CodeDom/CodeBinaryOperatorExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeBinaryOperatorExpression : CodeExpression
     {
         public CodeBinaryOperatorExpression() { }

src/System.CodeDom/src/System/CodeDom/CodeCastExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCastExpression : CodeExpression
     {
         private CodeTypeReference _targetType;

src/System.CodeDom/src/System/CodeDom/CodeCatchClause.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCatchClause
     {
         private CodeStatementCollection _statements;

src/System.CodeDom/src/System/CodeDom/CodeCatchClauseCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCatchClauseCollection : CollectionBase
     {
         public CodeCatchClauseCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeChecksumPragma.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeChecksumPragma : CodeDirective
     {
         private string _fileName;

src/System.CodeDom/src/System/CodeDom/CodeComment.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeComment : CodeObject
     {
         private string _text;

src/System.CodeDom/src/System/CodeDom/CodeCommentStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCommentStatement : CodeStatement
     {
         public CodeCommentStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeCommentStatementCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCommentStatementCollection : CollectionBase
     {
         public CodeCommentStatementCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeCompileUnit.cs

@@ -6,6 +6,7 @@ using System.Collections.Specialized;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeCompileUnit : CodeObject
     {
         private StringCollection _assemblies = null;

src/System.CodeDom/src/System/CodeDom/CodeConditionStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeConditionStatement : CodeStatement
     {
         public CodeConditionStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeConstructor.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeConstructor : CodeMemberMethod
     {
         public CodeConstructor()

src/System.CodeDom/src/System/CodeDom/CodeDefaultValueExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDefaultValueExpression : CodeExpression
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeDelegateCreateExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDelegateCreateExpression : CodeExpression
     {
         private CodeTypeReference _delegateType;

src/System.CodeDom/src/System/CodeDom/CodeDelegateInvokeExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDelegateInvokeExpression : CodeExpression
     {
         public CodeDelegateInvokeExpression() { }

src/System.CodeDom/src/System/CodeDom/CodeDirectionExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDirectionExpression : CodeExpression
     {
         public CodeDirectionExpression() { }

src/System.CodeDom/src/System/CodeDom/CodeDirective.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDirective : CodeObject
     {
     }

src/System.CodeDom/src/System/CodeDom/CodeDirectiveCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeDirectiveCollection : CollectionBase
     {
         public CodeDirectiveCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeEntryPointMethod.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeEntryPointMethod : CodeMemberMethod
     {
         public CodeEntryPointMethod() { }

src/System.CodeDom/src/System/CodeDom/CodeEventReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeEventReferenceExpression : CodeExpression
     {
         private string _eventName;

src/System.CodeDom/src/System/CodeDom/CodeExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeExpression : CodeObject
     {
     }

src/System.CodeDom/src/System/CodeDom/CodeExpressionCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeExpressionCollection : CollectionBase
     {
         public CodeExpressionCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeExpressionStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeExpressionStatement : CodeStatement
     {
         public CodeExpressionStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeFieldReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeFieldReferenceExpression : CodeExpression
     {
         private string _fieldName;

src/System.CodeDom/src/System/CodeDom/CodeGotoStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeGotoStatement : CodeStatement
     {
         private string _label;

src/System.CodeDom/src/System/CodeDom/CodeIndexerExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeIndexerExpression : CodeExpression
     {
         private CodeExpressionCollection _indices;

src/System.CodeDom/src/System/CodeDom/CodeIterationStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeIterationStatement : CodeStatement
     {
         public CodeIterationStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeLabeledStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeLabeledStatement : CodeStatement
     {
         private string _label;

src/System.CodeDom/src/System/CodeDom/CodeLinePragma.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeLinePragma
     {
         private string _fileName;

src/System.CodeDom/src/System/CodeDom/CodeMemberEvent.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMemberEvent : CodeTypeMember
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeMemberField.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMemberField : CodeTypeMember
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeMemberMethod.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMemberMethod : CodeTypeMember
     {
         private readonly CodeParameterDeclarationExpressionCollection _parameters = new CodeParameterDeclarationExpressionCollection();

src/System.CodeDom/src/System/CodeDom/CodeMemberProperty.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMemberProperty : CodeTypeMember
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeMethodInvokeExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMethodInvokeExpression : CodeExpression
     {
         private CodeMethodReferenceExpression _method;

src/System.CodeDom/src/System/CodeDom/CodeMethodReturnStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMethodReturnStatement : CodeStatement
     {
         public CodeMethodReturnStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeNamespace.cs

@@ -6,6 +6,7 @@ using System.Runtime.Serialization;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeNamespace : CodeObject
     {
         private string _name;

src/System.CodeDom/src/System/CodeDom/CodeNamespaceCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeNamespaceCollection : CollectionBase
     {
         public CodeNamespaceCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeNamespaceImport.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeNamespaceImport : CodeObject
     {
         private string _nameSpace;

src/System.CodeDom/src/System/CodeDom/CodeNamespaceImportCollection.cs

@@ -7,6 +7,7 @@ using System.Collections.Generic;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeNamespaceImportCollection : IList
     {
         private readonly ArrayList _data = new ArrayList(); // not List<CodeNamespaceImport> to provide desktop-consistent semantics for CopyTo

src/System.CodeDom/src/System/CodeDom/CodeObjectCreateExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeObjectCreateExpression : CodeExpression
     {
         private CodeTypeReference _createType;

src/System.CodeDom/src/System/CodeDom/CodeParameterDeclarationExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeParameterDeclarationExpression : CodeExpression
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeParameterDeclarationExpressionCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeParameterDeclarationExpressionCollection : CollectionBase
     {
         public CodeParameterDeclarationExpressionCollection() { }

src/System.CodeDom/src/System/CodeDom/CodePrimitiveExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodePrimitiveExpression : CodeExpression
     {
         public CodePrimitiveExpression() { }

src/System.CodeDom/src/System/CodeDom/CodePropertyReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodePropertyReferenceExpression : CodeExpression
     {
         private string _propertyName;

src/System.CodeDom/src/System/CodeDom/CodePropertySetValueReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodePropertySetValueReferenceExpression : CodeExpression
     {
     }

src/System.CodeDom/src/System/CodeDom/CodeRegionDirective.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeRegionDirective : CodeDirective
     {
         private string _regionText;

src/System.CodeDom/src/System/CodeDom/CodeRemoveEventStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeRemoveEventStatement : CodeStatement
     {
         private CodeEventReferenceExpression _eventRef;

src/System.CodeDom/src/System/CodeDom/CodeSnippetCompileUnit.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeSnippetCompileUnit : CodeCompileUnit
     {
         private string _value;

src/System.CodeDom/src/System/CodeDom/CodeSnippetExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeSnippetExpression : CodeExpression
     {
         private string _value;

src/System.CodeDom/src/System/CodeDom/CodeSnippetStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeSnippetStatement : CodeStatement
     {
         private string _value;

src/System.CodeDom/src/System/CodeDom/CodeSnippetTypeMember.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeSnippetTypeMember : CodeTypeMember
     {
         private string _text;

src/System.CodeDom/src/System/CodeDom/CodeStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeStatement : CodeObject
     {
         private CodeDirectiveCollection _startDirectives = null;

src/System.CodeDom/src/System/CodeDom/CodeStatementCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeStatementCollection : CollectionBase
     {
         public CodeStatementCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeThisReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeThisReferenceExpression : CodeExpression
     {
     }

src/System.CodeDom/src/System/CodeDom/CodeThrowExceptionStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeThrowExceptionStatement : CodeStatement
     {
         public CodeThrowExceptionStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeTryCatchFinallyStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTryCatchFinallyStatement : CodeStatement
     {
         public CodeTryCatchFinallyStatement() { }

src/System.CodeDom/src/System/CodeDom/CodeTypeConstructor.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeConstructor : CodeMemberMethod
     {
         public CodeTypeConstructor()

src/System.CodeDom/src/System/CodeDom/CodeTypeDeclaration.cs

@@ -6,6 +6,7 @@ using System.Reflection;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeDeclaration : CodeTypeMember
     {
         private readonly CodeTypeReferenceCollection _baseTypes = new CodeTypeReferenceCollection();

src/System.CodeDom/src/System/CodeDom/CodeTypeDeclarationCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeDeclarationCollection : CollectionBase
     {
         public CodeTypeDeclarationCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeTypeDelegate.cs

@@ -6,6 +6,7 @@ using System.Reflection;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeDelegate : CodeTypeDeclaration
     {
         private CodeTypeReference _returnType;

src/System.CodeDom/src/System/CodeDom/CodeTypeMember.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeMember : CodeObject
     {
         private string _name;

src/System.CodeDom/src/System/CodeDom/CodeTypeMemberCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeMemberCollection : CollectionBase
     {
         public CodeTypeMemberCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeTypeOfExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeOfExpression : CodeExpression
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeTypeParameter.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeParameter : CodeObject
     {
         private string _name;

src/System.CodeDom/src/System/CodeDom/CodeTypeParameterCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeParameterCollection : CollectionBase
     {
         public CodeTypeParameterCollection() { }

src/System.CodeDom/src/System/CodeDom/CodeTypeReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeTypeReferenceExpression : CodeExpression
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeVariableDeclarationStatement.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeVariableDeclarationStatement : CodeStatement
     {
         private CodeTypeReference _type;

src/System.CodeDom/src/System/CodeDom/CodeVariableReferenceExpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeVariableReferenceExpression : CodeExpression
     {
         private string _variableName;

src/System.CodeDom/src/System/CodeDom/Compiler/CompilerError.cs

@@ -6,6 +6,7 @@ using System.Globalization;
 
 namespace System.CodeDom.Compiler
 {
+    [Serializable]
     public class CompilerError
     {
         public CompilerError() : this(string.Empty, 0, 0, string.Empty, string.Empty) { }

src/System.CodeDom/src/System/CodeDom/Compiler/CompilerErrorCollection.cs

@@ -6,6 +6,7 @@ using System.Collections;
 
 namespace System.CodeDom.Compiler
 {
+    [Serializable]
     public class CompilerErrorCollection : CollectionBase
     {
         public CompilerErrorCollection() { }

src/System.CodeDom/src/System/CodeDom/Compiler/CompilerParameters.cs

@@ -6,6 +6,7 @@ using System.Collections.Specialized;
 
 namespace System.CodeDom.Compiler
 {
+    [Serializable]
     public partial class CompilerParameters
     {
         private readonly StringCollection _assemblyNames = new StringCollection();

src/System.CodeDom/src/System/CodeDom/Compiler/CompilerResults.cs

@@ -7,6 +7,7 @@ using System.Reflection;
 
 namespace System.CodeDom.Compiler
 {
+    [Serializable]
     public partial class CompilerResults
     {
         private readonly CompilerErrorCollection _errors = new CompilerErrorCollection();

src/System.CodeDom/src/System/CodeDom/codemethodreferenceexpression.cs

@@ -4,6 +4,7 @@
 
 namespace System.CodeDom
 {
+    [Serializable]
     public class CodeMethodReferenceExpression : CodeExpression
     {
         private string _methodName;

src/System.CodeDom/tests/CodeGenerationTests.cs

@@ -121,6 +121,12 @@ namespace System.CodeDom.Tests
                 Console.WriteLine(code);
                 throw;
             }
+
+            // Serialize and deserialize the CodeObject, and make sure code generated for it
+            // is the same as the original.
+            CodeObject clone = BinaryFormatterHelpers.Clone(c);
+            string cloneCode = GenerateCode(clone, provider);
+            Assert.Equal(code, cloneCode);
         }
 
         private static string GenerateCode(CodeObject c, CodeDomProvider provider)

src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentBag.cs

@@ -30,6 +30,7 @@ namespace System.Collections.Concurrent
     /// </remarks>
     [DebuggerTypeProxy(typeof(IProducerConsumerCollectionDebugView<>))]
     [DebuggerDisplay("Count = {Count}")]
+    [Serializable]
     public class ConcurrentBag<T> : IProducerConsumerCollection<T>, IReadOnlyCollection<T>
     {
         /// <summary>The per-bag, per-thread work-stealing queues.</summary>
@@ -1049,6 +1050,7 @@ namespace System.Collections.Concurrent
         /// we use a custom enumerator rather than just returning array's. This enumerator provides
         /// the essential elements of both list's and array's enumerators.
         /// </remarks>
+        [Serializable]
         private sealed class Enumerator : IEnumerator<T>
         {
             private readonly T[] _array;