[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH] XmlReflectionImporter / SoapReflectionImporter fixes

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gert.driesen at pandora.be.

http://bugzilla.ximian.com/show_bug.cgi?id=77392

--- shadow/77392	2006-02-08 14:41:46.000000000 -0500
+++ shadow/77392.tmp.16798	2006-02-08 15:03:25.000000000 -0500
@@ -133,6 +133,26 @@
 change is not worth it. After all, nobody uses XmlTypeMapping
 directly. Moreover, the serializer could be relying on the old value
 to produce the correct output, so we might be introducing a regression
 here.
 
 
+
+------- Additional Comments From gert.driesen at pandora.be  2006-02-08 15:03 -------
+- All (or almost all) Import*Mapping methods used the TypeData (eg. 
+ImportClassMapping, ImportEnumMapping, ImportListMapping, ...).
+
+- About the unit tests: I know that the XmlTypeMapping tests do not 
+have that much value, but still ... I definitely agree that these 
+tests by itself do not cover much of the serialization code. I agree 
+that much more tests are needed. However, to make more complex tests 
+some of the basic stuff (like XmlTypeMapping.*) needs to match that 
+of MS.NET.
+
+I was hoping to add a large batch of tests using 
+ServiceDescriptionReflector but I ran into implementation 
+differences all too soon, making it nearly impossible to have good 
+tests (that pass on both Mono and MS.NET).
+
+I'll look into your remarks tomorrow. I definitely don't mind if 
+some parts of my patch are left out because you do not feel 
+comfortable with the changes.