зеркало из https://github.com/mono/mail-archives.git
123 строки
5.2 KiB
HTML
123 строки
5.2 KiB
HTML
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
|
|
<HTML>
|
|
<HEAD>
|
|
<TITLE> [Mono-bugs] [Bug 77392][Nor] Changed - [PATCH]
|
|
XmlReflectionImporter / SoapReflectionImporter fixes
|
|
</TITLE>
|
|
<LINK REL="Index" HREF="index.html" >
|
|
<LINK REL="made" HREF="mailto:mono-bugs%40lists.ximian.com?Subject=%5BMono-bugs%5D%20%5BBug%2077392%5D%5BNor%5D%20Changed%20-%20%5BPATCH%5D%0A%09XmlReflectionImporter%20/%20SoapReflectionImporter%20fixes&In-Reply-To=bug-77392%40chernobyl.ximian.com">
|
|
<META NAME="robots" CONTENT="index,nofollow">
|
|
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
|
|
<LINK REL="Previous" HREF="039085.html">
|
|
<LINK REL="Next" HREF="039087.html">
|
|
</HEAD>
|
|
<BODY BGCOLOR="#ffffff">
|
|
<H1>[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH]
|
|
XmlReflectionImporter / SoapReflectionImporter fixes</H1>
|
|
<B>bugzilla-daemon at bugzilla.ximian.com</B>
|
|
<A HREF="mailto:mono-bugs%40lists.ximian.com?Subject=%5BMono-bugs%5D%20%5BBug%2077392%5D%5BNor%5D%20Changed%20-%20%5BPATCH%5D%0A%09XmlReflectionImporter%20/%20SoapReflectionImporter%20fixes&In-Reply-To=bug-77392%40chernobyl.ximian.com"
|
|
TITLE="[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH]
|
|
XmlReflectionImporter / SoapReflectionImporter fixes">bugzilla-daemon at bugzilla.ximian.com
|
|
</A><BR>
|
|
<I>Wed Feb 8 14:25:50 EST 2006</I>
|
|
<P><UL>
|
|
<LI>Previous message: <A HREF="039085.html">[Mono-bugs] [Bug 77396][Min] Changed - GMCS 1.1.13.1 crashes
|
|
(different from bug 77395) when compiling generics code below
|
|
</A></li>
|
|
<LI>Next message: <A HREF="039087.html">[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH]
|
|
XmlReflectionImporter / SoapReflectionImporter fixes
|
|
</A></li>
|
|
<LI> <B>Messages sorted by:</B>
|
|
<a href="date.html#39086">[ date ]</a>
|
|
<a href="thread.html#39086">[ thread ]</a>
|
|
<a href="subject.html#39086">[ subject ]</a>
|
|
<a href="author.html#39086">[ author ]</a>
|
|
</LI>
|
|
</UL>
|
|
<HR>
|
|
<!--beginarticle-->
|
|
<PRE>Please do not reply to this email- if you want to comment on the bug, go to the
|
|
URL shown below and enter your comments there.
|
|
|
|
Changed by <A HREF="http://lists.ximian.com/mailman/listinfo/mono-bugs">lluis at ximian.com.</A>
|
|
|
|
<A HREF="http://bugzilla.ximian.com/show_bug.cgi?id=77392">http://bugzilla.ximian.com/show_bug.cgi?id=77392</A>
|
|
|
|
--- shadow/77392 2006-01-28 13:07:14.000000000 -0500
|
|
+++ shadow/77392.tmp.16389 2006-02-08 14:25:50.000000000 -0500
|
|
@@ -69,6 +69,49 @@
|
|
I'll attach it in a sec.
|
|
|
|
------- Additional Comments From <A HREF="http://lists.ximian.com/mailman/listinfo/mono-bugs">gert.driesen at pandora.be</A> 2006-01-28 13:07 -------
|
|
Created an attachment (id=16411)
|
|
Fixes and unit tests
|
|
|
|
+
|
|
+------- Additional Comments From <A HREF="http://lists.ximian.com/mailman/listinfo/mono-bugs">lluis at ximian.com</A> 2006-02-08 14:25 -------
|
|
+About the changes in XmlReflectionImporter.cs which changes Type by
|
|
+TypeData, I think that there are a lot of changes that are not needed.
|
|
+The typeData is only used by ImportPrimitiveMapping. All other
|
|
+Import*Mapping don't use the extra info, so they don't need to change.
|
|
+The same goes for SoapReflectionImporter.cs.
|
|
+
|
|
+Which is the test case for this change inXmlReflectionImporter.cs?
|
|
+
|
|
++ if (typeData.IsXsdType)
|
|
++ map = new XmlTypeMapping (elementName, rootNamespace, typeData,
|
|
+defaultXmlType, typeNamespace);
|
|
++ else
|
|
++ map = new XmlTypeMapping (elementName, rootNamespace, typeData,
|
|
+defaultXmlType, XmlSerializer.WsdlTypesNamespace);
|
|
++ break;
|
|
+
|
|
+I feel that XmlSerializer.WsdlTypesNamespace should be set somewhere
|
|
+else, not in CreateTypeMapping (notice that we don't set the
|
|
+XmlSchema.Namespace there, why to set XmlSerializer.WsdlTypesNamespace
|
|
+then?).
|
|
+
|
|
+In SoapReflectionImporter.cs:278 Why this?:
|
|
+
|
|
+- map = CreateTypeMapping (typeData, "Array",
|
|
+XmlSerializer.EncodingNamespace);
|
|
++ map = CreateTypeMapping (typeData, null, defaultNamespace);
|
|
+
|
|
+Also in SoapReflectionImporter.cs:321
|
|
+
|
|
+- TypeData typeData = TypeTranslator.GetTypeData (type);
|
|
+- XmlTypeMapping map = helper.GetRegisteredClrType (type,
|
|
+GetTypeNamespace (typeData, defaultNamespace));
|
|
++ Type type = typeData.Type;
|
|
++ string ns = typeData.IsXsdType ? XmlSchema.Namespace :
|
|
+XmlSerializer.WsdlTypesNamespace;
|
|
++ XmlTypeMapping map = helper.GetRegisteredClrType (type, ns);
|
|
+
|
|
+you are ignoring the defaultNamespace parameter with this change. I
|
|
+feel that's not correct.
|
|
+
|
|
+
|
|
</PRE>
|
|
|
|
|
|
<!--endarticle-->
|
|
<HR>
|
|
<P><UL>
|
|
<!--threads-->
|
|
<LI>Previous message: <A HREF="039085.html">[Mono-bugs] [Bug 77396][Min] Changed - GMCS 1.1.13.1 crashes
|
|
(different from bug 77395) when compiling generics code below
|
|
</A></li>
|
|
<LI>Next message: <A HREF="039087.html">[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH]
|
|
XmlReflectionImporter / SoapReflectionImporter fixes
|
|
</A></li>
|
|
<LI> <B>Messages sorted by:</B>
|
|
<a href="date.html#39086">[ date ]</a>
|
|
<a href="thread.html#39086">[ thread ]</a>
|
|
<a href="subject.html#39086">[ subject ]</a>
|
|
<a href="author.html#39086">[ author ]</a>
|
|
</LI>
|
|
</UL>
|
|
|
|
<hr>
|
|
<a href="http://lists.ximian.com/mailman/listinfo/mono-bugs">More information about the mono-bugs
|
|
mailing list</a><br>
|
|
</body></html>
|