зеркало из https://github.com/mono/mail-archives.git
103 строки
3.8 KiB
HTML
103 строки
3.8 KiB
HTML
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
|
|
<HTML>
|
|
<HEAD>
|
|
<TITLE> [Mono-osx] CoreMIDI Progress
|
|
</TITLE>
|
|
<LINK REL="Index" HREF="index.html" >
|
|
<LINK REL="made" HREF="mailto:mono-osx%40lists.ximian.com?Subject=%5BMono-osx%5D%20CoreMIDI%20Progress&In-Reply-To=AANLkTikLoXN2KaX2_Ko0pog7hVbY%2Bz5%2Bhn%3DSHc%2BPYjzW%40mail.gmail.com">
|
|
<META NAME="robots" CONTENT="index,nofollow">
|
|
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
|
|
<LINK REL="Previous" HREF="003790.html">
|
|
<LINK REL="Next" HREF="003857.html">
|
|
</HEAD>
|
|
<BODY BGCOLOR="#ffffff">
|
|
<H1>[Mono-osx] CoreMIDI Progress</H1>
|
|
<B>Miguel de Icaza</B>
|
|
<A HREF="mailto:mono-osx%40lists.ximian.com?Subject=%5BMono-osx%5D%20CoreMIDI%20Progress&In-Reply-To=AANLkTikLoXN2KaX2_Ko0pog7hVbY%2Bz5%2Bhn%3DSHc%2BPYjzW%40mail.gmail.com"
|
|
TITLE="[Mono-osx] CoreMIDI Progress">miguel at novell.com
|
|
</A><BR>
|
|
<I>Fri Jan 28 16:51:38 EST 2011</I>
|
|
<P><UL>
|
|
<LI>Previous message: <A HREF="003790.html">[Mono-osx] CoreMIDI Progress
|
|
</A></li>
|
|
<LI>Next message: <A HREF="003857.html">[Mono-osx] Help creating my first Windows Form!
|
|
</A></li>
|
|
<LI> <B>Messages sorted by:</B>
|
|
<a href="date.html#3891">[ date ]</a>
|
|
<a href="thread.html#3891">[ thread ]</a>
|
|
<a href="subject.html#3891">[ subject ]</a>
|
|
<a href="author.html#3891">[ author ]</a>
|
|
</LI>
|
|
</UL>
|
|
<HR>
|
|
<!--beginarticle-->
|
|
<PRE>Hello Peter,
|
|
|
|
><i> 1. Since the CoreMIDI API is available on iOS, I've moved it to code
|
|
</I>><i> to the maccore repository on my github page
|
|
</I>><i> (<A HREF="https://github.com/peterallenwebb/maccore">https://github.com/peterallenwebb/maccore</A>) and added the constants
|
|
</I>><i> and Make.shared file changes to the corresponding monomac repo to get
|
|
</I>><i> it built into the libraries.
|
|
</I>
|
|
Excellent!
|
|
|
|
><i> 2. Made most of the changes you suggested in your review.
|
|
</I>
|
|
Thanks.
|
|
|
|
><i> Feel free to take a look at the changes as they stand now and let me
|
|
</I>><i> know what you think, but I will spend some more time this weekend
|
|
</I>><i> reviewing, testing, and completing the bindings, so it may be best to
|
|
</I>><i> wait if you want to do a second round of review.
|
|
</I>
|
|
Some comments on the current code:
|
|
|
|
General
|
|
=======
|
|
CoreMIDI namespace should be changed to CoreMidi per the FDG
|
|
|
|
MidiObject.cs:
|
|
==============
|
|
|
|
The Handle property should be defined as read-only, perhaps you can do a
|
|
{ get; private set; }
|
|
|
|
The Dispose there should be used to implement the Dispose pattern which
|
|
is not implemented there:
|
|
|
|
<A HREF="http://msdn.microsoft.com/en-us/library/fs2xkftw.aspx">http://msdn.microsoft.com/en-us/library/fs2xkftw.aspx</A>
|
|
|
|
Currently as it is, it poses a problem as it makes Dispose an abstract
|
|
method, which is later overwritten in derived classes, but that is the
|
|
wrong method to override. The one that needs to be made virtual and
|
|
exposed in the base is Dispose (bool disposing), so the logic for the
|
|
core Dispose () method is done once, and derived classes only implement
|
|
Dispose (bool dispoing).
|
|
|
|
Miguel
|
|
|
|
|
|
|
|
</PRE>
|
|
|
|
<!--endarticle-->
|
|
<HR>
|
|
<P><UL>
|
|
<!--threads-->
|
|
<LI>Previous message: <A HREF="003790.html">[Mono-osx] CoreMIDI Progress
|
|
</A></li>
|
|
<LI>Next message: <A HREF="003857.html">[Mono-osx] Help creating my first Windows Form!
|
|
</A></li>
|
|
<LI> <B>Messages sorted by:</B>
|
|
<a href="date.html#3891">[ date ]</a>
|
|
<a href="thread.html#3891">[ thread ]</a>
|
|
<a href="subject.html#3891">[ subject ]</a>
|
|
<a href="author.html#3891">[ author ]</a>
|
|
</LI>
|
|
</UL>
|
|
|
|
<hr>
|
|
<a href="http://lists.ximian.com/mailman/listinfo/mono-osx">More information about the Mono-osx
|
|
mailing list</a><br>
|
|
</body></html>
|