From ac22138d731593f19b3937db590ff5482e84f891 Mon Sep 17 00:00:00 2001 From: KWierso Date: Thu, 28 Mar 2013 15:31:30 -0700 Subject: [PATCH] Use settings.TEST_SDK instead in place of explicit version numbers in some tests that have been failing since SDK 1.13 was added to FlightDeck --- apps/jetpack/tests/revision_tests.py | 2 +- apps/xpi/tests/test_building.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/jetpack/tests/revision_tests.py b/apps/jetpack/tests/revision_tests.py index adc73694..e3d6dce3 100644 --- a/apps/jetpack/tests/revision_tests.py +++ b/apps/jetpack/tests/revision_tests.py @@ -523,7 +523,7 @@ class PackageRevisionTest(TestCase): assert os.path.isfile(self.zip_file) def test_create_package_with_no_libs_in_sdk(self): - sdk = SDK.objects.create(version='1.12', dir='addon-sdk-1.12') + sdk = SDK.objects.create(version=settings.LOWEST_APPROVED_SDK, dir=settings.TEST_SDK) package = Package.objects.create(author=self.author, type='a') eq_(package.latest.sdk.id, sdk.id) diff --git a/apps/xpi/tests/test_building.py b/apps/xpi/tests/test_building.py index e22bf928..c5c44197 100644 --- a/apps/xpi/tests/test_building.py +++ b/apps/xpi/tests/test_building.py @@ -490,8 +490,8 @@ require('b'); assert not os.path.isfile('%s.xpi' % self.target_basename) assert os.path.exists('%s.json' % self.target_basename) - def test_building_xpi_with_1_12(self): - sdk = SDK.objects.create(version='1.12', dir='addon-sdk-1.12') + def test_building_xpi(self): + sdk = SDK.objects.create(version=settings.LOWEST_APPROVED_SDK, dir=settings.TEST_SDK) package = Package.objects.create(author=self.author, type='a') tstart = time.time()