Граф коммитов

53 Коммитов

Автор SHA1 Сообщение Дата
Stefan Zabka b29c3f4052
Data Aggregator Rewrite (#753)
* First steps in the rewrite

* Fixed import paths

* One giant refactor

* Fixing tests

* Adding mypy

* Removed mypy from pre-commit workflow

* First draft on DataAggregator

* Wrote a DataAggregator that starts and shuts down

* Created tests and added more empty types

* Got demo.py working

* Created sql_provider

* Cleaned up imports in TaskManager

* Added async

* Fixed minor bugs

* First steps at porting arrow

* Introduced TableName and different Task handling

* Added more failing tests

* First first completes others don't

* It works

* Started working on arrow_provider

* Implemented ArrowProvider

* Added logger fixture

* Fixed test_storage_controller

* Fixing OpenWPMTest.visit()

* Moved test/storage_providers to test/storage

* Fixing up tests

* Moved automation to openwpm

* Readded datadir to .gitignore

* Ran repin.sh

* Fixed formatting

* Let's see if this works

* Fixed imports

* Got arrow_memory_provider working

* Starting to rewrite tests

* Setting up fixtures

* Attempting to fix all the tests

* Still fixing tests

* Broken content saving

* Added node

* Fixed screenshot tests

* Fixing more tests

* Fixed tests

* Implemented local_storage.py

* Cleaned up flush_cache

* Fixing more tests

* Wrote test for LocalArrowProvider

* Introduced tests for local_storage_provider.py

* Asserting test dir is empty

* Creating subfolder for different aggregators

* New depencies and init()

* Everything is terribly broken

* Figured out finalize_visit_id

* Running two event loops kinda works???

* Rearming the event

* Introduced mypy

* Downgraded black in pre-commit

* Modifying the database directly

* Fixed formatting

* Made mypy a lil stricter

* Fixing docs and config printing

* Realising I've been using the wrong with

* Trying to figure arrow_storage

* Moving lock initialization in in_memory_storage

* Fixing tests

* Fixing up tests and adding more typechecking

* Fixed num_browsers in test_cache_hits_recorded

* Parametrized unstructured

* String fix

* Added failing test

* New test

* Review changes with Steven

* Fixed repin.sh and test_arrow_cache

* Minor change

* Fixed prune-environment.py

* Removing references to DataAggregator

* Fixed test_seed_persistance

* More paths

* Fixed test display shutdown

* Made cache test more robust

* Update crawler.py

Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>

* Slimming down ManagerParams

* Fixing more tests

* Update test/storage/test_storage_controller.py

Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>

* Purging references to DataAggregator

* Reverted changes to .travis.yml

* Demo.py saves locally again

* Readjusting test paths

* Expanded comment on initialize to reference #846

* Made token optional in finalize_visit_id

* Simplified test paramtetrization

* Fixed callback semantics change

* Removed test_parse_http_stack_trace_str

* Added DataSocket

* WIP need to fix path encoding

* Fixed path encoding

* Added task and crawl to schema

* Fixed paths in GitHub actions

* Refactored completion handling

* Fix tests

* Trying to fix tests on CI

* Removed redundant setting of tag

* Removing references to S3

* Purging more DataAggregator references

* Craking up logging to figure out test failure

* Moved test_values into a fixture

* Fixing GcpUnstructuredProvider

* Fixed paths for future crawls

* Renamed sqllite to official sqlite

* Restored demo.py

* Update openwpm/commands/profile_commands.py

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Restored previous behaviour of DumpProfileCommand

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Removed leftovers

* Cleaned up comments

* Expanded lock check

* Fixed more stuff

* More comment updates

* Update openwpm/socket_interface.py

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Removed outdated comment

* Using config_encoder

* Renamed tar_location to tar_path

* Removed references to database_name in docs

* Cleanup

* Moved screenshot_path and source_dump_path to ManagerParamsInternal

* Fixed imports

* Fixing up comments

* Fixing up comments

* More docs

* updated dependencies

* Fixed test_task_manager

* Reupgraded to python 3.9.1

* Restoring crawl_reference in mp_logger

* Removed unused imports

* Apply suggestions from code review

Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>

* Cleaned up socket handling

* Fixed TaskManager.__exit__

* Moved validation code into config.py

* Removed comment

* Removed comment

* Removed comment

Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>
Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>
2021-02-22 17:51:32 +01:00
Stefan Zabka b252248899
Github Actions for OpenWPM (#838)
* First action test

* Fixing paths

* Adding cache to github actions

* Added badge

* Debugging

* Trying better caching

* More trying

* Trying tests

* Fixing tests

* Removed travis.yml

* Changed comment in re-tests.yaml

* Update environment.yaml

Co-authored-by: Steven Englehardt <se@senglehardt.com>

* Update .github/workflows/run-tests.yaml

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Update README.md

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Changed other references from Travis to CI

* Update .github/workflows/run-tests.yaml

Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>

* Restored cov:check for webextension tests

* Removed webextension fromt test matrix

* All tests should run to completion

Co-authored-by: Steven Englehardt <se@senglehardt.com>
Co-authored-by: Georgia Kokkinou <geor5ko@gmail.com>
2021-01-29 12:21:36 +01:00
Ankush Dua 2d6cfb26f2
Deleted redundant files and references to default_browser_params.json and default_manager_params.json (#822)
* Deleted redundant files and references to -
default_browser_params.json and default_manager_params.json

* added validate_crawl_configs to docs

* updated the docs on how to instantiate TaskManager

* Updated Using_OpenWPM.md

* Updated Platform-Architecture.md
2020-12-09 20:32:37 +01:00
Ankush Dua db1186a9f6
Refactoring browser and manager params into dataclasses (#807)
* initial file commit

* add new dependency for dataclasses

* implemeted basic BrowserParams dataclass

* dependencies update

* file reformat

* implemented basic ManagerParams dataclass

* Update environment dependencies

* Added new error class to validate
 browser and manager params

* file reformat

* Update scripts/environment-unpinned.yaml

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* added validations for BrowserParams dataclass

* Update openwpm/config.py

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Removed unnecessary checks

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Changed error string formatting

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Changed filenamea and necessary imports to resolve conflicts with new master branch(refering to PEP-8 reformatting)

* Revert "Changed filenamea and necessary imports to resolve conflicts with new master branch(refering to PEP-8 reformatting)"

This reverts commit e550c3bd60.

* Revert "Merge branch 'master' into turn_browser_and_manager_params_into_dataclasses"

This reverts commit aff5a384e7, reversing
changes made to 6ecaf5d0a9.

* Revert "Update environment dependencies"

This reverts commit 385825b10a.

* Revert "Merge branch 'turn_browser_and_manager_params_into_dataclasses' of https://github.com/ankushduacodes/OpenWPM into turn_browser_and_manager_params_into_dataclasses"

This reverts commit 6ecaf5d0a9, reversing
changes made to e550c3bd60.

* file reformat

* finalized validate_browser_params function

* fixed typo in error string

* added validations for manager_params

* Explanation for using list for supported browser

* Revert "Revert "Merge branch 'master' into turn_browser_and_manager_params_into_dataclasses""

This reverts commit 6c3e98e57b.

* Revert "Revert "Changed filenamea and necessary imports to resolve conflicts with new master branch(refering to PEP-8 reformatting)""

This reverts commit fc8f48f187.

* import name change from .Error to .error

* moved call_instrument check to config.py

* fixed accidental use of dict syntax in a class

* moved save_content check from deploy_firefox.py

* deleting redundent file

* deleted more redundent files

* removed redundant imports

* added new save_content check

* property name changevariables can not have '-'

* added new attribute  to ManagerParams

* adapted files to validate manager & broswer params

- also added logic to convert the objects(BrowserParams and ManagerParams) to dictionaries to not break the functionality
- also updated demo.py to work with new file names on this branch

* removed obsolete documentaion

* Dependency Update

* Revert "Dependency Update"

This reverts commit 8ee3a02b17.

* Dependencies Update

* unset memory and process watchdogs

* add new output_format and failure_limit checks

* inheriting dataclasses and added type hints to fn

* added todo

* fixed inheritance of dataclasses acc. to plan

* refactor use of dict to use dataclasses(pending)

* more refactoring use of dict to dataclasses -
Also changed some type hints related to new refactoring

* fixed screenshot directory issue -
because of which some of the tests were failing

* added try-except clause for unexpected errors

* added tests to cover dataclasses

* added some new and edited some old docs

* refactor use of __dict__ to dataclass.to_dict()

* Revert "refactor use of __dict__ to dataclass.to_dict()"

This reverts commit a4f35513fa.

* fixed some tests

* refactor use of __dict__ in favor of
dataclass.to_dict() method

* removed some TODOS

* fixed dataclases validation tests

* Update docs/Configuration.md

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Update docs/Configuration.md

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Update docs/Configuration.md

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Update openwpm/config.py

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Update openwpm/config.py

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Update openwpm/task_manager.py

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* minor fixed wrt polishing the PR

* added new check and test for crawl configs

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>
2020-12-02 10:10:45 +01:00
Fukurou Makoto 051a3846cb
Module & Imports conformed to PEP8 (#806)
* Module & Imports conformed to PEP8

* Conformed tests to PEP8

* Conformed tests to PEP8 (2)

* Updated webdriver test for PEP8

* Updated test_timer for PEP8

* Deleting Workspace file

* renamed files to match PEP8

* Update docs/Using_OpenWPM.md

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Changed serversocket to ServerSocket

Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>
2020-11-24 17:34:04 +01:00
Stefan Zabka 53e4516930
V0.13.0 release (#798)
* Preparing v0.13.0 release

* Made links work

* Rebuild extension

* Fixed extension build script

* Removed prepare step as it breaks fresh installs

* Changed openwpm import in tests to absolute

* Fixed test_timer.py

* Reverted changes to webext-instrumentation/package.json

* Pinning to node<15.0.0

* Rebuilding package-lock.json

* Fixed test

* Also mentioned LordReigns

* Fixed links to CONTRIBUTING.md

* Moved to FF83
2020-11-19 14:24:06 +01:00
Ankush Dua 502cd830ad
Renaming automation module to openwpm (#793) 2020-11-14 16:06:51 +01:00
7brokenmirrors 3135003151
Fixed mount instructions for OpenWPM in Docker (#776)
Somehow ~ now expands to /opt/
2020-11-04 17:25:29 +01:00
Stefan Zabka e989ce5f74
Moved the wiki into the repo (#716)
And updated some stuff along the way
2020-10-29 19:17:41 +01:00
Steven Englehardt fdbfe64536
Update study count with new milestone (#772) 2020-10-29 13:06:58 +01:00
Stefan Zabka 44c1060456
Introducing seed profile (#735)
We now differentiate between a seed_profile and a recovery_profile.
This allows us to run stateless crawls with seeded profiles without having to restore support for stateful crawls.

Co-authored-by: Steven Englehardt <senglehardt@mozilla.com>
2020-09-11 10:38:38 +02:00
Stefan Zabka 41023a800a
Update examples for JS instrument settings (#722)
Closes #720
2020-08-07 12:11:35 -05:00
Sarah Bird aefa048612
Arbitrary WebAPI JS instrumentation (#642)
* Add mdn-browser-compat-data

* js_instrument_modules as list

* Add mdn-browser-compat

* Pass a list of instrumentingFunctions

* Script to generate api data

* Working give or take

Getting errors like

OpenWPM: Error name: TypeError post_request_ajax.html:237:17
OpenWPM: Error message: can't redefine non-configurable property
"UNSENT" post_request_ajax.html:238:17

* Small naming cleanup

* Handle non-configurable properties

* Lint

* Add aspirational API

* Begin migration to new JSInstrumentationRequest interface.

* We build and mandate LogSettings.
* We have a new JSInstrumentatinRequest that everything runs through
* Preset, fingerprinting, will be specified in JSON

* Continue making progress

Enum for Operation

* Begin implementing jsModuleRequest validation.

Changing my mind - all validation and construction to be done python
side.
This will reduce JS overhead at runtime.

* Big cleanout- js-instrumentation work moving to python.

* Continue update to python js-instrumentation

* Lint

Can't do all the things I want to with typing due to scope
when content is loaded into page.

* noqa on wip jsinstrumentation file

* Begin updating existing js instrument tests.

* Small cleanups

* Fix naming in calling instrumentJS

* No display mode native for testing

* Restore py test file to orig.

* Support null propertiesToInstrument

* Re-work instrumentObject tests

* Clean-up text in test page.

* Add default to getLogSettings function

* Don't re-assign logSettings.propertiesToInstrument

* Revert "Don't re-assign logSettings.propertiesToInstrument"

This reverts commit 87ccdabf9a.

* Better assign propertiesToInstrument

* Small cleanup

* Make new logSettings object

* Prettify

* Small clean

* -- BREAK -- JS Rework complete

With this commit, the JS side of this PR is complete.
Tests are still failing as fingerprinting implementation has not been
completed on the python side, but all test_js_* tests are passing due
to the core JS API rework being in place.

* Write-out mdn compat data to js_instrumentation .py

* Dry out js test code

* Consolidate JS tests

* Finish missing renames, and add test js via browser_params

* pep8

* New files and failing tests.

* Add a json schema for js_instrument_modules

* Latest py tests

* Flake8

* Ongoing progress.

* More code, more tests.

* flake

* Rename mdn file

* Add latest tests - just implement fingerprinting.json

* flake8

* Add fingerprinting.json (incomplete)

Mimetypes and plugins

* Correct logSettings property name

* Restore create_xpi as function

Needed by manual_test

* Make explicit option for logging to console

* Process browser_params in task manager

* Start being able to pass browser_params to selenium

Also update manual_test to use click

* Revert "Make explicit option for logging to console"

This reverts commit c840fbc5d8.

* Get manual_test working with browser_params

From toplevel directory run:

`python -m test.manual_test --selenium --browser-params --browser-params-file=debug_params.json`

* More robust test for simple fingerprinting output

Can't guarantee order of string output

* Add timing information when testing

* Make recheck really fast.

You'll never hit this recheck as it all happens before page load.

* Handle all inputs properly

* Debug with all window params instrumented

* Load xpi we just built

* Check for ff version support

* Save a bunch of properties

* Relax constraints on what we can instrument.

Let failing happen during instrumentation by using subscript notation.
Don't restrict to MDN list.

* Correct stringifying

* Better name example params, fix some bugs, sample a_f

Some example browser_params - a_f is just working - but crushes
on a page like google.com. g_l and m_z haven't been vetted yet.

* flake8

* Move example browser_params file out of harms way

* Add failing test for regression I introduced.

* Fix for regression.

* Add simple mimeTypes and plugins to fingerprinting.

* Lint JS

* Rm mdn_browser_comat stuff no longer needed

* Remove example_browser_params

They're not used in tests, were just for my testing.

* Load JS_INSTRUMENT_MODULES from JSON string

* Rename JS_INSTRUMENT_MODULES to JS_INSTRUMENT_SETTINGS

* Fixes #28 - Instrument all window.navigator properties.

* Finish removing unused mdn-compat pieces.

* EventID as a shadow variable

* Flake8

* Remove $ prefix and rename

$instrumentionRequests -> jsInstrumentationSettings

* Rename jsInstrumentationRequests->jsInstrumentationSettings

* TS Lint

* Remove use of "request".

Rename python side as per discussion with @englehardt.
Privatize most methods
Numpy docstrings for public methods

* Convert assertions to ValueErrors

* Rename file/folder and fingerprinting -> collection_fingerprinting

file JSInstrumentation.py -> js_instrumentation/__init__.py
collections have their own folder

* Clean-up naming in schema

* Add processing of json schema to documentation

* Rename js_instrumentation again and ref schema location

* Pass JSON not a js string

* Do copying to xpi in npm postbuild step

* Fix import in manual_test

* Revert "Pass JSON not a js string"

This reverts commit 8eb4edb542.

* Add titles to schema pieces

* Add docs for js_instrument_settings

* Bit more README cleanup

* Update README.md

Co-authored-by: Steven Englehardt <englehardt@gmail.com>

* Move updating schema docs section

* Add title
* Fix typo in mac-osx hyperlink

* Make the single-key dictionary clearer

* Remove versions from npm package files

* Clean up instrument_existing_window_property.html and js

We're not using the js in two htmls now, so unify like other test files

* Fix pyside instrumentation test, add more clarificaiton to README

* pyside test must instrument browser apis
* add more to readme to clarify instrumenting

* Use example.com and example.org as localDomains

* context-manage open, and flake8

Co-authored-by: Steven Englehardt <englehardt@gmail.com>
2020-07-08 15:55:22 -07:00
Sarah Bird 37f69dd902
Minor fixes (#703)
* We support OSX now we have conda

* Fixes #697

* Fixes #699

* Only report coverage for automation code
2020-06-26 12:15:04 -07:00
Steven Englehardt 2e522aecc8
v0.10.0 / Firefox 77.0.1 release (#682)
* v0.10.0 release

* Add new section to TOC

* Remove old section from TOC

* Add a note about release cadence

* Ignore python user packages from ~/.local when building env

See: https://github.com/conda/conda/issues/448#issuecomment-195848539

* Fix generated environment

* Pin to localstack 0.11.1 since 0.11.2 seems to be causing issues

* Pinning localstack dependencies as well

* Pinning only  to fix timeouts

* Pinning pyvirtualdisplay due to incompatible interface change

* Add comment to describe new env var

* Pin localstack to 0.11.1.1

* Ignore user site packages in install.sh and for dev dependencies

* Add a troubleshooting note related to 689

* Extend README comment to request feedback
2020-06-22 15:29:44 -07:00
Sarah Bird 022e20a56e
Add link to Dockerfile. 2020-05-18 13:00:34 -05:00
Sarah Bird 708d876b1f Add nice error reporting for xvfb fail
Add it to docker.
update readme.
2020-05-15 16:52:37 -05:00
Sarah Bird 751dd31be3 Move most scripts to scripts directory 2020-05-14 03:08:19 -05:00
Sarah Bird d4a95f6775 Update README 2020-05-14 02:45:44 -05:00
Shubhank Saxena 423fcbebd5 updated docs 2020-05-07 14:39:41 +05:30
Sarah Bird 2f978c4cfb
Restore xvfb (#621)
* Make core changes reinstating Xvfb

* Latest requirements

Added pyvirtualdisplay but running pip-compile caused additional
upgrades.

* Default should not be headless

* Fix flake8

* Revert "Latest requirements"

This reverts commit 36989e963d.

* Manually add only pyvirtualdisplay

* Parametrize test_simple_commands for two display modes.

* flake8

* Rebalance tests

test_[a-d, d-e] and test_c both taking 5 minutes each can be combined.
Other tests hopefully taking ~10 min each.

* Update crawler.py and demo.py

* Add DISPLAY_MODE to sentry

* flake8

* Add extra info about display_modes
2020-05-05 13:43:21 -05:00
Sarah Bird c4b5049e80 Merge branch 'master' into issue_606_upgrade_ff 2020-05-02 18:16:44 -05:00
Sarah Bird bd7abbc123 Update to FF75, including new setting.
Fixes #606
2020-04-10 18:37:44 -05:00
Kainaat Singh b4cc3d7609 Remove support for flash cookie saving 2020-04-03 16:34:19 +05:30
Stefan Zabka 467fe164ef Added type hints to development pointers
Also now autogenerating the ToC and removed trailing
whitespace
2020-03-13 16:14:43 +01:00
vringar f74a660770 Removed Python3.5 support to get type annotated local variables 2020-03-12 00:15:56 +01:00
Stefan Zabka 8150bbbf2f
Added link to matrix to README.md 2020-02-14 12:42:47 +01:00
Steven Englehardt a8a753e45b
Indicate the Python 2 is not supported 2019-11-22 11:17:41 -08:00
englehardt 571fd0ffac Correct documentation on dependency upgrades 2019-11-21 15:42:01 -08:00
Stefan Zabka 3773702c87
Missing # in readme ToC 2019-11-20 20:54:57 +01:00
Stefan Zabka 0be5d9b220
Added Table of Contents 2019-11-20 20:35:53 +01:00
Nihanth Subramanya dd09a8d826
Remove whispers of jpm from README 2019-11-13 10:55:42 +01:00
vringar 492c879b99 moved schema.sql to the DataAggregator directory 2019-11-05 17:12:34 +01:00
Stefan Zabka 5722a0fcd6
Removed one mention of python2 in README.md
Removed it under "Running Measurements from inside the Container" as the instruction wasn't working anymore.
Closes #513
2019-10-25 19:33:24 +02:00
Steven Englehardt 2330f91f95
Make MacOS Docker GUI instructions easier to parse
Fixes #507
2019-10-21 22:06:56 -07:00
englehardt 04e8ef094d Document requirements layering 2019-10-08 14:10:33 -07:00
englehardt 30871ad405 Move to pinned packages. Drop python2 tests 2019-10-08 14:10:33 -07:00
englehardt 089df3b049 Remove stability warning 2019-08-27 15:58:03 -07:00
englehardt 1da176a1fa Add shared memory param to docker README 2019-08-26 15:35:16 -07:00
Fredrik Wollsén 2e99d250a6 Updated docs and codebase in general to use save_content instead of save_all_content and save_javascript 2019-08-14 13:08:58 +03:00
Steven Englehardt 3fe85a3074
Revert docker-compose 2019-08-09 08:15:01 -07:00
Victor Ng c0af6d7401 Updated README to reflect headless mode changes 2019-08-06 11:44:45 -04:00
Victor Ng a54c5c5f3b added a docker-compose.yml (v3) file to simplify the docker image build command. 2019-08-06 11:43:09 -04:00
Fredrik Wollsén ab58317b37 Restore run-on-osx-via-docker.sh 2019-07-07 15:19:26 +03:00
englehardt 040d401ef1 Update documentation and disable another test that relies on profile support 2019-07-01 13:31:22 -07:00
Fredrik Wollsén 3a1e1eb211 Updated docs to reflect the merged instrumentation repo 2019-06-25 11:18:59 +03:00
Fredrik Wollsén 3478c03395 Revert "Moved some files temporarily pending repo merge"
This reverts commit a408495c9f.
2019-06-25 10:53:47 +03:00
Fredrik Wollsén 7e2b026f94 Moved webext-instrumentation into its own directory 2019-06-25 10:53:27 +03:00
Fredrik Wollsén f8c6ef4716 fix: Schema interfaces properly exported in build 2018-10-30 01:56:22 +02:00
Fredrik Wollsén 74b0f1cb64 docs: Add minimal docs about instrumentation to readme 2018-10-30 01:26:44 +02:00