Lock file maintenance (#8116)

.eslintrc

@@ -54,7 +54,10 @@
     "amo/only-log-strings": ["error", {
       "methods": ["fatal", "info", "error", "warn"]
     }],
-    "react/default-props-match-prop-types": "off"
+    "react/default-props-match-prop-types": "off",
+    // This rule is disabled because it outputs a lot of false positives, see:
+    // https://github.com/benmosher/eslint-plugin-import/issues/1343
+    "import/no-cycle": "off"
   },
   "settings": {
     "import/core-modules": [

src/amo/components/Routes/index.js

@@ -62,6 +62,10 @@ type Props = {|
 |};
 
 // If you add a new route here, check that the nginx rules maintained by ops
+//
+// TODO: remove the comment below once
+// https://github.com/yannickcr/eslint-plugin-react/issues/2298 is fixed.
+// eslint-disable-next-line react/prop-types
 const Routes = ({ _config = config }: Props = {}) => (
   <Switch>
     <Route exact path="/:lang/about" component={About} />

src/disco/components/Routes/index.js

@@ -18,6 +18,9 @@ type Props = {|
 export const DISCO_PANE_PATH =
   '/:lang/firefox/discovery/pane/:version/:platform/:compatibilityMode';
 
+// TODO: remove the comment below once
+// https://github.com/yannickcr/eslint-plugin-react/issues/2298 is fixed.
+// eslint-disable-next-line react/prop-types
 const Routes = ({ _config = config }: Props = {}) => (
   <Switch>
     <Route exact path={DISCO_PANE_PATH} component={DiscoPane} />

stories/ui/IconRecommendedBadge.js

@@ -4,6 +4,9 @@ import { storiesOf } from '@storybook/react';
 
 import IconRecommendedBadge from 'ui/components/IconRecommendedBadge';
 
+// TODO: remove the comment below once
+// https://github.com/yannickcr/eslint-plugin-react/issues/2298 is fixed.
+// eslint-disable-next-line react/prop-types
 const render = ({ size = 'large' } = {}) => {
   return <IconRecommendedBadge size={size} />;
 };