Lock file maintenance (#9584)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: William Durand <will+git@drnd.me>

package.json

@@ -325,7 +325,7 @@
     "enzyme": "3.11.0",
     "enzyme-adapter-react-16": "^1.5.0",
     "eslint": "7.9.0",
-    "eslint-config-amo": "^3.0.0",
+    "eslint-config-amo": "^3.6.1",
     "eslint-plugin-amo": "^1.9.1",
     "eslint-plugin-promise": "^4.0.0",
     "file-loader": "^6.0.0",

src/amo/components/AddonsByAuthorsCard/styles.scss

@@ -10,11 +10,11 @@
 
   &.AddonsCard--horizontal {
     // overriding default list styles for theme
-    // stylelint-disable max-nesting-depth
     &.AddonsByAuthorsCard--theme {
       .Card-contents .AddonsCard-list {
         display: block;
 
+        // stylelint-disable max-nesting-depth
         @include respond-to(medium) {
           display: grid;
         }

src/amo/components/App/styles.scss

@@ -17,6 +17,7 @@ textarea {
 
   // Fix search input and possibly other inputs.
   // See https://github.com/mozilla/addons-frontend/issues/3640
+
   background: $white;
   border: 1px solid $grey-50;
   border-radius: $border-radius-xs;
@@ -33,6 +34,7 @@ textarea {
   box-sizing: inherit;
   // We use `anywhere` instead of `break-word` so that it works even when the
   // container does not have a well-defined width.
+
   overflow-wrap: anywhere;
 }
 

src/amo/components/Categories/styles.scss

@@ -49,6 +49,7 @@
 
 // There are currently 12 colors and this number must be kept in sync with
 // `$category-colors` in `src/ui/css/vars.scss`.
+
 @for $i from 1 through 12 {
   .Categories--category-color-#{$i} {
     background: nth($category-colors, $i);

src/amo/components/CategoryIcon/styles.scss

@@ -24,6 +24,7 @@ $default-icon-size: 64px;
 
 // There are currently 12 colors and this number must be kept in sync with
 // `$category-colors` in `src/ui/css/vars.scss`.
+
 @for $i from 1 through 12 {
   .CategoryIcon-#{$i} {
     background-color: nth($category-colors, $i);

src/amo/components/CollectionAddAddon/styles.scss

@@ -50,8 +50,8 @@
     border-bottom-right-radius: 0;
   }
 
-  // The Notice component creates children which are affected by these classes,
-  // which are added by the CSSTransition component.
+  // The Notice component creates children which are affected by these
+  // classes, which are added by the CSSTransition component.
   .Notice {
     &.CollectionAddAddon-noticePlaceholder-transition-appear {
       opacity: 1;

src/amo/components/CollectionManager/styles.scss

@@ -29,6 +29,7 @@
 .CollectionManager-slug {
   // Always render the grid left-to-right. This UI involves a URL so
   // it should always be displayed left-to-right.
+
   direction: ltr;
   display: grid;
   grid-template-columns: 40% 60%;

src/amo/components/Search/styles.scss

@@ -45,6 +45,7 @@
       min-width: 0;
       // Hack to force column height calculations in ESR 52.
       // See: https://github.com/mozilla/addons/issues/566
+
       width: 100%;
 
       .SearchResult {

src/amo/components/SearchSuggestion/styles.scss

@@ -21,6 +21,7 @@
   height: 16px;
   // To handle 404 images, image width is very small so alt text distorts UI
   // https://github.com/mozilla/addons-frontend/issues/4009
+
   overflow: hidden;
   width: 16px;
 

src/amo/pages/Addon/styles.scss

@@ -143,6 +143,7 @@
       grid-column: 2;
       // This span makes sure the left widget does not move vertically when
       // there is a long description.
+
       grid-row: 1 / span 100000;
       // Fixes screenshot overflow in FF 52 ESR.
       max-width: 100%;
@@ -162,6 +163,7 @@
   .Addon-screenshots {
     // overflow required to fix content overlap in Safari.
     // See https://github.com/mozilla/addons-frontend/issues/2847
+
     overflow-x: hidden;
   }
 

src/amo/pages/AddonReviewList/styles.scss

@@ -50,6 +50,7 @@
   flex-grow: 1;
   // This creates vertical space when items are wrapped on very
   // small-width screens.
+
   line-height: 36px;
   margin: auto;
 

src/core/css/inc/mixins.scss

@@ -3,6 +3,7 @@
 @mixin page-padding() {
   // This adds consistent padding to any top-level page component.
   // The top padding is zero to make room for the shared app banner.
+
   padding: $padding-page;
   padding-top: 0;
 

src/ui/components/Button/styles.scss

@@ -78,9 +78,9 @@ $default-font-size: 13px;
         padding-top: 1px;
       }
 
-      // Small text is difficult to read against the bright Photon colors since
-      // it is blurry. This isn't (yet) part of the spec but added this because
-      // it improves accessibility. See:
+      // Small text is difficult to read against the bright Photon colors
+      // since it is blurry. This isn't (yet) part of the spec but added this
+      // because it improves accessibility. See:
       // https://github.com/FirefoxUX/photon/issues/264#issuecomment-364927535
       letter-spacing: 0.01rem;
     }
@@ -94,12 +94,13 @@ $default-font-size: 13px;
 
     &:active:not(.Button--disabled) {
       background: $background-active;
-      // This is not part of the Photon button spec, but without it only colour
-      // is changed onClick of a button. Even as someone without colourblindness
-      // I find this to be so subtle as to sometimes not notice. I'd think
-      // colourblind users may not notice the mild colour shift in the button
-      // as the only indicator that it was pressed, so I added this. - @tofumatt
-      // See: https://github.com/FirefoxUX/photon/issues/265
+      // This is not part of the Photon button spec, but without it only color
+      // is changed onClick of a button. Even as someone without
+      // colourblindness I find this to be so subtle as to sometimes not
+      // notice. I'd think colourblind users may not notice the mild colour
+      // shift in the button as the only indicator that it was pressed, so I
+      // added this. - @tofumatt See:
+      // https://github.com/FirefoxUX/photon/issues/265
       padding-top: 1px;
     }
   }

src/ui/components/DismissibleTextForm/styles.scss

@@ -29,8 +29,9 @@
 
 .DismissibleTextForm-textarea {
   margin: 0 auto;
-  // The max height ensures that the textarea won't expand beyond 600 characters
-  // and instead shows a scrollbar
+  // The max height ensures that the textarea won't expand beyond 600
+  // characters and instead shows a scrollbar
+
   max-height: 230px;
   // This is the height of two lines of text. Often the placeholder text
   // will span two lines–because this element will grow/shrink based on

src/ui/components/DropdownMenuItem/styles.scss

@@ -40,6 +40,7 @@
 
     // We override the opacity because the default value in the `disabled()`
     // mixin makes the text hard to read.
+
     opacity: 0.8;
   }
 }

src/ui/components/Icon/styles.scss

@@ -196,6 +196,7 @@
 .Icon-inline-content {
   // An Icon with inline content (such as an SVG)
   // does not need a background image.
+
   background: none;
 }
 

src/ui/components/Notice/styles.scss

@@ -48,6 +48,7 @@
 .Notice-light .Notice-icon {
   // Reduce the icon size for light notices so that the total
   // height of the notice adds up to $default-line-height.
+
   background-size: 11px 11px;
   height: 11px;
   width: 11px;
@@ -91,6 +92,7 @@
     &:active:not(.Button--disabled) {
       // The default styles add padding-top: 1px so this keeps it in
       // sync with the custom padding added above.
+
       padding-top: 7px;
     }
   }
@@ -165,6 +167,7 @@
   &.Notice-againstGrey20 {
     // When this Notice is rendered against a $grey-20 background, pick a
     // new background color to avoid a collision.
+
     background-color: $grey-30;
   }
 

src/ui/components/Rating/styles.scss

@@ -99,6 +99,7 @@ $icon-small: 13px;
     animation-name: pulseOpaqueRatingStars;
     // Ensure editable rating stars always render as open stars while
     // loading, even if some are selected (e.g. while hovering).
+
     cursor: initial;
   }
 }

src/ui/components/Switch/styles.scss

@@ -158,6 +158,7 @@ $installStripeColor2: #00c42e;
     );
     // Reverse the stripe direction without
     // impacting the animation speed.
+
     transform: scaleX(-1);
   }
 

src/ui/components/TooltipMenu/styles.scss

@@ -34,6 +34,7 @@
   width: 8px;
   // Since it has a box shadow, make sure the element appears underneath
   // TooltipMenu-list.
+
   z-index: 1;
 }
 

stories/setup/styles.scss

@@ -4,6 +4,7 @@ html,
 body {
   // This overrides the App background style which makes it hard to see
   // in storybook.
+
   background: #fff;
   margin: 0;
   // Giving extra cushion so nothing gets covered.

tests/unit/amo/components/TestAddonsByAuthorsCard.js

@@ -668,7 +668,7 @@ describe(__filename, () => {
     );
   });
 
-  it('shows extensions in header for a static theme with multiple authors and without More text ', () => {
+  it('shows extensions in header for a static theme with multiple authors and without More text', () => {
     const root = renderAddonsWithType({
       addonType: ADDON_TYPE_STATIC_THEME,
       showMore: false,

tests/unit/amo/components/TestRatingsByStar.js

@@ -160,7 +160,7 @@ describe(__filename, () => {
       expect(link).toHaveProp('title', expectedTitle);
     }
 
-    it.each([[counts], [bars]], (links) => {
+    [counts, bars].forEach((links) => {
       validateLink(links.at(0), '5', 'Read all five-star reviews');
       validateLink(links.at(1), '4', 'Read all four-star reviews');
       validateLink(links.at(2), '3', 'Read all three-star reviews');

tests/unit/amo/reducers/test_addonsByAuthors.js

@@ -742,7 +742,7 @@ describe(__filename, () => {
       ]);
     });
 
-    it("returns static themes when filtering for authors' themes ", () => {
+    it("returns static themes when filtering for authors' themes", () => {
       const addons = fakeExternalAddons({ type: ADDON_TYPE_STATIC_THEME });
 
       const authorIds = [

tests/unit/core/components/TestServerHtml.js

@@ -136,7 +136,7 @@ describe(__filename, () => {
     );
   });
 
-  it('renders meta with utf8 charset ', () => {
+  it('renders meta with utf8 charset', () => {
     const root = render();
     const meta = root.find({ charSet: 'utf-8' });
 

tests/unit/core/i18n/test_utils.js

@@ -102,7 +102,7 @@ describe(__filename, () => {
   });
 
   describe('sanitizeLanguage()', () => {
-    it('should get a standard language ', () => {
+    it('should get a standard language', () => {
       expect(utils.sanitizeLanguage('ar')).toEqual('ar');
     });
 

tests/unit/core/reducers/test_infoDialog.js

@@ -31,7 +31,7 @@ describe(__filename, () => {
     expect(infoDialog(state, { type: 'WHATEVS' })).toEqual(state);
   });
 
-  it('hides a dialog with CLOSE_INFO ', () => {
+  it('hides a dialog with CLOSE_INFO', () => {
     const payload = getInfoDialogData();
     const prevState = infoDialog(undefined, showInfoDialog(payload));
 

tests/unit/core/server/test_base.js

@@ -422,7 +422,7 @@ describe(__filename, () => {
       expect(getCurrentUser(reduxStoreState.users)).toMatchObject(user);
     });
 
-    it('it serializes the redux state in html', async () => {
+    it('serializes the redux state in html', async () => {
       const user = createUserAccountResponse({ id: 42, username: 'babar' });
 
       mockUsersApi

tests/unit/ui/components/TestIconStar.js

@@ -45,7 +45,7 @@ describe(__filename, () => {
     expect(star.find('path')).toHaveProp('d', getSvgPath(DIM_CLOSED_STYLE));
   });
 
-  it("sets the star style to OPEN_STYLE if the star is not selected and it's not readOnly ", () => {
+  it("sets the star style to OPEN_STYLE if the star is not selected and it's not readOnly", () => {
     const star = shallow(<IconStar readOnly={false} selected={false} />);
 
     expect(star.find('g')).toHaveProp('fillOpacity', 1);