Bump Node.js to 18.x, start testing with 20.x (#12531)

* Bump Node.js to 18.x, start testing with 20.x

* defaults-next image should be cimg/node:20.9, not 20.09

* Relax expectation in test

* Update target python version for dennis now that the base image has been updated

.circleci/config.yml

@@ -14,17 +14,17 @@ references:
     working_directory: ~/addons-frontend
     docker:
       # This is the NodeJS version we run in production.
-      - image: cimg/node:16.19
+      - image: cimg/node:18.18
 
   defaults-next: &defaults-next
     working_directory: ~/addons-frontend
     docker:
       # This is the next NodeJS version we will support.
-      - image: cimg/node:18.12
+      - image: cimg/node:20.9
 
   defaults-release: &defaults-release
     machine:
-      image: ubuntu-2004:202201-02
+      image: ubuntu-2004:2023.10.1
     working_directory: ~/addons-frontend
 
   restore_build_cache: &restore_build_cache
@@ -203,7 +203,7 @@ jobs:
     <<: *defaults-release
     steps:
       - better_checkout
-      - run: pyenv global 3.10.2
+      - run: pyenv global 3.11
       - run: pip install tox
       - run: TOXENV=dennis-lint tox
 

Dockerfile

@@ -1,7 +1,7 @@
 #
 # Build
 #
-FROM node:16-slim AS builder
+FROM node:18-slim AS builder
 
 WORKDIR /srv/node
 COPY package.json yarn.lock /srv/node/
@@ -11,7 +11,7 @@ RUN yarn install --pure-lockfile
 #
 # Install
 #
-FROM node:16-slim
+FROM node:18-slim
 
 ARG app_uid=9500
 ARG app_dir=/app

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "private": true,
   "engines": {
-    "node": ">=16.17"
+    "node": ">=18.18"
   },
   "scripts": {
     "build": "npm run clean && better-npm-run build",

tests/pino-mozlog/test_index.js

@@ -55,7 +55,7 @@ describe(__filename, () => {
       expect(_console.error).toHaveBeenCalledWith(
         '[pino-mozlog] could not parse:',
         {
-          error: 'SyntaxError: Unexpected token o in JSON at position 1',
+          error: expect.stringContaining('SyntaxError: Unexpected token'),
           data,
         },
       );