* Fix width of site noticed and error messages on home page without new hero
* Fix issue with too-wide error message on home page with new promo
* Address review comments
* Create loading skeleton for hero shelves
* Adjust some styles to make the skeletons closer to the actual elements
* Address review comments
* Address final review comments
* Create a RecommendedBadge component
* Update story and add RTL support
* Add target="_blank"
* Add icon and attempt to style
* Fix version of storybook-addon-rtl
* fix lint
* Fix test
* Address review comments
* Update hover text
* fix lint
* Make normal and hover colors more different from one another
fixes#7378
~~So I readded IconStar here so it could be set up in storybook. Although, we will officially turn this on in AMO in #7365 (hopefully).~~
I've also added the `Rating` ~~and `RatingsByStar`~~ component~~s here too~~ so you can see the 5 star set up and we'll be able to see the changes with the new PR as these files will be updated in that PR as well.
note: while I do like the props grid, since the props are shown in the Component's variations page, maybe this is enough. Especially since the props (with flow and now with HOCs too it seems) aren't always working :/ For now tho, I just commented this out where it wasn't working properly: on Ratings and the RatingsByStar components.
also, I would recommend looking into using this plugin again:
https://github.com/evgenykochetkov/react-storybook-addon-props-combinations
It was suggested at 1 point by someone and I think it may be easier to use than manually doing all the use cases/mixes of props as we have to do now.
fixes#6159
I personally like chapters over the combinations in that it was a bit more flexible, so I am using that here.
I followed the design that came up [here](https://github.com/mozilla/addons-frontend/pull/6060#discussion_r215322058) as I really like that : )
Of course can tweak it as needed...
Also not sure how you think Button looks - in that it's all one 1 page..? or do you think each type deserves its own page? We can move that too but I thought in this case anyway it made more sense to leave on the 1 page.
note: I haven't added proptypes or source here but I think we can. The styling didn't look super nice so I left it off for now.
notes/questions:
I really liked the knobs interface which can easily change out the props but for some reason I wasn't sure if this would work well with Percy(?):
https://www.npmjs.com/package/@storybook/addon-knobs
I haven't looked into Percy yet tho so for now I will leave this : )
Storybook version:
Using v3 / stable version
4 is in alpha (I haven’t really looked into this)
Where to eventually publish to:
GitHub pages, Heroku?
Percy (for snapshots):
https://docs.percy.io/docs/storybook-for-react
If we end up keeping similar setup, will work with this?
Specifically - will knobs addon work with Percy?
Show additional/helpful information?
Do we want to show source?
Do we want to show propType info*?
* Note: with flow props, this is still TBD how to be done
Regarding the structure, I thought about moving these inside the src directory but leave as is for now.
Bob Silverberg
William Durand
renovate[bot]
Kumar McMillan
renovate[bot]
Rebecca Mullin