From 46d3fc04d293e14ac3052c0affa0c69d5d7b82c1 Mon Sep 17 00:00:00 2001 From: Gregory Koberger Date: Tue, 12 Apr 2011 18:24:44 -0700 Subject: [PATCH] Error because of dummy :disabled inputs (bug 646096) --- apps/editors/templates/editors/review.html | 1 - media/js/zamboni/editors.js | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/editors/templates/editors/review.html b/apps/editors/templates/editors/review.html index db2edf6aae..e7d08e9d49 100644 --- a/apps/editors/templates/editors/review.html +++ b/apps/editors/templates/editors/review.html @@ -139,7 +139,6 @@ {{ label }} -
  • {% endfor %} diff --git a/media/js/zamboni/editors.js b/media/js/zamboni/editors.js index f824ac1f72..03d1e7aafa 100644 --- a/media/js/zamboni/editors.js +++ b/media/js/zamboni/editors.js @@ -87,7 +87,9 @@ function initReviewActions() { function toggle_input(){ var $files_checked = $files_input.filter(':checked'); $('.review-actions-save input').attr('disabled', $files_checked.length < 1); - $('#review-actions-files-warning').toggle($files_checked.filter(':enabled').length > 1); + + // If it's not :visible, we can assume it's been replaced with a dummy :disabled input + $('#review-actions-files-warning').toggle($files_checked.filter(':enabled:visible').length > 1); } $files_input.change(toggle_input).each(toggle_input);