From 8dfcb555dcd31a55f7bcbf811a371023d0b97fd0 Mon Sep 17 00:00:00 2001
From: Mathieu Pillard <diox@users.noreply.github.com>
Date: Thu, 20 Jul 2023 15:33:32 +0200
Subject: [PATCH] Fix standalone validator - the upload JS code requires
 theme_specific to be present (#21028)

---
 src/olympia/devhub/templates/devhub/validate_addon.html | 1 +
 src/olympia/devhub/tests/test_views_validation.py       | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/src/olympia/devhub/templates/devhub/validate_addon.html b/src/olympia/devhub/templates/devhub/validate_addon.html
index 90756963a3..c8d47ceda5 100644
--- a/src/olympia/devhub/templates/devhub/validate_addon.html
+++ b/src/olympia/devhub/templates/devhub/validate_addon.html
@@ -22,6 +22,7 @@
       <label>{{ _('Do you want your add-on to be distributed on this site?') }}</label>
       {{ new_addon_form.channel }}
     </div>
+    <input type="hidden" id="id_theme_specific" name="theme_specific" value="false" />
     <input type="file" id="upload-addon"
       data-upload-url="{{ url('devhub.standalone_upload') }}"
       data-upload-url-listed="{{ url('devhub.standalone_upload') }}"
diff --git a/src/olympia/devhub/tests/test_views_validation.py b/src/olympia/devhub/tests/test_views_validation.py
index fa31ca594e..965bf09023 100644
--- a/src/olympia/devhub/tests/test_views_validation.py
+++ b/src/olympia/devhub/tests/test_views_validation.py
@@ -414,6 +414,9 @@ class TestValidateAddon(TestCase):
         assert b'this tool only works with legacy' not in response.content
 
         doc = pq(response.content)
+
+        assert doc('#id_theme_specific').attr('value') == 'false'
+
         assert doc('#upload-addon').attr('data-upload-url') == (
             reverse('devhub.standalone_upload')
         )