fix reviewer tab css regressions, remove menupicker (bug 847330)

This commit is contained in:
Kevin Ngo 2013-03-04 19:09:55 -08:00
Родитель 81b990883a
Коммит ab4abfd085
5 изменённых файлов: 23 добавлений и 131 удалений

Просмотреть файл

@ -1,72 +0,0 @@
@import '../devreg/lib';
#menupicker {
position: absolute;
display: none;
// Paper covers rock.
z-index: 1010;
background: rgba(0,0,0,.7);
height: 100%;
width: 100%;
top: 0;
left: 0;
* {
.border-box;
}
.menucontent {
position: absolute;
bottom: 70px;
padding: 10px 25px;
overflow-y: auto;
max-height: 338px;
li {
width: 270px;
margin-bottom: 10px;
a {
display: block;
background-color: #4e4e4e;
line-height: 38px;
color: #fff;
border: 1px solid #2f2e2f;
padding: 0 15px;
font-weight: bold;
border-radius: 2px;
&:active {
background-color: #0ac;
color: #333;
}
}
}
}
h1 {
color: #fff;
line-height: 38px;
border-bottom: 1px solid #6f6f6f;
padding: 33px 30px 0;
box-shadow: 0 1px 1px #242424;
font-weight: bold;
font-size: 13px;
}
footer {
position: absolute;
bottom: 0;
border-top: 1px solid #2d2d2d;
padding: 14px;
width: 100%;
a {
border-radius: 2px;
display: block;
line-height: 40px;
font-size: 14px;
font-weight: 600;
text-align: center;
color: #333;
.gradient-two-color(#fbfbfb, #ccc);
}
}
}
// When the body is overlayed it shouldn't stretch. Giggity.
.pickerized {
overflow: hidden;
}

Просмотреть файл

@ -265,16 +265,19 @@ table.data-grid .addon-version-notes a {
text-align: right;
}
.tabnav a {
border-radius: 5px 5px 0 0;
background-color: @taupe;
border: 1px solid transparent;
border-bottom: 0;
font-weight: bold;
color: @medium-gray;
display: inline-block;
padding: 10px 15px 20px;
text-decoration: none;
#page ul.tabnav {
padding: 0;
a {
border-radius: 5px 5px 0 0;
background-color: @taupe;
border: 1px solid transparent;
border-bottom: 0;
font-weight: bold;
color: @medium-gray;
display: inline-block;
padding: 10px 15px 20px;
text-decoration: none;
}
}
/* Home */
@ -1203,7 +1206,7 @@ iframe#manifest-contents {
#wrap {
padding: 10px 0 0;
}
.tabnav {
ul.tabnav {
li {
display: none;
&.selected {
@ -1473,9 +1476,13 @@ iframe#manifest-contents {
overflow-x: auto;
overflow-y: hidden;
}
.tabnav {
#page ul.tabnav {
li {
margin: 0 1px;
position: relative;
a {
padding: 10px 15px 15px;
}
}
&+ .island {
.border-box;

Просмотреть файл

@ -1,41 +0,0 @@
/*
* .menutrigger triggers this overlay.
* .menucontent is the ul containing the menu items. This node should have
* a data-title="Title of Menu".
*
* TODO: Extend this to iterate over all menufiable DOM elms.
*/
(function() {
var $body = $('body'),
$overlay = $('<section id="menupicker"></section>');
// This JS is only relevant to mobile.
if (!$body.hasClass('mobile')) return;
function dismiss(e) {
$overlay.hide();
$body.removeClass('pickerized');
e.preventDefault();
}
function show(e) {
$body.addClass('pickerized');
$overlay.show();
e.preventDefault();
}
(function() {
var $oldmenu = $('.menucontent').detach(),
$title = $('<h1>' + $oldmenu.data('title') + '</h1>'),
$footer = $('<footer><a href="#">' + gettext('Cancel') + '</a></footer>');
$overlay.append($title);
$overlay.append($oldmenu);
$footer.find('a').click(dismiss);
$overlay.append($footer);
$body.append($overlay);
})();
// Change click to touch.
$('.menutrigger').click(show);
})();

Просмотреть файл

@ -79,7 +79,6 @@ CSS = {
'css/devreg/themes_review.less',
'css/devreg/legacy-paginator.less',
'css/devreg/files.less',
'css/devreg/menupicker.less',
),
'mkt/splash': (
'css/mkt/splash.less',
@ -305,7 +304,6 @@ JS = {
'js/zamboni/storage.js',
'js/zamboni/editors.js',
'js/mkt/reviewers.js',
'js/devreg/menupicker.js',
'js/devreg/expandable.js',
'js/devreg/mobile_review_actions.js',
'js/devreg/reviewers_init.js',

Просмотреть файл

@ -7,9 +7,9 @@
{% block content %}
{% if waffle.switch('reviewer-incentive-points') %}
<section id="reviewers-score-bar" class="island full c">
{{ reviewers_score_bar() }}
</section>
<section id="reviewers-score-bar" class="island full c">
{{ reviewers_score_bar() }}
</section>
{% endif %}
<div class="mobile-queue-search">
@ -30,7 +30,7 @@
<ul class="tabnav">
{% for prefix, this, loc, text in queue_tabnav() %}
<li class="{% if tab == this %}selected{% endif %}">
<li{% if tab == this %} class="selected"{% endif %}>
<a href="{{ url('reviewers.%s.%s' % (prefix, loc)) }}">{{ text }}</a>
<div class="tabnav-sprite hidden"></div>
</li>