check filename properly (bug #651800)

apps/files/helpers.py

@@ -108,9 +108,9 @@ class FileViewer:
             elif minor in ['xml', 'rdf+xml', 'javascript', 'x-javascript',
                            'xml-dtd', 'vnd.mozilla.xul+xml']:
                 return False
-        elif os.path.splitext(filename)[1] in ['.dtd', '.xul', '.properties',
-                                               '.src', '.mf', '.sf', '.json',
-                                               '.manifest']:
+        if os.path.splitext(filename)[1] in ['.dtd', '.xul', '.properties',
+                                             '.src', '.mf', '.sf', '.json',
+                                             '.manifest']:
             return False
         return True
 

apps/files/tests/test_helpers.py

@@ -66,7 +66,7 @@ class TestFileHelper(test_utils.TestCase):
         binary = self.viewer.is_binary
         for f in ['foo.rdf', 'foo.xml', 'foo.js', 'foo.py'
                   'foo.html', 'foo.txt', 'foo.dtd', 'foo.xul',
-                  'foo.properties', 'foo.json']:
+                  'foo.properties', 'foo.json', 'foo.src']:
             m, encoding = mimetypes.guess_type(f)
             assert not binary(m, f), '%s should not be binary' % f