filter by users on impala extensions listing (bug 674763)

apps/amo/templates/amo/side_nav.html

@@ -1,6 +1,6 @@
 {% set extras = (
     ('featured', _('Featured')),
-    ('popular', _('Most Popular')),
+    ('users', _('Most Popular')),
     ('rating', _('Top Rated')),
 ) %}
 <nav id="side-nav" class="c">

apps/browse/templates/browse/impala/category_landing.html

@@ -3,9 +3,9 @@
 {% set addon_sets = filter.all() %}
 
 {% set src_dict = {'featured': 'featured',
-               'created': 'recentlyadded',
-               'users': 'mostpopular',
-               'rating': 'toprated'} %}
+                   'created': 'recentlyadded',
+                   'users': 'mostpopular',
+                   'rating': 'toprated'} %}
 
 {% block bodyclass %}category-landing{% endblock %}
 

apps/browse/templates/browse/impala/extensions.html

@@ -8,7 +8,7 @@
 
 {% set extras = (
     ('featured', _('Featured')),
-    ('popular', _('Most Popular')),
+    ('users', _('Most Popular')),
     ('rating', _('Top Rated')),
     ('updated', _('Last Updated')),
 ) %}
@@ -19,7 +19,7 @@
     <header>
       {% with heading = {'featured': _('Featured Extensions'),
                          'created': _('Newest Extensions'),
-                         'popular': _('Most Popular Extensions'),
+                         'users': _('Most Popular Extensions'),
                          'rating': _('Top Rated Extensions'),
                          'updated': _('Last Updated Extensions')}[sorting] %}
         <h2>{{ category.name if category else heading }}</h2>

apps/browse/views.py

@@ -160,7 +160,8 @@ def _extensions(request, category=None, is_impala=False, template=None):
         return category_landing(request, category, is_impala)
 
     addons, filter = addon_listing(request, [TYPE],
-        ImpalaAddonFilter if is_impala else AddonFilter)
+        ImpalaAddonFilter if is_impala else AddonFilter,
+        'users' if is_impala else 'popular')
 
     if category:
         addons = addons.filter(categories__id=category.id)

media/css/impala/site.less

@@ -194,7 +194,7 @@ a {
 }
 
 .s-featured #side-nav .s-featured a,
-.s-popular #side-nav .s-popular a,
+.s-users #side-nav .s-users a,
 .s-rating #side-nav .s-rating a,
 .s-created #side-nav .s-created a {
     background: #ecf5fe;
@@ -202,7 +202,7 @@ a {
     font-weight: bold;
 }
 .s-featured #side-nav .s-featured a:after,
-.s-popular #side-nav .s-popular a:after,
+.s-users #side-nav .s-users a:after,
 .s-rating #side-nav .s-rating a:after,
 .s-created #side-nav .s-created a:after {
     color: inherit;