Send download_url to the scanners (#12317)

docker-compose.private.yml

@@ -1,7 +1,7 @@
 version: "2.3"
 
 services:
-  web:
+  worker:
     depends_on:
       - customs
       - wat
@@ -9,7 +9,21 @@ services:
   customs:
     build:
       context: ./private/addons-customs-scanner
+    environment:
+      - ALLOWED_ORIGIN=http://olympia.test
+      - PORT=10101
+    links:
+      - "nginx:olympia.test"
+    depends_on:
+      - web
 
   wat:
     build:
       context: ./private/addons-wat
+    environment:
+      - ALLOWED_ORIGIN=http://olympia.test
+      - PORT=10102
+    links:
+      - "nginx:olympia.test"
+    depends_on:
+      - web

src/olympia/scanners/tasks.py

@@ -33,22 +33,27 @@ def run_scanner(upload_pk, scanner, api_url, api_key):
 
     try:
         if not os.path.exists(upload.path):
-            raise ValueError('Path "{}" is not a file or directory or does '
+            raise ValueError('File "{}" does not exist.' .format(upload.path))
-                             'not exist.' .format(upload.path))
 
         result = ScannersResult()
         result.upload = upload
         result.scanner = scanner
 
         with statsd.timer('devhub.{}'.format(scanner_name)):
-            headers = {'Authorization': 'Bearer {}'.format(api_key)}
+            json_payload = {
-            with open(upload.path, 'rb') as xpi:
+                'api_key': api_key,
-                response = requests.post(url=api_url,
+                'download_url': upload.get_authenticated_download_url(),
-                                         files={'xpi': xpi},
+            }
-                                         headers=headers,
+            response = requests.post(url=api_url,
-                                         timeout=settings.SCANNER_TIMEOUT)
+                                     json=json_payload,
+                                     timeout=settings.SCANNER_TIMEOUT)
+
+        try:
+            results = response.json()
+        except ValueError:
+            # Log the response body when JSON decoding has failed.
+            raise ValueError(response.text)
 
-        results = response.json()
         if 'error' in results:
             raise ValueError(results)
 

src/olympia/scanners/tests/test_tasks.py

@@ -52,8 +52,10 @@ class TestRunScanner(UploadTest, TestCase):
         assert requests_mock.called
         requests_mock.assert_called_with(
             url=self.API_URL,
-            files={'xpi': mock.ANY},
+            json={
-            headers={'Authorization': 'Bearer {}'.format(self.API_KEY)},
+                'api_key': self.API_KEY,
+                'download_url': upload.get_authenticated_download_url(),
+            },
             timeout=123
         )
         result = ScannersResult.objects.all()[0]