0c577c01a1
Update Licenses available for add-on developers to choose from on AMO ( #22818 )
2024-11-20 21:14:23 +01:00
b3e55e775a
add basic page to proceed/escalate held actions ( #22822 )
...
* add basic page to proceed/escalate held actions
* drop match default case
* held_action_review -> decision_review
2024-11-20 13:16:30 +00:00
cacd8e302c
allow unsigned versions to be flagged for NHR ( #22857 )
2024-11-19 12:56:04 +00:00
aa342d1cc1
Ensure enable-submissions Disabling Correctly Allows Bypassing ( #22834 )
2024-11-18 09:42:59 -05:00
4d0a7a2903
Remove time inefficient loop in not_blocked_items ( #22862 )
...
Remove test
Revert reuse of reusable function
2024-11-18 14:31:57 +01:00
ed0cce2628
More efficient diff function removing quadratic iterable ( #22859 )
...
* More efficient diff function removing quadratic iterable
* fix format
2024-11-15 16:23:06 +01:00
10f9ec6f9c
report appeals for extensions to a different queue ( #22851 )
2024-11-14 16:31:50 +00:00
9598345b3b
Restrict the /64 for IPv6 when adding an automatic IP restriction from a scanner action ( #22853 )
2024-11-14 17:04:46 +01:00
27be5825ce
Use the correct waffle switch name for soft-blocking ( #22852 )
2024-11-14 10:48:58 +01:00
ce66a9f652
Generate and write stash including soft blocked versions ( #22826 )
...
* Generate stash including soft blocked versions
Update src/olympia/blocklist/mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Simplify the test comment
Add waffle switch controlling stash
link explicitly to soft blocking
Better comment
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Apply suggestions from code review
Co-authored-by: William Durand <will+git@drnd.me>
Update src/olympia/blocklist/mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
Apply suggestions from code review
Co-authored-by: William Durand <will+git@drnd.me>
* Add invalid cache json to cron test
---------
Co-authored-by: William Durand <will+git@drnd.me>
2024-11-13 18:13:29 +01:00
368cf96cb6
Add soft block waffle switch ( #22844 )
2024-11-13 15:41:54 +01:00
9ac9c76c7b
Fallback to empty list when block type is not present ( #22846 )
...
* Revert "Revert "Fallback to empty list when block type is not present on cache.json""
This reverts commit 2bd0783eb5
2024-11-13 15:33:03 +01:00
f26254d3f6
Revert "Fallback to empty list when block type is not present on cache.json" ( #22845 )
2024-11-13 12:02:00 +01:00
97105111c3
Fallback to empty list when block type is not present on cache.json
2024-11-13 11:28:34 +01:00
2a1eb8b1c5
Add ability to harden / soften blocks in the admin ( #22827 )
...
* Add ability to harden / soften blocks in the admin
* Use extended-choices for BlocklistSubmission ACTIONS and SIGNOFF_STATES
2024-11-13 10:55:00 +01:00
b3d0a224f1
Sync storage with make up flow ( #22805 )
...
* Sync storage with make up flow
* data_load should clean storage directory
2024-11-12 16:32:27 +01:00
5846124034
Split diff by block type ( #22830 )
...
* Split diff by block type
* Remove unecessary and redundant code
* Fix ordering of cache/stash + increase validity of tests
* Update src/olympia/blocklist/tests/test_mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
* Update src/olympia/blocklist/mlbf.py
Co-authored-by: William Durand <will+git@drnd.me>
---------
Co-authored-by: William Durand <will+git@drnd.me>
2024-11-12 10:44:36 +01:00
8697f7a761
Add add-on created datetime as a column to the content review queue ( #22833 )
2024-11-11 17:31:08 +01:00
e4edcab861
process override decision payloads from webhook without cinder job ( #22829 )
2024-11-08 11:28:20 +00:00
e19b438c47
Record version rejections triggered by a block as a human review ( #22817 )
...
* Record version rejections triggered by a block as a human review
The user that last updated the block should be the user set on the
corresponding activity.
2024-11-07 17:50:42 +01:00
be5a368fe6
Add command to delete erroneously added overgrowth NeedsHumanReview & reset due dates ( #22832 )
...
* Add command to delete erroneously added overgrowth NeedsHumanReview & reset due dates
* Add route
2024-11-07 14:45:57 +01:00
da0d02c7d9
Don't fail when displaying IPv6 and IPv4 together in the admin ( #22820 )
2024-11-06 17:47:00 +01:00
baa72e6d40
Add soft_blocked_items to MLBF data store ( #22715 )
...
* Add soft_blocked_items to mlbf data store
* Fix non-backward compatible reference to cache.json properties
* Hoist import of Version to top of file
2024-11-06 15:18:16 +01:00
9709925cd1
Explicit Option to Remove Uploaded Pastebin File ( #22814 )
2024-11-05 13:16:52 -05:00
f8539f2756
Update reviewer tools rejection action explanation label ( #22824 )
2024-11-05 16:29:53 +01:00
6d7474eac5
Migrate from BlockVersion.soft to BlockVersion.block_type ( #22811 )
...
This patch does the following:
- Introduce `PositiveTinyIntegerField` to support `tinyint unsigned` fields
- Rename `soft` to `block_type` via 2 separate migrations (add + remove)
- Introduce `BlockType` enum and use it instead of the `soft` boolean
- Unify the string versions of enum values
2024-11-05 11:59:13 +01:00
f4da852e56
Filter reused guid:version strings from not blocked items in mlbf ( #22812 )
2024-11-01 11:21:37 +01:00
7375f1e933
Modify Button Behaviour When enable-submissions Flag is Disabled ( #22779 )
2024-10-31 09:40:48 -04:00
11b2edd39d
Relax parsing of IP networks coming from the database ( #22806 )
...
Even if technically the bits corresponding to the netmask should
be set to 0, in practice it's fine to accept that they are not,
it will result in the same network.
2024-10-30 12:27:01 +01:00
97fe21c536
Allow adding, viewing information about and deleting soft-blocks in the admin ( #22765 )
...
* Allow adding, viewing information about and deleting soft-blocks in the admin
Like other blocklist operations, it goes through a BlocklistSubmission, which
gains a new "block_type" field to determine what kind of block to apply for
this particular submission.
Note: If a version is already soft-blocked or hard-blocked, that version won't
be selectable when creating a new BlocklistSubmission, even of another type.
Future actions will be added to soften or harden blocks.
2024-10-29 18:49:20 +01:00
da6aed51e2
record queue move notes; expose in reviewer tools ( #22799 )
2024-10-29 17:29:55 +00:00
fede70f813
Respond to cinder moving a job into the amo handled queue ( #22795 )
...
* Respond to cinder moving a job into the amo handled queue
* verify payload is non-empty dict before processing cinder webhook
2024-10-28 16:43:13 +00:00
7e4a68a3e6
set CinderDecision.action_date before sending emails ( #22798 )
2024-10-28 15:23:33 +00:00
6628df7d22
add a queue for decision actions that are held ( #22788 )
...
* rename utils/CinderAction* to actions/ContentAction*
* CinderDecision to ContentDecison
* Add a basic admin to view ContentDecisions
* Add basic queue to show decisions where action has been held
2024-10-28 13:41:16 +00:00
3dddc55304
Optimize number of queries made by devhub version list view & display block status ( #22789 )
...
* Optimize number of queries made by devhub version list view & display block status
2024-10-25 13:54:56 +02:00
afbbe930d9
stop requiring reason for positive reviewer action resolving jobs ( #22791 )
2024-10-25 11:20:14 +01:00
51959ad668
Make growth threshold before flagging relative instead of absolute ( #22784 )
...
* Make growth threshold before flagging relative instead of absolute
`growth_threshold_before_flagging` for a given `UsageTier` is now
relative to the mean growth of all non-disabled add-ons in that
usage tier.
2024-10-22 15:33:15 +02:00
93fb6c5fec
Dev-mode ( #22748 )
...
* Decouple DEBUG from DEV_MODE to enable running dev/prod mode independent of debug.
* Update settings_test.py
Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>
* TMP: hardcode devmode false in prod
---------
Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>
2024-10-18 17:39:49 +02:00
97f3dbdbc2
Use internal data object for MLBF to accommodate soft/hard block versions ( #22775 )
...
* Use internal data object for MLBF to accommodate soft/hard block versions
* TMP: fix review
2024-10-18 15:02:38 +02:00
8b100c94ae
Hold actions on the back of decisions, rather than process them, if content is high profile ( #22766 )
...
* seperate decision from action enforcement
* implement hold actions for BAN_USER
* implement hold actions for DELETE_RATING
* implement hold action for DELETE_COLLECTION
* migration number clash
* implement old actions for DISABLE_ADDON
2024-10-18 11:24:26 +01:00
f8e7fa2958
Implement APIKey as django form + recaptcha field ( #22759 )
...
* API Key form with recaptcha and more susinct rendering
* Fix name variable in help text
2024-10-17 16:44:48 +02:00
e8a4b7de03
Add require_submissions_enabled decorator to FileUploadViewSet Create ( #22774 )
...
* Added require_submissions_enabled decorator to FileUploadViewSet.create()
* fix test, linting
2024-10-17 08:40:46 -04:00
c2fddde0c5
expose blocked version as blocked and soft_blocked in the API ( #22750 )
...
* expose blocked version as blocked and soft_blocked in the API
* explictly test all versions but not disabled scenario
2024-10-17 12:53:04 +01:00
a26bf8131b
Allow URLs in developer replies to ratings ( #22749 )
2024-10-16 18:03:56 +02:00
ed750ffd35
Tweak file upload limits: bump max uncompressed size, round down max upload size ( #22773 )
2024-10-16 17:59:47 +02:00
c31188ca7d
Force collation when comparing Denied Names to avoid unwanted collisions ( #22767 )
...
* Force collation when comparing Denied Names to avoid unwanted collisions
2024-10-16 13:03:43 +02:00
5130dd1889
Add Waffle Flag for Submissions ( #22729 )
2024-10-15 09:08:59 -04:00
5c6f86e3f1
Add recaptcha for new addon submission upload ( #22755 )
...
* Tests
* Add recaptcha to addon submit form
* TMP: cover negative case tests
2024-10-11 19:46:01 +02:00
daee988fcd
Remove initialize_docker: Integrate data initialization to make up ( #22663 )
...
* Integrate initialize command into make up flow
Rename "initialize_data" to "initialize"
Remove DOCKER_SERVICES as dangerous option given hard dependency on mysqld and elasticsearch.
Better timing for mysql healthcheck
* Partial revert of setup-ui-tests
* Fix initialization should always reindex
* TMP: fix
2024-10-11 19:08:39 +02:00
25c269626b
drop now unused abusereport.appellant_job and reporter_appeal_date ( #22754 )
2024-10-11 14:19:59 +01:00
Andrea Marchesini
Andrew Williamson
Christina Lin
Kevin Meinhardt
Mathieu Pillard
William Durand
Kevin Meinhardt
Andreas Wagner