* add canned reasons to blocksubmission admin
* build on ReviewActionReason for canned response instead
* Fix reviewers tests that didn't create a complete ReviewActionReason
* in migration default canned_block_reason field to '' for existing records
* Split New Theme Submission from the rest
For simplicity new version creation are not modified in this commit,
because we're already able to serve different content for them, or
gate them however we'd like, as we already have the add-on available.
* Display error message when trying to use theme submission flow to upload a non-theme
Note: this is not intended as a security measure, it's only to be
nice to users who accidentally ended up in the wrong flow.
* change version checkboxes to make it clearer between blocking and already blocked
* wrap blocked and not blocked icon & version string in a span, with title
* track Blocked versions per version
* update api docs
* test fixes
* scanners test fixes
* drop now obsolete create_blockversions command
* address review comments; fix failing tests
* restore warning messages about a version being in a submission or block
* add extra tests + optimizations
* Fix failing blocklist/test_serializers.py test
`white-space: pre-wrap` prevents lines from being broken unless an
explicit line break is in there.
Since the content of these fields are external (user-generated), there
is no guarantee of the line length to be within reasonable bounds.
Rather than stretching the layout, add `word-break: break-word` to allow
the line to be wrapped regardless.
* Lock compatibility information if it came from `gecko_android`
Manifest should be the source of truth for compatibility data for Android when
`gecko_android` if set.
* Remove obsolete compatibility changing code
The only add-ons left with strict compatibility should be langpacks,
and we don't want to continue allowing to dynamically alter their
compatibility via devhub.
* Test fixes
* More extra css/js that can be removed
* Remove unused import
* load version adus in review page xhr
* Add top 10 ADU versions box
* moved ADU block to RH sidebar; made style consistent; reviewers js now runs on documen load
* Show which versions have a due date in reviewer tools
Bonus:
- Change "risk" colors to go from yellow to red
- Move and rename "MAD" flag to avoid confusion with needs human review
- Allow changing due date again once the first change goes through
* Show & Allow removing Unlisted Auto-Approval Extra Delay in review tools
Also refactor how flags are displayed, adding a couple new ones and hiding the ones that are not relevant to the version shown in the review page because of the channel.
* Trim whitespace in admin search when query contains a comma
Makes is less likely to return '0 results' just because you accidentally
added a space or a trailing comma in IP search.
* Use IPLog only for IP searches in the admin
Using IPLog only makes the query a lot more efficient, previously the
multiple joins + OR were forcing MySQL to do a full table scan.
In addition:
- Leverage ip_address_binary (and most importantly, for faster searches (and in
the future, ranges)
- Use GROUP_CONCAT() to find and display all other IPs for each user in results
- Refactor existing frontend code to dynamically add/remove IPs from results
to use the new layout
* Simplify pretty_filename implementation ; use it when we display filenames
Make File.pretty_filename a property, and make it the main way to display
filenames in URLs & UI, to prepare for the replacement of the filename
field later.
* Should be a property now
* Remove unused/obsolete JavaScript
Could do more, but that's a good chunk already...
* Remove files no longer referenced
* Remove obsolete calls to removed functions
Andrew Williamson
Mathieu Pillard
Rob Wu
Mathieu Pillard
Bob Silverberg
Andreas Wagner