* Remove amo-validator, remove more support for uploading legacy-addons.
This is dropping most of our compatibility checks for legacy add-ons and
completely blocks them from being uploaded.
We workaround this block for mozilla-signed add-ons by issuing the same
error, just as a warning instead of an actual error.
This affected *loads* of our tests so the PR contains more test-changes
then I'd like.
In addition to that this PR adds file extension validation for uploads,
we only did that in our JavaScript and never in our code. So from now
on, we have a hard limit to only allow whatever is in
`VALID_EXTENSIONS`.
Further...
* drop amo-validator and related dependencies
* remove `dump_apps` management command
* removed unused fixture files from the repo
Fixes#10502
Future improvement idea for our test-suite: Unify add-on file fixtures
under one single folder to avoid any duplication.
There is most certainly some more improvements that could be made to
code and test structure but I went for the least changes, it's way too
huge already :-/
* Fix syntax error in JavaScript, thus ui tests
* Switch back to passing 'channel' around
* Move valid addon file extensions to constants/base
* Fix validate() call
* Fix more tests
* Update src/olympia/devhub/tests/test_views_validation.py
Co-Authored-By: EnTeQuAk <cg@webshox.org>
* Remove old comment
* Issue description specific only to Thunderbird and Seamonkey if targeting thunderbird or seamonkey
### Add additional search tests
* Check that search suggestion list exact matches higher than other suggestions
* Check that long terms searching don't break results page
* Verify blank search functionality
* Check that selecting an item from search suggestions can be made by clicking on it
* Check that ESC dismisses the suggestion search results
* Check that suggestions change if chars are added or deleted
* Check that special chars don't break search
* Check that caps and lowercases have same search suggestions
Personally, the current order adds a lot of stress to the user to click
the correct button.
When you upload your file (very first screen) the Continue button is on
the very left side, all continuous screens switch it to be on the right
hand site. Even though the 'Cancel' button is red, it takes a bit of
time to parse which button you're going to press and ending up in a
disabled/incomplete state isn't really nice.
This changes that behaviour and fixes#7556 along the way.
cc @jvillalobos or @wagnerand for opinions on that.
Unfortunately, we'll have to duplicate the environment config but I added
a comment so that should be fine. It's very rarely being used anyway.
Fixes#9288
Added new UI Tests.
* test_devhub_logout, tests logging out from the developer hub.
* test_devhub_register, tests the register links navigates to the fxa signup page.
* test_title_routes_to_home, tests Firefox Addons title routes to home page.
* test_more_dropdown_navigates_correctly, tests the more drop down navigates to the correct links.
* Changed fxa account generation to allow assigning an fxa ID to a created user.
* Moved pytest execution to makefile to access variables.
* Removed second login tests as the devhub tests also log in.
Fix our ui-tests.
* Update list of add-ons that are required for the July content update
* Mark `test_browse_all_themes_button_loads_correct_page` as xfail for now as the latest content update removed static theme listings from the home page
Andrew Williamson
renovate[bot]
William Durand
dbxnr
jrbenny35
Christopher Grebs
