* Add all fields/info needed in abuse admin detail page
* Set readonly_fields explicitly in the admin without using editable=False
DRF uses editable=False, and we definitely want those fields to be
writeable in the API.
* Add comment explaining use of Paginator()
* Remove amo-validator, remove more support for uploading legacy-addons.
This is dropping most of our compatibility checks for legacy add-ons and
completely blocks them from being uploaded.
We workaround this block for mozilla-signed add-ons by issuing the same
error, just as a warning instead of an actual error.
This affected *loads* of our tests so the PR contains more test-changes
then I'd like.
In addition to that this PR adds file extension validation for uploads,
we only did that in our JavaScript and never in our code. So from now
on, we have a hard limit to only allow whatever is in
`VALID_EXTENSIONS`.
Further...
* drop amo-validator and related dependencies
* remove `dump_apps` management command
* removed unused fixture files from the repo
Fixes#10502
Future improvement idea for our test-suite: Unify add-on file fixtures
under one single folder to avoid any duplication.
There is most certainly some more improvements that could be made to
code and test structure but I went for the least changes, it's way too
huge already :-/
* Fix syntax error in JavaScript, thus ui tests
* Switch back to passing 'channel' around
* Move valid addon file extensions to constants/base
* Fix validate() call
* Fix more tests
* Update src/olympia/devhub/tests/test_views_validation.py
Co-Authored-By: EnTeQuAk <cg@webshox.org>
* Remove old comment
* Issue description specific only to Thunderbird and Seamonkey if targeting thunderbird or seamonkey
Unless I'm mistaken there isn't anyone to really look at this and most
errors and problems should be related to legacy pages anyway.
Let's remove things we're not using or looking at.
Fixes#4845
Fixes#9515
Also fixes bugzilla.mozilla.org/show_bug.cgi?id=1390960
None of these are used in modern WebExtension world, the urls and views
we're deleting here have <5 requests per day according to datadog.
There may be a bit more css and js/html code we're able to delete but I
tried to be conservative and not remove too much.
This doesn't remove the data from ElasticSearch or models yet, I'll file
separate issues for these.
Also removes a handful of unused json fixtures along the way:
* src/olympia/addons/fixtures/addons/update-strict-compat-version.json
* src/olympia/amo/fixtures/base/charity.json
* src/olympia/amo/fixtures/base/garbage.json
* src/olympia/amo/fixtures/base/licenses.json
* src/olympia/devhub/fixtures/devhub/addon-compat-results.json
* src/olympia/legacy_discovery/fixtures/legacy_discovery/discoverymodules.json
* src/olympia/ratings/fixtures/ratings/three-reviews.json
This ports all amo-validator related code to run via subprocess. This
makes us less blocked by it not running on Python 3, there may still be
some installation / execution related bits to actually run it via python
2 instead of python 3 but that's something for later.
* Cleans up how and where we're setting _BIN settings for all the
binaries we're calling
* Backports `unicodehelper` from validator
* Removes `requeue_uploads` since it's been broken and unused for at
least 3-4 years
* Remove Standalone Add-on Compatibility Checker (/developers/addon/check-compatibility/)
* Remove compat-check related bits from standalone add-on upload
* Remove more bulk compat report stuff that isn't used anymore
* Removed zadmin application_versions.json view, unused
Fixes#9670
"Fixes" #8857
This pull request removes supported platform selection and replaces it
with selecting application explicitly. This way the developer can choose
between "Firefox" and "Firefox for Android" support and platforms are
always naively set to "PLATFORMS_ALL" since we want to get rid of
platforms eventually.
This cleans up most of the platform selection code that resides in devhub, views and templates since it's essentially unused now
This doesn't touch any of the platform handling in models since all of that has to continue working for legacy add-ons and WebExtensions that have different platforms selected
We are defaulting to "Firefox" (Desktop) compatibility with Android compatibility being optional
Regarding static themes, they are only compatible with Firefox Desktop currently which works seemlessly since we are defaulting to Firefox Desktop compatibility by default anyway and you can't select explicit Android compatibility for static themes.
That's why I removed all that "platforms to exclude" code and didn't implement a replacement for compatibility apps, any objections to that? We can do that if we have to, e.g if we decide to default to Firefox and Android support for regular WebExtensions.
Fixes#8752Fixes#6067
This allows selecting support for an application directly during submission
Fixes#9149
I kinda disagreed with the recommendation rom the issue because then we have the word "submit" or "submission" in that sentence way too many times. I don't mind adding it though 🤷♂️
> when fixing this, it might be a good idea to also address the following section from the Source code upload form:
> There is a text in the PRD which was partially omitted in the implementation:
> PRD: "You may need to submit source code with your submission. "
> AMO: "You may need to submit source code"
If the user submits the source code:
* make source upload a separate upload step before details
* standard bullet points
* drop webpack link; italitize tech names as per prd.
* copy updates and css restructuring
* Add JS to drop any source file from submission if 'no' is selected.
* && because Javascript
This removes the following features from collections:
- Ability to browse all public collections and sort through them
- Collection feeds
- Collection admin edition (the functionality is kept but instead
moved to the django admin)
- Collection contributors (instead, just allow people with
Collections:Contribute to edit add-ons of the featured themes
collection.
This allows us to get rid of some long-standing performance issues with
the database queries associated with those features, improving overall
stability of the site.
Database migration removing collections_users table will be added
in a later commit to keep backwards-compatibility when this one is
pushed to production.
(it depends on the presence of the object-lead class on a parent,
but we need to adjust the padding accordingly now that the styles
have been simplified)
- border-bottom on header needs to go for the banner to be
seamlessly displayed below
- scrollback hack is replaced with a overflow-x: hidden on the
body because it causes a slight misalignment that is difficult
to overcome without additional markup (which differs depending
on which platform you're using, which does not help...)
- padding/line-height adjusted per mocks
The banner is behind a 'try-new-frontend' waffle, which defaults to off
for the moment.
A few yaks had to be shaved to achieve all this:
- The banner code was separated and called from zamboni/global.js, in
order to be shown on non-impala pages (i.e. themes).
- The banner code was modified to try to only display one banner at a
time.
- Because the banners were not shown in non-impala pages before, some
tweaks to the layout css properties were made, to make sure the banner
have the correct margin everywhere.
- The mobile site link handling code prevents default to avoid following
a link to '#'.
Unfortunately the "featured" class is used everywhere, for all kinds
of things. So we only want to drop the width/height auto on the
featured section of the browse pages where it also has the
listing-grid class.
Though the main fix is to remove the width/height: auto, removing
the compatibility messages also help prevent potential display issues
because it makes the box smaller. A user on Chrome probably does not
care much about which version of Firefox or which platforms the
add-ons are compatible with anyway.
* Hide the install button entirely for incompatible versions in listing pages
Also show "download anyway" button when incompatible (it was already
displayed when showing the "Only with Firefox" button, this makes it
available to every incompatible situation)
* space after comma
We don't officially support BSD, but this small change should
improve the life of its users by letting them install add-ons
marked as compatible with Linux instead of "All platforms".
This commit contains multiple small changes that go together:
Some pages are not "impala"-ed and therefore don't get the impala
and restyle styles, so they weren't getting the pointer-events: none
rule that disable the buttons. Fixing those pages would require a
lot more work, so the impala button styles have been added to the
base css bundle instead.
In addition, the restyle was setting pointer-events: all on disabled
buttons, but since we are no longer showing the popup on those buttons
we can remove that.
It was also possible in some pages to get the wrong style for a
a.button element with an href that you had already visited, because
the restyle wasn't targeting visited links, so this is changed as
well. Since doing this added more rules that previously weren't
always applied, the background position and color of the concealed
button also had to be specified.
Finally, there was an extra case where the more-versions link was
missing the newline that separates it from the compatibility info,
this was fixed.
- Hide the message in versions page
- Make padding/margin of that message more uniform accross pages
- Align text on the left cause there might be a lot of it
* containers shield study page
* Add consent page for Privacy Settings shield study
* update Containers to shield_study_15
* final .xpi urls
* make and use shield_study_1[45]/main.css files
* make and use static/img/shield_study_1[45]
* Re-add support for addon_id support as GET argument.
This is a regression introduced in 218c0c75dfFixes#5854
* Fix this the right way, make javascript behave and send the addon_id as
POST.
* Remove test
* Expose is_restart_required property on files in the search/detail API
* Fix mapping tests
* Replace no_restart field (and HTML/CSS for consistency) by is_restart_required
* Move migration now that 953 is taken
* Remove old model field entirely.
Andrew Williamson
Mathieu Pillard
Mathieu Pillard
Kumar McMillan
suhailsinghbains
Christopher Grebs
Varun Dey
ajupazhamayil
Mohit Bansal (Philomath)
Shatrughn Gupta
Yash Sharma
Jasmin Bom
Andrei Petre
Rihan
Ankush Chadda
lavish205
deepanshu-jain1999
Shivam Singhal
Andreas Wagner
Sanyam Khurana
Sean Prashad
Raffaele
Sean
Vishal Sharma
Jesse Cochran
Philipp Kewisch
Daniel Schep
Phillyp Henning
Ian Henderson
Michael Kelly
Stuart Colville
Trishul
Atique Ahmed Ziad
Apoorva Pandey
Trishul Goel
Trishul Goel
Gregg Lind
luke crouch
Matthew Riley MacPherson
Kamyar Ardekani
