* Remove unused/obsolete JavaScript
Could do more, but that's a good chunk already...
* Remove files no longer referenced
* Remove obsolete calls to removed functions
* Remove impala templates, pages and css we don't use
Also rework the few remaining things that depended on those templates and styles
* reblackify this file
* Remove obsolete tests
* Simplify header_title
* Leave space for the (larger) preview in DevHub > My Themes
* Fix it like that
* Also fix RTL display of devhub's dashboard
* Also fix submit button white-space to allow overflow
* Remove devhub/base_impala.html, re-implement missing dashboard CSS as a result
In the dashboard, there are a few minor alignment differences of 1px, as well as:
- A slightly darker shade of gray for text, to improve readability
- A slightly larger font size for the buttons
- A different pagination style to match the rest of devhub
* Actually remove base_impala.html
* Don't change this
* Adjust test with new pagination template
* Move addon_listing_header() (and new_context())
* Remove ui.lightbox.js
Only real usage left was in reviewer tools, though it was referenced in bundles
for pages long gone (legacy frontend, legacy discovery pane).
* Also remove images
* Fix icons previews when clicking on default icon in devhub
* Update src/olympia/devhub/tests/test_forms.py
Co-authored-by: Andrew Williamson <awilliamson@mozilla.com>
Co-authored-by: Andrew Williamson <awilliamson@mozilla.com>
* Update copy for submission flow
* Add a translation for the test to work
* Update test link
* More links tests to update
* This test is different in version submission
* Whitespace
* Remove unlisted-specific messaging
* Find abuse reports for a particular add-on using guid and not addon_id
When an abuse report is submitted from a guid (what Firefox does),
no longer try to associate if with a single add-on in the database,
because we can't know which one it is.
In reviewer tools, look up abuse reports for a given add-on by guid,
so that we can find all potential abuse reports even if a guid has
been re-used.
* Small doc clarification
* Black
* Fix unused imports
* Address review comments
* replace tag selection in devhub with checkboxes
* exclude dynamic theme tag (to be removed later)
* fix (existing) bug where tags wouldn't appear after edit for unlisted
* codestyle fix
* Replace legacy assets cachebusting by staticfiles's ManifestStaticFilesStorage from django
* Run tests without ManifestStaticFilesStorage
* Fix tests
* Reformatting
* It's fine, since collectstatic also copies the original
* Register static directly
* Reformat comment
* Log a specific action for force disable/enable, show it in reviewer tools
Also set change status action user to the task user at all times,
because it's an automated action normal users aren't responsible for.
* task user doesn't necessarily exist in tests
* Fix reviewer tests
* Fix versions tests
* Fix devhub tests
* Fix blocklist tests
* Remaining test fixes
- Review link is now on the channel column, always repeated
- Guid is now back to being a separate column
- Name and guid duplicates are now always eliminated
- Download link column has been added
* Group scanner query results by add-on and channel
The way django generates the changelist makes it a bit tricky to
customize, so we run some javascript once the dom is loaded to tweak
the rowspans, remove duplicate cells and add relevant css classnames.
* Initialize variable correctly
* Add missing const/use strict